You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9edf892
Browse filesBrowse the repository at this point in the historyBrowse files
docs(folders): correct four comments that claimed more than the code does (#6063)
A comment pass over this branch found four factual errors, all mine:
- the admin route test justified its column-pinned assertion with reasoning
copied from lifecycle.test.ts — that condition has no second isNull node, so
the stated vacuity could not occur there
- 'every clause mirrors one column of the partial unique index' was wrong:
deletedAt is the index PREDICATE, and name has no clause at all
- 'optimistic client reparents can write a cycle' is unsupported —
wouldCreateFolderCycle has one caller and no write path bypasses it; the real
origin is two concurrent reparents each passing the check
- 'restoreFolder runs restoreChildren BEFORE un-archiving' holds only for the
injected hook path; the in-transaction fallback runs after restoreFolderRows
The rest trims comments that restated the code or duplicated a TSDoc block on
the module under test, and pins three presence-only isNull assertions to the
deletedAt column so they cannot be satisfied by an unrelated nullable filter —
the same fragility that made an earlier assertion here vacuous.
0 commit comments