fix: address release review findings (#8276)

* fix(desktop): admit browser download saves before reading the body

PUT /api/desktop/tool/file buffered up to 100 MiB of the request body
before the use case checked that the tool call exists, is a running
browser_save_download claimed by the desktop, and belongs to the caller's
run, so any signed-in user could force large reads with bogus toolCallIds.

Add admitBrowserDownloadSave (same operation and binding resolution as
saveBrowserDownload, no claim or audit), following the existing
admitCreateWorkspaceFile pattern, and run it before the body read. The
save use case still re-validates and claims atomically after the read,
so a failed or oversized upload never burns the single-use claim.

* fix(desktop): walk cross-realm shadow roots when resolving upload targets

resolveFileInputTarget climbed out of shadow roots with `root instanceof ShadowRoot`.
Elements in same-origin iframes belong to the frame's realm, so the check was false
for their shadow roots and the ancestor walk stopped at the shadow boundary, failing
browser_upload_file with "no nearby file input". Use the file's duck-typed
`'host' in root` idiom like every other shadow-host hop.

* fix(chat): keep an activity's completed title off runs while it still waits on the user

Every run of a main-lane activity segment received the segment-wide activity,
including its completedTitle. A finished multi-call run before a pending
approval or terminal handoff (which splits the segment into runs) therefore
read the past-tense completed title while the activity was still unfinished.

Runs now receive the completed title only once every call in the segment has
finished; until then they keep the activity's in-progress title and summarize
their own calls. Fully finished activities render exactly as before.

* fix(search): keep partial coverage through persisted search compaction

compactRetrievalCitations kept only citations, dropping data.retrieval, and
stripToolResultOutput applies it on both save and load. A reloaded timed-out
search with no matches therefore rendered "No results", which the live UI and
the tool itself deliberately avoid because partial results cannot establish
absence.

Compaction now keeps a bounded retrieval: { status: 'partial' } marker (never
the full retrieval object), and re-compacting compacted output keeps it.
Complete searches compact exactly as before.

* fix(organization): route chat URLs the same way as organization Home

The chat page gated on (mothershipAvailable || memberScoped) while
OrganizationHome renders nothing without copilot.use, or without Build and
Search. A viewer with copilot.use but neither Build nor Search, and a
Search-only viewer opening an assistant chat, got a blank page. Apply
Home's two redirects (Search when copilot.use is denied, workspace
settings when neither Build nor Search is allowed) before loading the
chat, through one getOrganizationHomeRedirect shared by both pages so
they cannot drift again; the later copilot.use redirect becomes
unreachable and is removed.

* fix(organization): keep a custom date range when Home restores Search results

organizationHomeParsers already reads from/to, but OrganizationHomeContent
passed only source and updated to searchFiltersFromParams, so a Home URL
with updated=custom restored an unbounded search. Pass from/to through,
matching the workspace results view, and add them to the effect deps.

* fix(chat): project desktop tabs in organization Assistant chats

Organization Home passed projectsDesktopTabs: false to useChat in Assistant
mode, which only nulls the native active-tab ids used for the strip's
fallback. ChatResourcePanel still projects the chat scope's browser and
terminal tabs in every mode, and chat link clicks in the desktop app open
those tabs through the same projection, so Assistant chats showed desktop
tabs while ignoring which one the desktop app remembers (the #7793 reopen
behavior). Build Home's options with getMothershipUseChatOptions, like
workspace Home, so tabs project consistently in every mode. Assistant
requests still attach no resources.

* fix(home): make the chat/resource panel divider keyboard-adjustable

The resource panel divider (moved into the shared ChatPanelLayout this release,
identical to main's home.tsx) was pointer-only: a separator with no tabIndex,
key handling, or aria-value*, so keyboard users could not focus or resize it.

Mirror the file text-editor split: the divider is now a focusable separator
with ArrowLeft/ArrowRight steps and Home/End. Both separators now read keys
through one readSeparatorKey helper (modifier and IME guard included). Keyboard widths go through the same MIN/max clamps as the drag
(keyboardPanelWidth next to panelWidthAt), land without the width transition
like the window-resize clamp (shared writeWidthInstantly), are ignored during a
live drag, and claim the resource view like a pointer resize. aria-valuenow/min/
max are written imperatively on focus, key, and drag end, preserving the hook's
zero-render resize design. Focus-visible outline matches the text-editor split.

* docs(rules): scope member avatar aria-hidden to rows that show the name

The settings-pages rule said every member avatar renders aria-hidden because
the name is always beside it. MemberRow shows only the email, so its avatar
correctly stays labelled (role=img, aria-label=name), matching the emcn Avatar
TSDoc. Reword the rule and regenerate the Cursor projection.

* docs(skills): clarify service-mode selector guidance in add-connector

The skill said service mode requires shared selectors, but GitLab (service
mode only) uses plain host/project inputs. Align with the live-search README:
verification is mandatory; shared selectors apply only to resource pickers.

* fix(home): keep a focused divider's value current through window resizes

The window-resize clamp updated the panel width but not the focused
divider's aria-valuemax/valuenow, so assistive tech kept the old bounds
until the divider was focused again. The clamp now also reports to the
divider while it holds focus, including when the pinned width stays
within the new bounds.

Author: waleedlatif1

.agents/skills/add-connector/SKILL.md

@@ -8,7 +8,7 @@ argument-hint: <service-name> [api-docs-url]
 
 ## Choose the connector runtime first
 
-For **Sim Search**, use the live provider workflow in [the federated Search developer guide](../../../apps/sim/lib/sim-search/live/README.md#adding-a-live-search-connector). Its browser-safe provider catalog owns provider IDs, API origins, credential aliases, and account modes; its typed runtime registry requires both search and read handlers. `ConnectorMeta` remains the owner of logos and setup fields. Member mode has no admin resource filters. Service mode requires independent live source verification and shared selectors. Do not implement a Search source by adding a crawler, embeddings, or a scheduled ACL build.
+For **Sim Search**, use the live provider workflow in [the federated Search developer guide](../../../apps/sim/lib/sim-search/live/README.md#adding-a-live-search-connector). Its browser-safe provider catalog owns provider IDs, API origins, credential aliases, and account modes; its typed runtime registry requires both search and read handlers. `ConnectorMeta` remains the owner of logos and setup fields. Member mode has no admin resource filters. Service mode requires independent live source verification; resource pickers use shared selectors with canonical manual-input pairs, and plain inputs are fine where no picker applies. Do not implement a Search source by adding a crawler, embeddings, or a scheduled ACL build.
 
 The ingestion instructions below apply to **ordinary knowledge-base connectors** and the explicit legacy Search backend (`SIM_SEARCH_LIVE=false`). If a provider supports both, implement and test both runtimes; adding `search: true` to metadata alone does not implement federated search. Preserve indexing documentation and behavior for those KB/legacy callers.
 

.claude/rules/sim-settings-pages.md

@@ -252,11 +252,12 @@ and — on activatable rows only — the hover band. Never hand-roll any of it,
 
 
 **One member avatar.** Every member list, owner cell, and ranking renders emcn
-`<Avatar size='xs' name={…} src={…} aria-hidden />` — a 14px photo, or the initial
-on the neutral disc (`aria-hidden` because the name is always beside it). Never
-hand-roll an avatar or give a person a `getUserColor` hash; per-person colors
-belong to live collaboration (presence, cursors), where the color matches that
-person's cursor.
+`<Avatar size='xs' name={…} src={…} />` — a 14px photo, or the initial on the
+neutral disc. Pass `aria-hidden` only when the member's name is visibly rendered
+beside it; an email-only row (`MemberRow`) keeps the avatar labelled because it
+carries the name. Never hand-roll an avatar or give a person a `getUserColor`
+hash; per-person colors belong to live collaboration (presence, cursors), where
+the color matches that person's cursor.
 
 ## Header action order
 

.cursor/rules/sim-settings-pages.mdc

@@ -249,11 +249,12 @@ and — on activatable rows only — the hover band. Never hand-roll any of it,
 
 
 **One member avatar.** Every member list, owner cell, and ranking renders emcn
-`<Avatar size='xs' name={…} src={…} aria-hidden />` — a 14px photo, or the initial
-on the neutral disc (`aria-hidden` because the name is always beside it). Never
-hand-roll an avatar or give a person a `getUserColor` hash; per-person colors
-belong to live collaboration (presence, cursors), where the color matches that
-person's cursor.
+`<Avatar size='xs' name={…} src={…} />` — a 14px photo, or the initial on the
+neutral disc. Pass `aria-hidden` only when the member's name is visibly rendered
+beside it; an email-only row (`MemberRow`) keeps the avatar labelled because it
+carries the name. Never hand-roll an avatar or give a person a `getUserColor`
+hash; per-person colors belong to live collaboration (presence, cursors), where
+the color matches that person's cursor.
 
 ## Header action order
 

apps/desktop/src/main/browser-agent/page-functions.test.ts

@@ -912,6 +912,21 @@ describe('collectSnapshot', () => {
     expect(captured.input.ownerDocument).toBe(document)
   })
 
+  it('climbs out of a shadow root inside a same-origin frame to find the file input', () => {
+    const frame = document.createElement('iframe')
+    document.body.append(frame)
+    const childDocument = frame.contentDocument as Document
+    childDocument.body.innerHTML = '<div id="host"></div><input type="file">'
+    const host = childDocument.getElementById('host') as HTMLElement
+    const button = childDocument.createElement('button')
+    host.attachShadow({ mode: 'open' }).append(button)
+    const input = childDocument.querySelector('input') as HTMLInputElement
+    register(button)
+
+    expect(button.getRootNode()).not.toBeInstanceOf(ShadowRoot)
+    expect(resolveFileInputTarget(0)).toEqual({ input, document: childDocument })
+  })
+
   it('refuses a disconnected or stale upload reference', () => {
     const input = document.createElement('input')
     input.type = 'file'

apps/desktop/src/main/browser-agent/page-functions.ts

@@ -3348,7 +3348,7 @@ export function resolveFileInputTarget(id: number): {
       )
     if (candidates.length === 1) input = candidates[0]
     const root = scope.getRootNode()
-    scope = scope.parentElement ?? (root instanceof ShadowRoot ? root.host : null)
+    scope = scope.parentElement ?? ('host' in root ? (root.host as Element) : null)
   }
   if (!input) throw new Error('The selected element has no nearby file input.')
   if (input.matches(':disabled')) throw new Error('The file input is disabled.')

apps/sim/app/api/desktop/tool/file/route.test.ts

@@ -6,9 +6,14 @@ import { NextRequest } from 'next/server'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
 
-const { mockRead, mockSave } = vi.hoisted(() => ({ mockRead: vi.fn(), mockSave: vi.fn() }))
+const { mockAdmit, mockRead, mockSave } = vi.hoisted(() => ({
+  mockAdmit: vi.fn(),
+  mockRead: vi.fn(),
+  mockSave: vi.fn(),
+}))
 
 vi.mock('@/lib/browser-agent/application/browser-file-transfer', () => ({
+  admitBrowserDownloadSave: mockAdmit,
   readBrowserUploadFile: {
     operation: { id: 'files.read_content', minimumRole: 'read', workspaceApiKey: 'allow' },
     execute: mockRead,
@@ -43,6 +48,7 @@ describe('/api/desktop/tool/file', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     mockGetSession.mockResolvedValue(session)
+    mockAdmit.mockResolvedValue(undefined)
     mockRead.mockResolvedValue({ file: { name: 'Q3 plan.pdf' }, content: Buffer.from('%PDF') })
     mockSave.mockResolvedValue({
       file: { name: 'report.csv', size: 3, folderPath: null, vfsNamespace: 'files' },
@@ -92,6 +98,21 @@ describe('/api/desktop/tool/file', () => {
       put('toolCallId=c&name=a.csv', new Uint8Array(1), { 'content-length': String(2 ** 31) })
     )
     expect(oversized.status).toBe(413)
+    expect(mockAdmit).not.toHaveBeenCalled()
+    expect(mockSave).not.toHaveBeenCalled()
+  })
+
+  it('refuses an unadmitted save without reading its body', async () => {
+    mockAdmit.mockRejectedValueOnce(
+      new OrchestrationError('not_found', 'Browser file transfer not found')
+    )
+    const request = put('toolCallId=unknown&name=a.csv', new Uint8Array([1, 2, 3]))
+
+    const res = await PUT(request)
+
+    expect(res.status).toBe(404)
+    expect(mockAdmit).toHaveBeenCalledWith(principal, { toolCallId: 'unknown', name: 'a.csv' })
+    expect(request.bodyUsed).toBe(false)
     expect(mockSave).not.toHaveBeenCalled()
   })
 

apps/sim/app/api/desktop/tool/file/route.ts

@@ -13,6 +13,7 @@ import {
 } from '@/lib/api/server/routes'
 import { withRequestId } from '@/lib/api/server/routes/request-id'
 import {
+  admitBrowserDownloadSave,
   readBrowserUploadFile,
   saveBrowserDownload,
 } from '@/lib/browser-agent/application/browser-file-transfer'
@@ -52,8 +53,9 @@ export const POST = defineInternalBinaryRoute({
  * PUT /api/desktop/tool/file?toolCallId=…&name=…
  *
  * Raw `withRouteHandler`: the body is the download's bytes, so it is admitted by declared length
- * and read under a byte ceiling only after the session is authenticated, then handed to the
- * application use case that binds it to its claimed `browser_save_download` call.
+ * and read under a byte ceiling only after the session is authenticated and the application has
+ * admitted the caller's claimed `browser_save_download` call, then handed to the use case that
+ * re-validates and claims that call.
  */
 export const PUT = withRouteHandler(async (request: NextRequest) => {
   let principal
@@ -73,6 +75,13 @@ export const PUT = withRouteHandler(async (request: NextRequest) => {
   }
   const parsed = await parseRequest(saveBrowserDownloadContract, request, {})
   if (!parsed.success) return parsed.response
+  const { toolCallId, name } = parsed.data.query
+
+  try {
+    await admitBrowserDownloadSave(principal, { toolCallId, name })
+  } catch (error) {
+    return saveErrorResponse(error)
+  }
 
   let content: Buffer
   try {
@@ -93,16 +102,21 @@ export const PUT = withRouteHandler(async (request: NextRequest) => {
   try {
     const { file } = await saveBrowserDownload.execute({
       principal,
-      input: { toolCallId: parsed.data.query.toolCallId, name: parsed.data.query.name, content },
+      input: { toolCallId, name, content },
       request,
     })
     return NextResponse.json({ path: workspaceFileVfsPath(file), name: file.name, size: file.size })
   } catch (error) {
-    const response = internalFileErrorPolicies.concealContentAuthorization.project(error)
-    if (!response) throw error
-    return NextResponse.json(withRequestId(response.body), {
-      status: response.status,
-      headers: response.headers,
-    })
+    return saveErrorResponse(error)
   }
 })
+
+/** Projects a typed download-save failure, rethrowing anything the policy does not classify. */
+function saveErrorResponse(error: unknown): NextResponse {
+  const response = internalFileErrorPolicies.concealContentAuthorization.project(error)
+  if (!response) throw error
+  return NextResponse.json(withRequestId(response.body), {
+    status: response.status,
+    headers: response.headers,
+  })
+}

apps/sim/app/o/[organizationId]/chat/[chatId]/page.tsx

@@ -6,6 +6,7 @@ import { getAccessibleCopilotChatAuth } from '@/lib/mothership/chat/lifecycle'
 import { WORKSPACE_SETTINGS_PATH } from '@/lib/navigation/paths'
 import { getOrganizationSurfaceContext } from '@/lib/organizations/surface'
 import OrganizationChatLoading from '@/app/o/[organizationId]/chat/[chatId]/loading'
+import { getOrganizationHomeRedirect } from '@/app/o/[organizationId]/home/home-redirect'
 import { OrganizationHome } from '@/app/o/[organizationId]/home/organization-home'
 
 export const metadata: Metadata = { title: 'Chat' }
@@ -20,8 +21,8 @@ export default async function OrganizationChatPage({
   if (!session?.user?.id) notFound()
   const context = await getOrganizationSurfaceContext(organizationId, session.user.id)
   if (!context) notFound()
-  if (!context.mothershipAvailable && !context.searchAccess.memberScoped)
-    redirect(WORKSPACE_SETTINGS_PATH)
+  const homeRedirect = getOrganizationHomeRedirect(context, organizationId)
+  if (homeRedirect) redirect(homeRedirect)
   const chat = await getAccessibleCopilotChatAuth(chatId, session.user.id, {
     principal: { kind: 'session', userId: session.user.id, sessionId: session.session.id },
   })
@@ -38,7 +39,6 @@ export default async function OrganizationChatPage({
       </Suspense>
     )
   }
-  if (!context.mothershipAvailable) redirect(WORKSPACE_SETTINGS_PATH)
   return (
     <Suspense fallback={<OrganizationChatLoading />}>
       <OrganizationHome

apps/sim/app/o/[organizationId]/home/home-redirect.ts

@@ -0,0 +1,20 @@
+import { organizationRoutes, WORKSPACE_SETTINGS_PATH } from '@/lib/navigation/paths'
+import type { OrganizationSurfaceContext } from '@/lib/organizations/surface'
+
+/**
+ * Where organization Home and its chat URLs send a viewer Home cannot serve, or `null` when
+ * Home renders. Search when Chat is off but member Search is on; workspace settings when the
+ * viewer can neither both chat and build, nor search as a member.
+ */
+export function getOrganizationHomeRedirect(
+  context: Pick<OrganizationSurfaceContext, 'mothershipAvailable' | 'canBuild' | 'searchAccess'>,
+  organizationId: string
+): string | null {
+  if (!context.mothershipAvailable && context.searchAccess.memberScoped) {
+    return organizationRoutes(organizationId).search
+  }
+  if (!(context.mothershipAvailable && context.canBuild) && !context.searchAccess.memberScoped) {
+    return WORKSPACE_SETTINGS_PATH
+  }
+  return null
+}

apps/sim/app/o/[organizationId]/home/organization-home.test.tsx

@@ -69,7 +69,10 @@ vi.mock('@/lib/core/utils/browser-storage', () => ({
 vi.mock('@/app/o/[organizationId]/providers/organization-provider', () => ({
   useOrganizationContext: mocks.context,
 }))
-vi.mock('@/app/workspace/[workspaceId]/home/hooks/use-chat', () => ({ useChat: mocks.chat }))
+vi.mock('@/app/workspace/[workspaceId]/home/hooks/use-chat', () => ({
+  getMothershipUseChatOptions: (options: object) => ({ ...options, mothership: true }),
+  useChat: mocks.chat,
+}))
 vi.mock('@/hooks/queries/mothership-chats', () => ({
   useMarkMothershipChatRead: () => ({ mutate: mocks.markRead }),
 }))
@@ -602,7 +605,7 @@ describe('Home permission-selected harness', () => {
     expect(mocks.chat).toHaveBeenLastCalledWith(
       { organizationId: 'organization-a' },
       'search-a',
-      expect.objectContaining({ requestMode: 'assistant', projectsDesktopTabs: false })
+      expect.objectContaining({ requestMode: 'assistant', mothership: true })
     )
   })
   it('keeps old Build history readable after permission removal without a writable composer', async () => {
@@ -892,6 +895,23 @@ it('restores an explicitly selected search panel on empty Home without reusing t
   expect(mocks.send).not.toHaveBeenCalled()
 })
 
+it('restores a custom date range with the search panel', async () => {
+  mocks.activeResource = 'search:organization:organization-a'
+  await act(async () =>
+    renderHome(<OrganizationHome />, '?q=Orion&updated=custom&from=2026-09-01&to=2026-09-03')
+  )
+  expect(mocks.addResource).toHaveBeenCalledWith(
+    expect.objectContaining({
+      search: expect.objectContaining({
+        filters: {
+          modifiedAfter: new Date(2026, 8, 1).toISOString(),
+          modifiedBefore: new Date(2026, 8, 4, 0, 0, 0, -1).toISOString(),
+        },
+      }),
+    })
+  )
+})
+
 it('does not reopen closed search results merely because a query remains in the URL', async () => {
   await act(async () => renderHome(<OrganizationHome />, '?searchLevel=adaptive&q=Orion'))
   expect(mocks.addResource).not.toHaveBeenCalled()