fix(admin): show ineligible workspaces with the reason

Filtering drifted rows out of the candidate search fixed the 400 but replaced
it with something worse: the workspace vanished. An empty result is
indistinguishable from 'no such workspace', so an admin searching by name
learns nothing and has no next step.

Return ineligible candidates with an ineligibleReason instead, and let the UI
render them disabled with the explanation inline.

describeWorkspaceMoveIneligibility is now the single source of truth that
assertWorkspaceMovable throws from, so the search and the guard cannot drift
apart again — which is exactly how the original 400 happened.

Author: mzxchandra

apps/sim/lib/api/contracts/v1/admin/dashboard-workspaces.ts

@@ -64,6 +64,12 @@ const adminDashboardWorkspaceCandidateSchema = z.object({
   billedAccountUserId: z.string(),
   /** Archived workspaces are movable; the flag lets admin UIs label them. */
   archived: z.boolean(),
+  /**
+   * Non-null when the workspace cannot be moved. Ineligible rows are returned
+   * rather than filtered out so the admin learns the workspace exists and why
+   * it is stuck, instead of an empty result they cannot act on.
+   */
+  ineligibleReason: z.string().nullable().optional(),
 })
 
 /** Usage split so the UI can separate what leaves from what breaks behind. */

apps/sim/lib/workspaces/admin-move.ts

@@ -133,6 +133,8 @@ export interface WorkspaceMoveCandidate {
   billedAccountUserId: string
   /** Archived workspaces are movable; surfaced so admin UIs can label them. */
   archived: boolean
+  /** Non-null when the workspace cannot be moved, explaining why. */
+  ineligibleReason?: string | null
 }
 
 /**
@@ -443,29 +445,24 @@ export async function searchWorkspaceMoveCandidates(search: string, limit = 20,
     .from(workspace)
     .innerJoin(user, eq(user.id, workspace.ownerId))
     .leftJoin(organization, eq(organization.id, workspace.organizationId))
-    .where(
-      and(
-        or(eq(workspace.id, query), ilike(workspace.name, `%${query}%`)),
-        /**
-         * Never offer a candidate that `assertWorkspaceMovable` will reject.
-         * Dropping the old personal-only filters made every drifted row —
-         * `workspaceMode` disagreeing with whether an organization is assigned
-         * — searchable, and each one 400s the moment it is clicked. Mirror the
-         * guard here so an unusable row cannot be selected in the first place.
-         */
-        sql`(${workspace.workspaceMode} = ${WORKSPACE_MODE.ORGANIZATION}) = (${workspace.organizationId} is not null)`
-      )
-    )
+    .where(and(or(eq(workspace.id, query), ilike(workspace.name, `%${query}%`)), undefined))
     .orderBy(asc(workspace.name))
     .limit(Math.min(Math.max(limit, 1), 50))
     .offset(Math.max(offset, 0))
 
   const boundedLimit = Math.min(Math.max(limit, 1), 50)
   const total = rows[0]?.total ?? 0
   return {
+    /**
+     * Ineligible rows are returned, not hidden. A support admin searching for a
+     * workspace by name needs to learn that it exists and why it cannot move —
+     * an empty result is indistinguishable from "no such workspace" and leaves
+     * them with no next step.
+     */
     data: rows.map(({ archivedAt, total: _total, ...row }) => ({
       ...row,
       archived: archivedAt !== null,
+      ineligibleReason: describeWorkspaceMoveIneligibility(row),
     })),
     pagination: {
       total,
@@ -1637,20 +1634,26 @@ async function searchWorkspaceById(workspaceId: string): Promise<WorkspaceMoveCa
  * `changeWorkspaceStoragePayerInTx` an `expectedCurrentPayer` that cannot be
  * trusted, so it must be repaired before it can be moved.
  */
+export function describeWorkspaceMoveIneligibility(row: {
+  workspaceMode: string
+  organizationId?: string | null
+}): string | null {
+  const isOrganizationMode = row.workspaceMode === WORKSPACE_MODE.ORGANIZATION
+  const hasOrganization = row.organizationId !== undefined && row.organizationId !== null
+  if (isOrganizationMode === hasOrganization) return null
+  return isOrganizationMode
+    ? 'In organization mode but no organization is assigned. Repair the row before moving it.'
+    : 'Has an organization assigned but is not in organization mode. Repair the row before moving it.'
+}
+
 function assertWorkspaceMovable(row: {
   archivedAt?: Date | null
   workspaceMode: string
   organizationId?: string | null
 }): void {
-  const isOrganizationMode = row.workspaceMode === WORKSPACE_MODE.ORGANIZATION
-  const hasOrganization = row.organizationId !== undefined && row.organizationId !== null
-  if (isOrganizationMode !== hasOrganization) {
-    throw new WorkspaceMoveError(
-      isOrganizationMode
-        ? 'Workspace is in organization mode but has no organization assigned'
-        : 'Workspace has an organization assigned but is not in organization mode',
-      'already-organization-workspace'
-    )
+  const reason = describeWorkspaceMoveIneligibility(row)
+  if (reason) {
+    throw new WorkspaceMoveError(reason, 'already-organization-workspace')
   }
 }