fix(tables): mint fork-copied table ids with the same tbl_ shape as created ones

Author: icecrasher321

apps/sim/ee/workspace-forking/lib/copy/copy-resources.test.ts

@@ -1307,6 +1307,10 @@ describe('copyForkResourceContainers table views', () => {
 
     const copiedTableId = result.idMap.get('table')?.get('table-with-view')
     const legacyTableId = result.idMap.get('table')?.get('legacy-table')
+    // A copied table's id has the same shape as a created one, so nothing downstream can
+    // tell which path minted it.
+    expect(copiedTableId).toMatch(/^tbl_[0-9a-f]{32}$/)
+    expect(legacyTableId).toMatch(/^tbl_[0-9a-f]{32}$/)
     const copiedViews = inserted.get(tableViews)
     expect(copiedViews).toEqual(
       expect.arrayContaining([

apps/sim/ee/workspace-forking/lib/copy/copy-resources.ts

@@ -57,6 +57,7 @@ import {
   replaceKnowledgeDocumentSecretProvenanceInTx,
 } from '@/lib/knowledge/secret-provenance'
 import { DEFAULT_TABLE_VIEW_NAME } from '@/lib/table/constants'
+import { generateTableId } from '@/lib/table/ids'
 import { nKeysBetween } from '@/lib/table/order-key'
 import {
   classifyTableRowSecretProvenanceForCopy,
@@ -673,7 +674,7 @@ export async function copyForkResourceContainers(
     const inserts: (typeof userTableDefinitions.$inferInsert)[] = []
     const viewInserts: (typeof tableViews.$inferInsert)[] = []
     for (const definition of definitions) {
-      const childTableId = generateId()
+      const childTableId = generateTableId()
       const remappedSchema = remapForkTableWorkflowGroups(
         definition.schema as TableSchema,
         workflowIdMap,

apps/sim/lib/table/ids.test.ts

@@ -0,0 +1,15 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import { generateTableId } from '@/lib/table/ids'
+
+describe('generateTableId', () => {
+  it('mints a tbl_ prefix over a dash-stripped UUID', () => {
+    expect(generateTableId()).toMatch(/^tbl_[0-9a-f]{32}$/)
+  })
+
+  it('mints a distinct id each time', () => {
+    expect(generateTableId()).not.toBe(generateTableId())
+  })
+})

apps/sim/lib/table/ids.ts

@@ -0,0 +1,11 @@
+import { generateId } from '@sim/utils/id'
+
+/**
+ * Mints a fresh table id: `tbl_` plus a dash-stripped v4 UUID, the shape Tables have carried
+ * since they shipped and the one the CLI and Copilot describe to users. Every path that
+ * creates a table definition — the create service and the fork copy — mints through here, so
+ * a table's id never reveals which path made it.
+ */
+export function generateTableId(): string {
+  return `tbl_${generateId().replace(/-/g, '')}`
+}

apps/sim/lib/table/index.ts

@@ -12,6 +12,7 @@ export * from '@/lib/table/constants'
 export * from '@/lib/table/currency'
 export * from '@/lib/table/dates'
 export * from '@/lib/table/errors'
+export * from '@/lib/table/ids'
 export * from '@/lib/table/import'
 export * from '@/lib/table/import-data'
 export * from '@/lib/table/jobs/service'

apps/sim/lib/table/service.ts

@@ -43,6 +43,7 @@ import {
   TABLE_LIMITS,
 } from '@/lib/table/constants'
 import { appendTableEvent } from '@/lib/table/events'
+import { generateTableId } from '@/lib/table/ids'
 import {
   EMPTY_JOB_FIELDS,
   latestJobsForTables,
@@ -565,7 +566,7 @@ export async function createTable(
     await assertTableRowTtlEnabled()
   }
 
-  const tableId = `tbl_${generateId().replace(/-/g, '')}`
+  const tableId = generateTableId()
   const now = new Date()
 
   // Stamp stable ids so the table is id-keyed from its first row write.