fix(connectors): normalize provider throttles

Author: waleedlatif1

apps/sim/connectors/github/github.test.ts

@@ -88,6 +88,28 @@ describe('githubConnector.getDocument', () => {
     })
   })
 
+  it('rejects a bodyless blob response instead of misreporting it as oversized', async () => {
+    const fetchMock = vi
+      .fn()
+      .mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            sha: 'blob-sha',
+            size: 2 * 1024 * 1024,
+            content: '',
+            encoding: 'none',
+          }),
+          { status: 200 }
+        )
+      )
+      .mockResolvedValueOnce(new Response(null, { status: 200 }))
+    vi.stubGlobal('fetch', fetchMock)
+
+    await expect(
+      githubConnector.getDocument('token', { repository: 'owner/repo' }, 'missing-body.md')
+    ).rejects.toThrow('GitHub git blob blob-sha returned no body')
+  })
+
   it('surfaces a non-rate-limit 403 as a document failure', async () => {
     vi.stubGlobal('fetch', vi.fn().mockResolvedValue(new Response(null, { status: 403 })))
 

apps/sim/connectors/github/github.ts

@@ -168,6 +168,14 @@ async function fetchBlobContent(
     throw new Error(`Failed to fetch git blob ${sha}: ${response.status}`)
   }
 
+  if (!response.body) {
+    const contentLength = Number.parseInt(response.headers.get('content-length') ?? '', 10)
+    if (Number.isFinite(contentLength) && contentLength > MAX_FILE_SIZE) {
+      throw new ConnectorFileTooLargeError(MAX_FILE_SIZE)
+    }
+    throw new Error(`GitHub git blob ${sha} returned no body`)
+  }
+
   const buffer = await readBodyWithLimit(response, MAX_FILE_SIZE)
   if (!buffer) {
     throw new ConnectorFileTooLargeError(MAX_FILE_SIZE)

apps/sim/connectors/google-drive/google-drive-errors.ts

@@ -12,13 +12,12 @@ const PERMISSION_REASONS = new Set([
 const POLICY_REASONS = new Set(['domainPolicy', 'download_restricted_for_revision'])
 const UNSUPPORTED_EXPORT_REASONS = new Set(['fileNotDownloadable', 'fileNotExportable'])
 const QUOTA_REASONS = new Set(['dailyLimitExceeded', 'quotaExceeded'])
-const TRANSIENT_REASONS = new Set([
-  'backendError',
-  'internalError',
+const RATE_LIMIT_REASONS = new Set([
   'rateLimitExceeded',
   'sharingRateLimitExceeded',
   'userRateLimitExceeded',
 ])
+const TRANSIENT_REASONS = new Set(['backendError', 'internalError', ...RATE_LIMIT_REASONS])
 
 export type GoogleDriveErrorKind =
   | 'authorization'
@@ -99,6 +98,7 @@ function classifyGoogleDriveError(
 
 export class GoogleDriveApiError extends Error {
   retryAfterMs?: number
+  readonly rateLimited: boolean
 
   constructor(
     readonly status: number,
@@ -108,6 +108,7 @@ export class GoogleDriveApiError extends Error {
     const reasonSuffix = reasons.length > 0 ? ` (${reasons.join(', ')})` : ''
     super(`Google Drive API request failed with HTTP ${status}${reasonSuffix}`)
     this.name = 'GoogleDriveApiError'
+    this.rateLimited = status === 429 || reasons.some((reason) => RATE_LIMIT_REASONS.has(reason))
   }
 }
 

apps/sim/connectors/google-drive/google-drive.test.ts

@@ -94,6 +94,18 @@ describe('Google Drive API error parsing', () => {
     expect(error.message).not.toContain('upstream unavailable')
   })
 
+  it('normalizes only structured rate-limit reasons into the shared throttle signal', async () => {
+    const rateLimit = await readGoogleDriveApiError(
+      driveErrorResponse('userRateLimitExceeded', 'Provider message')
+    )
+    const backendFailure = await readGoogleDriveApiError(
+      driveErrorResponse('backendError', 'Provider message', 503)
+    )
+
+    expect(rateLimit.rateLimited).toBe(true)
+    expect(backendFailure.rateLimited).toBe(false)
+  })
+
   it('omits provider messages from diagnostics', async () => {
     const message = `Authorization: Bearer private-token\ncontext ${'x'.repeat(700)}`
     const error = await readGoogleDriveApiError(

apps/sim/lib/knowledge/documents/utils.test.ts

@@ -663,6 +663,17 @@ describe('isRateLimitError', () => {
     expect(isRateLimitError(new Error('hydration failed', { cause: providerError }))).toBe(true)
   })
 
+  it('accepts a provider-normalized throttle without HTTP rate-limit headers', () => {
+    expect(
+      isRateLimitError(
+        Object.assign(new Error('Google Drive API request failed with HTTP 403'), {
+          status: 403,
+          rateLimited: true,
+        })
+      )
+    ).toBe(true)
+  })
+
   it('does not classify retryable text or transient HTTP failures as provider throttling', () => {
     expect(isRateLimitError(new Error('rate limit exceeded'))).toBe(false)
     expect(isRateLimitError(Object.assign(new Error('unavailable'), { status: 503 }))).toBe(false)

apps/sim/lib/knowledge/documents/utils.ts

@@ -26,6 +26,8 @@ export interface HTTPError extends Error {
   status?: number
   statusText?: string
   retryAfterMs?: number
+  /** Provider-normalized signal for throttles that do not carry standard HTTP evidence. */
+  rateLimited?: boolean
   /**
    * Response headers carried onto the error so the retry loop can re-evaluate
    * rate-limit evidence (`isRetryableError` runs again on the thrown error).
@@ -239,6 +241,7 @@ export function isRateLimitError(error: unknown): boolean {
 
   while (isRetryableErrorType(current) && !seen.has(current) && seen.size < 10) {
     seen.add(current)
+    if ((current as HTTPError).rateLimited === true) return true
     if (
       hasStatus(current) &&
       (current.status === 429 ||