fix(search): keep results painted when Show more widens the page

Author: waleedlatif1

apps/sim/app/o/[organizationId]/search/search-results-view.test.tsx

@@ -145,7 +145,9 @@ describe('results-only search layout', () => {
     const filters = mocks.search.mock.calls.at(-1)![2]
     expect(filters.source).toBe('slack')
     expect(mocks.searchChange).toHaveBeenLastCalledWith({ scope, query: 'Orion', filters })
-    expect(mocks.search).toHaveBeenLastCalledWith(scope, 'Orion', filters, 20)
+    expect(mocks.search).toHaveBeenLastCalledWith(scope, 'Orion', filters, 20, {
+      retainAcrossLimits: true,
+    })
   })
   it('summarizes the selected document through Home without duplicating search state', async () => {
     await render('?q=Orion')

apps/sim/app/o/[organizationId]/search/search.test.tsx

@@ -163,7 +163,9 @@ async function editDraft(value: string) {
 function expectVisibleQuery(query: string) {
   expect(searchInput().value).toBe(query)
   expect(container.querySelector('a[data-source-link]')?.textContent).toBe(`${query} launch plan`)
-  expect(mocks.search).toHaveBeenLastCalledWith(scope, query, {}, 20)
+  expect(mocks.search).toHaveBeenLastCalledWith(scope, query, {}, 20, {
+    retainAcrossLimits: true,
+  })
   expect(document.activeElement).toBe(searchInput())
 }
 

apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.test.tsx

@@ -195,6 +195,7 @@ describe('result paging and the custom window', () => {
     await act(async () => more()!.click())
     /** The wider search is its own request; the first paint was never widened. */
     expect(mocks.search.mock.calls.at(-1)![3]).toBe(50)
+    expect(mocks.search.mock.calls.at(-1)![4]).toEqual({ retainAcrossLimits: true })
     expect(more()).toBeUndefined()
     mocks.search.mockReturnValue(page(7))
     await render()

apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.tsx

@@ -201,7 +201,8 @@ function SearchResults({
     topK ??
       (expanded
         ? WORKSPACE_KNOWLEDGE_SEARCH_LIMITS.expanded
-        : WORKSPACE_KNOWLEDGE_SEARCH_LIMITS.initial)
+        : WORKSPACE_KNOWLEDGE_SEARCH_LIMITS.initial),
+    { retainAcrossLimits: topK === undefined }
   )
   /** A full first page may collapse to few cards, yet more documents may still match. */
   const mayHaveMore =

apps/sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/search-transitions.test.tsx

@@ -174,29 +174,30 @@ async function click(label: string) {
 
 async function complete(
   index: number,
-  { title = 'Release plan', partial = false, empty = false } = {}
+  { title = 'Release plan', partial = false, empty = false, count = 1 } = {}
 ) {
   await act(async () => {
     requests[index].resolve({
       data: {
         query: requests[index].body.query,
         results: empty
           ? []
-          : [
-              {
-                documentId: title,
+          : Array.from({ length: count }, (_, n) => {
+              const name = n === 0 ? title : `${title} ${n + 1}`
+              return {
+                documentId: name,
                 knowledgeBaseId: 'index',
                 knowledgeBaseName: 'Search index',
-                documentName: title,
-                sourceUrl: 'https://example.com/release',
+                documentName: name,
+                sourceUrl: `https://example.com/release/${n}`,
                 connectorType: requests[index].body.filters?.source ?? 'slack',
                 sourceModifiedAt: null,
                 author: null,
                 content: 'launch details',
                 chunkIndex: 0,
                 similarity: 0.9,
-              },
-            ],
+              }
+            }),
         retrieval: {
           status: partial ? 'partial' : 'complete',
           timedOutLegs: partial ? ['vector'] : [],
@@ -285,6 +286,24 @@ describe('search refinement with the real query cache and URL state', () => {
     expect(container.textContent).not.toContain('Release plan')
   })
 
+  it('keeps the first page painted while Show more widens it, then while a filter narrows it', async () => {
+    await render()
+    await complete(0, { count: 20 })
+    await click('Show more')
+    expect(requests[1].body.topK).toBe(50)
+    expect(container.textContent).toContain('Updating results…')
+    expect(container.textContent).not.toContain('Searching…')
+    expect(container.querySelectorAll('a[data-source-link]')).toHaveLength(20)
+    await complete(1, { title: 'Wider plan', count: 50 })
+    expect(container.querySelectorAll('a[data-source-link]')).toHaveLength(50)
+    await click('Gmail')
+    expect(requests[2].body).toMatchObject({ filters: { source: 'gmail' }, topK: 20 })
+    expect(container.textContent).toContain('Updating results…')
+    expect(container.textContent).not.toContain('Searching…')
+    expect(container.querySelectorAll('a[data-source-link]')).toHaveLength(50)
+    expect(container.querySelector('a[data-source-link]')?.textContent).toBe('Wider plan')
+  })
+
   it('replaces filter URL state while preserving unrelated parameters', async () => {
     await render({ params: '?q=launch&panel=details' })
     await complete(0)

apps/sim/hooks/queries/kb/knowledge.test.ts

@@ -243,6 +243,24 @@ describe('knowledge query placeholder scope', () => {
     expect(placeholder('workspace-1', 'different', 5, 'reader')).toBeUndefined()
   })
 
+  it('retains a page-owned search across result limits only for the same reader', () => {
+    const query = captureQuery(() =>
+      useWorkspaceKnowledgeSearch('workspace-1', 'release', { source: 'slack' }, 50, {
+        retainAcrossLimits: true,
+      })
+    )
+    const previous = { results: [{ documentId: 'private-document' }] }
+    mocks.getQueryData.mockReturnValue(previous)
+    const placeholder = (topK: number, userId: string) =>
+      query.placeholderData?.(previous, {
+        queryKey: knowledgeKeys.search('workspace-1', 'release', {}, topK, userId),
+        state: { status: 'success', isInvalidated: false },
+      })
+    expect(placeholder(20, 'reader')).toBe(previous)
+    expect(placeholder(50, 'reader')).toBe(previous)
+    expect(placeholder(20, 'other')).toBeUndefined()
+  })
+
   it('partitions search cache entries by filter and reader', () => {
     const query = captureQuery(() =>
       useWorkspaceKnowledgeSearch('workspace-1', 'new query', { source: 'slack' })

apps/sim/hooks/queries/kb/knowledge.ts

@@ -1205,13 +1205,24 @@ async function searchWorkspaceKnowledge(
   return data.data
 }
 
+interface WorkspaceKnowledgeSearchOptions {
+  nativeQueries?: NativeSearchQuery[]
+  reuseFreshResult?: boolean
+  /**
+   * Keeps the previous result painted when only the result limit changes. Set it when the
+   * surface owns the limit (Show more widens the same search); leave it off when the limit is
+   * part of what was asked for, so a new limit is a new search that never shows the old one.
+   */
+  retainAcrossLimits?: boolean
+}
+
 /** Searches the canonical index under the signed-in person's ACLs. */
 export function useWorkspaceKnowledgeSearch(
   owner: string | ResourceScope | undefined,
   query: string,
   filters?: WorkspaceSearchFilters,
   topK = 20,
-  options?: { nativeQueries?: NativeSearchQuery[]; reuseFreshResult?: boolean }
+  options?: WorkspaceKnowledgeSearchOptions
 ) {
   const { features } = useDeploymentShape()
   const live = features.liveEnterpriseSearch === true
@@ -1258,17 +1269,15 @@ export function useWorkspaceKnowledgeSearch(
         : 0
       : WORKSPACE_KNOWLEDGE_SEARCH_STALE_TIME,
     retry: false,
-    placeholderData: (previous, previousQuery) =>
-      !live &&
-      userId &&
-      previousQuery?.state.status === 'success' &&
-      previousQuery.queryKey[6] === topK &&
-      !previousQuery.state.isInvalidated &&
-      knowledgeKeys
-        .searchQuery(scopeKey, trimmed, userId)
-        .every((part, index) => previousQuery.queryKey[index] === part) &&
-      queryClient.getQueryData(previousQuery.queryKey) === previous
-        ? previous
-        : undefined,
+    placeholderData: (previous, previousQuery) => {
+      if (live || !userId || previousQuery?.state.status !== 'success') return undefined
+      if (previousQuery.state.isInvalidated) return undefined
+      const prefix = knowledgeKeys.searchQuery(scopeKey, trimmed, userId)
+      if (!prefix.every((part, index) => previousQuery.queryKey[index] === part)) return undefined
+      /** `search()` appends filters, then the limit, after the reader/query prefix. */
+      const previousTopK = previousQuery.queryKey[prefix.length + 1]
+      if (!options?.retainAcrossLimits && previousTopK !== topK) return undefined
+      return queryClient.getQueryData(previousQuery.queryKey) === previous ? previous : undefined
+    },
   })
 }