fix(tables): follow the folder selector consolidation, and name the real delete guard

Rebasing onto staging after the File folder work landed (#7393). Two
adjustments to what that merge changed, and one correction.

`readFolderPath` moved from under the sub-block component tree to
`lib/folders/selection.ts`, and the `sim-folder-tree-selector` subblock
type was consolidated into the pre-existing `folder-selector`. Both are
better homes; this follows them.

The delete-cascade assertion named the wrong layer. It claimed "the
block's own schema is what an Agent tool surface is built from", which
contradicts what this same change established for the move destination:
`createLLMToolSchema` reads `toolConfig.params`, not the block's
subblocks. So the guard that actually keeps a model out of the recursive
delete is the TOOL param's `visibility: 'user-only'` — it drives both
the omission from the model's schema and `modelBlockedParams`, which
`stripModelBlockedParams` then removes from the model's arguments before
merge. The subblock's `paramVisibility` governs the tool-input row UI via
`isToolParamUserRequired`, which is a real thing but not a guard. Both
are still set; the test now asserts the tool param first and says which
one enforces.

Author: mzxchandra

apps/sim/blocks/blocks/table-folders.test.ts

@@ -11,6 +11,7 @@ import {
   tableUpdateFolderSchemas,
 } from '@/lib/api/contracts/tools/table'
 import { TableV2Block } from '@/blocks/blocks/table_v2'
+import { tableDeleteFolderTool } from '@/tools/table/folders'
 
 /*
  * The block's params transformer feeds the tool dispatch directly, so its output
@@ -237,7 +238,7 @@ describe('table_v2 folder subblocks are wired as canonical pairs', () => {
       'destinationParentPath',
       'moveTargetFolderPath',
     ]) {
-      expect(subBlock(id)?.type).toBe('sim-folder-tree-selector')
+      expect(subBlock(id)?.type).toBe('folder-selector')
       expect(subBlock(id)?.resourceType).toBe('table')
     }
   })
@@ -342,8 +343,18 @@ describe('table_v2 keeps the destination a model asked for', () => {
     expect(params.recursive).toBe(false)
   })
 
-  it('marks the delete cascade user-only on the subblock, not just the tool', () => {
-    /* The block's own schema is what an Agent tool surface is built from. */
+  it('keeps a model out of the delete cascade at the layer that enforces it', () => {
+    /*
+     * The enforcing layer is the TOOL param's `visibility: 'user-only'`, not the
+     * subblock: `createLLMToolSchema` reads `toolConfig.params` to build both the
+     * model's schema and `modelBlockedParams` (tools/params.ts), and
+     * `stripModelBlockedParams` drops those keys from the model's arguments
+     * before they merge (providers/utils.ts). The subblock's `paramVisibility`
+     * governs the tool-input ROW UI — whether a human must fill the field — via
+     * `isToolParamUserRequired`. Both are set here, but only the first is a
+     * guard, so this asserts the tool param and treats the subblock as UI.
+     */
+    expect(tableDeleteFolderTool.params.recursive.visibility).toBe('user-only')
     expect(subBlock('deleteFolderRecursive')?.paramVisibility).toBe('user-only')
   })
 })

apps/sim/blocks/blocks/table_v2.ts

@@ -1,6 +1,7 @@
 import { Table } from '@sim/emcn/icons'
 import { toError } from '@sim/utils/errors'
 import { encodeFolderPathSegment, ROOT_FOLDER_PATH } from '@/lib/folders/paths'
+import { readFolderPath } from '@/lib/folders/selection'
 import { TABLE_LIMITS } from '@/lib/table/constants'
 import { filterRulesToPredicate, sortRulesToSortSpec } from '@/lib/table/query-builder/converters'
 import { normalizeTablePredicate } from '@/lib/table/query-builder/predicate'
@@ -12,7 +13,6 @@ import type {
   TablePredicate,
   TablePredicateInput,
 } from '@/lib/table/types'
-import { readFolderPath } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/sim-folder-tree-selector/selection'
 import type { BlockConfig, SubBlockType } from '@/blocks/types'
 import { parseOptionalNumberInput } from '@/blocks/utils'
 import type { TableQueryV2Response } from '@/tools/table/types'
@@ -541,7 +541,7 @@ export const TableV2Block: BlockConfig<TableQueryV2Response> = {
     {
       id: 'folderSelection',
       title: 'Folder',
-      type: 'sim-folder-tree-selector' as SubBlockType,
+      type: 'folder-selector' as SubBlockType,
       resourceType: 'table',
       mode: 'basic',
       placeholder: 'Anywhere in the workspace',
@@ -574,7 +574,7 @@ export const TableV2Block: BlockConfig<TableQueryV2Response> = {
     {
       id: 'folderPath',
       title: 'Folder',
-      type: 'sim-folder-tree-selector' as SubBlockType,
+      type: 'folder-selector' as SubBlockType,
       resourceType: 'table',
       canonicalParamId: 'folderRef',
       mode: 'basic',
@@ -602,7 +602,7 @@ export const TableV2Block: BlockConfig<TableQueryV2Response> = {
     {
       id: 'createParentPath',
       title: 'Parent Folder',
-      type: 'sim-folder-tree-selector' as SubBlockType,
+      type: 'folder-selector' as SubBlockType,
       resourceType: 'table',
       canonicalParamId: 'createParentRef',
       mode: 'basic',
@@ -630,7 +630,7 @@ export const TableV2Block: BlockConfig<TableQueryV2Response> = {
     {
       id: 'destinationParentPath',
       title: 'Move Into',
-      type: 'sim-folder-tree-selector' as SubBlockType,
+      type: 'folder-selector' as SubBlockType,
       resourceType: 'table',
       canonicalParamId: 'destinationParentRef',
       mode: 'basic',
@@ -702,7 +702,7 @@ export const TableV2Block: BlockConfig<TableQueryV2Response> = {
     {
       id: 'moveTargetFolderPath',
       title: 'Move Into',
-      type: 'sim-folder-tree-selector' as SubBlockType,
+      type: 'folder-selector' as SubBlockType,
       resourceType: 'table',
       canonicalParamId: 'moveTargetRef',
       mode: 'basic',