fix(quickbooks): correct the sparse-void TSDoc and narrow receipt customerId types

The sparse guard's TSDoc claimed Intuit documents `sparse` as required to void
any object. That is false for Invoice, whose void request model is
`deleterequest` (Id + SyncToken, no sparse); only the `include=void` form
carries it. The code was already correct; the comment would have led an editor
to 'fix' void_invoice.ts into breaking it.

Also narrows QuickBooksCreateSalesReceiptParams.customerId to optional so the
type matches the required:false declaration, per salesreceiptrequest.Required
listing only Line.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RB5M2gk7zZgGomnQqr7WRB

Author: waleedlatif1

apps/sim/tools/quickbooks/sales_utils.ts

@@ -370,7 +370,7 @@ export function mergeQuickBooksPaymentLines(
  * do list `CustomerRef` and keep the reference required.
  */
 export function buildQuickBooksCreateSalesDocumentBody(
-  params: QuickBooksCreateSalesDocumentParams,
+  params: Omit<QuickBooksCreateSalesDocumentParams, 'customerId'> & { customerId?: string },
   options: { requireDepositAccount?: boolean; customerOptional?: boolean } = {}
 ): Record<string, unknown> {
   if (options.requireDepositAccount && !params.depositAccountId?.trim()) {
@@ -385,7 +385,7 @@ export function buildQuickBooksCreateSalesDocumentBody(
     CustomerRef:
       options.customerOptional && !params.customerId?.trim()
         ? undefined
-        : quickBooksReference(params.customerId, 'customerId'),
+        : quickBooksReference(params.customerId ?? '', 'customerId'),
     Line: buildQuickBooksSalesLines(params.lines),
     TxnDate: validateQuickBooksDate(params.transactionDate, 'transactionDate'),
     DocNumber: boundedString(

apps/sim/tools/quickbooks/types.ts

@@ -885,10 +885,14 @@ export type QuickBooksCreateEstimateParams = Omit<QuickBooksNonReceiptCreatePara
 export type QuickBooksUpdateEstimateParams = Omit<QuickBooksNonReceiptUpdateParams, 'dueDate'>
 export type QuickBooksCreateInvoiceParams = Omit<QuickBooksNonReceiptCreateParams, 'expirationDate'>
 export type QuickBooksUpdateInvoiceParams = Omit<QuickBooksNonReceiptUpdateParams, 'expirationDate'>
+/**
+ * Intuit's `salesreceiptrequest` requires only `Line`; `CustomerRef` is absent
+ * from its required set, so an anonymous counter sale is a valid sales receipt.
+ */
 export type QuickBooksCreateSalesReceiptParams = Omit<
   QuickBooksCreateSalesDocumentParams,
-  'dueDate' | 'expirationDate'
->
+  'dueDate' | 'expirationDate' | 'customerId'
+> & { customerId?: string }
 export type QuickBooksUpdateSalesReceiptParams = Omit<
   QuickBooksUpdateSalesDocumentParams,
   'dueDate' | 'expirationDate'

apps/sim/tools/quickbooks/values.ts

@@ -274,8 +274,11 @@ export function quickBooksActiveValue(
  * Enforces both halves of the contract:
  * 1. `sparse` is literally `true`. Intuit treats an update without it as a
  *    *full* replacement, silently clearing every field the body omits, and
- *    documents `sparse` as required to void an object. A builder that drops it
- *    would otherwise fail only against the live API.
+ *    documents `sparse` as required by the `include=void` form of the void
+ *    operation (Payment, SalesReceipt). Invoice voids through
+ *    `?operation=void`, whose documented request model is `deleterequest` —
+ *    `Id` and `SyncToken` only, no `sparse`. A builder that drops it would
+ *    otherwise fail only against the live API.
  * 2. The body carries at least one field beyond the required identifiers
  *    (`Id`, `SyncToken`, `sparse` by default), so an update that would change
  *    nothing never reaches the API.