From 0a91cfdebd8ab64486860fa34389536bab8cac4c Mon Sep 17 00:00:00 2001 From: Lucasmingus Date: Tue, 1 Sep 2026 13:34:45 +0200 Subject: [PATCH 1/2] flamestrike pclasm fix --- engine/class_modules/sc_mage.cpp | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/engine/class_modules/sc_mage.cpp b/engine/class_modules/sc_mage.cpp index ab4ab2a8b97..d8530c79014 100644 --- a/engine/class_modules/sc_mage.cpp +++ b/engine/class_modules/sc_mage.cpp @@ -2361,18 +2361,12 @@ struct hot_streak_spell_t : public custom_state_spell_tbuffs.hyperthermia->check_value(); - return c; - } - - result_e calculate_result( action_state_t* s ) const override - { - result_e r = custom_state_spell_t::calculate_result( s ); - - // TODO: Pyroclasm 2pc is likely scripted. Fuel the Fire does not see the increased crit chance. - if ( r == RESULT_HIT && pyroclasm_active() && p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) ) - r = RESULT_CRIT; + // The spelldata for Pyroclasm and the 12.1 2pc doesn't seem to be used (nor correct), + // so we're hardcoding it here as they probably did serverside. + if ( pyroclasm_active() && p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) ) + c += 1.0; - return r; + return c; } double composite_da_multiplier( const action_state_t* s ) const override From 5d82c567dcc438180e7fed30e8d93bf463ab0448 Mon Sep 17 00:00:00 2001 From: Lucasmingus Date: Tue, 1 Sep 2026 13:44:02 +0200 Subject: [PATCH 2/2] adjust comment --- engine/class_modules/sc_mage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/class_modules/sc_mage.cpp b/engine/class_modules/sc_mage.cpp index d8530c79014..558cbe366f7 100644 --- a/engine/class_modules/sc_mage.cpp +++ b/engine/class_modules/sc_mage.cpp @@ -2361,7 +2361,7 @@ struct hot_streak_spell_t : public custom_state_spell_tbuffs.hyperthermia->check_value(); - // The spelldata for Pyroclasm and the 12.1 2pc doesn't seem to be used (nor correct), + // The spelldata for Pyroclasm and the 12.1 2pc doesn't seem to be used, // so we're hardcoding it here as they probably did serverside. if ( pyroclasm_active() && p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) ) c += 1.0;