Skip to content

S3 connection credentials stored in localStorage #306

Description

@lfrancke

File: src/lib/storage/connection-storage.ts, src/lib/components/storage/StorageConnectForm.svelte

S3 connection credentials (access key ID and secret access key) are persisted in plaintext localStorage so the browser can auto-reconnect after a page reload or server restart. localStorage is accessible to any JavaScript running on the page and is visible in browser DevTools, making it vulnerable to XSS. Acceptable for the current early stage where the alternative is users having to re-enter credentials after every server restart. Long-term fix: persist encrypted credentials server-side, tied to the authenticated session; send only a session token to the client.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions