diff --git a/TECH_DEBT.md b/TECH_DEBT.md index 63591e87..b18ff77a 100644 --- a/TECH_DEBT.md +++ b/TECH_DEBT.md @@ -90,7 +90,7 @@ Completed query snapshots (including result rows) are cleaned up after `STACKABL ### Client-side row accumulation has no memory bound -**File:** `src/routes/(app)/trino/query-runner.svelte.ts` +**File:** `src/lib/trino/query-runner.svelte.ts` The client accumulates all result rows in memory up to `MAX_CLIENT_ROWS` (10,000). For wide result sets this could consume significant browser memory. Consider implementing streaming/virtual scrolling for large results. @@ -98,7 +98,7 @@ The client accumulates all result rows in memory up to `MAX_CLIENT_ROWS` (10,000 ### Displayed results not cleared on connection change -**File:** `src/routes/(app)/trino/+page.svelte` +**File:** `src/routes/(app)/trino/query-runner.svelte.ts`, `src/routes/(app)/trino/+page.svelte` After saving a new connection, the previous query results remain visible until a new query is run. Consider calling `runner.reset()` when the connection changes. @@ -122,6 +122,34 @@ Mobile viewport tests (393×851, touch-enabled) are excluded from CI runs to red ## Infrastructure +### Session cookie not configured for cross-origin iframe embedding + +**File:** `src/lib/server/auth.ts` + +The better-auth session cookie currently uses `SameSite=Lax` (the browser default when no `SameSite` attribute is set). Browsers do not send `SameSite=Lax` cookies when a page is loaded inside an ` + + + +
+ +
+ + + + + +