Skip to content

Commit 38873a3

Browse files
committed
chore: Add the missing final newlines and drop trailing whitespace
The pre-commit whitespace hooks only see the files a change touches, so the spelling fixes pulled these four into scope.
1 parent 72857d1 commit 38873a3

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

modules/contributor/pages/adr/ADR001-choose_project_language.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ Chosen option: "English", because the desire to create an active community with
5151
=== English
5252

5353
* Good, because it allows growing an international community
54-
* Bad, would initially add a small language barrier that is not strictly speaking necessary
54+
* Bad, would initially add a small language barrier that is not strictly speaking necessary

modules/contributor/pages/adr/ADR015-using_values_from_configmaps.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,4 @@ Accessing the content of these mounted objects would then need to be done in an
8686

8787
* Good, because mounting the ConfigMap/Secret directly into the pod allows the restart controller to automatically restart a Pod if a mounted object changes. Otherwise, changes would not be propagated or the Operator would have to watch the ConfigMap/Secret for changes itself. The watching/restarting is done once by Kubernetes + the restart controller and makes our Operators simpler
8888
* Bad, because the mounted properties cannot be validated by the Operator. Although Kubernetes at least verifies that all the properties that should be mounted exist
89-
* Bad, because it is more difficult to see which config is actually used to run the product, as the actual config is only finally assembled inside of the container
89+
* Bad, because it is more difficult to see which config is actually used to run the product, as the actual config is only finally assembled inside of the container

modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Technical Story: https://github.com/stackabletech/listener-operator/pull/1
1515
== Context and Problem Statement
1616
// Describe the context and problem statement, e.g., in free form using two to three sentences. You may want to articulate the problem in form of a question.
1717

18-
Eventually, the products we host in Kubernetes will need to be accessed from outside of the cluster, as this is where the client is. Our current solution for this is NodePort services. They are a simple and common solution for on-premise clusters, where nodes are reachable hosts in the local network. To get traffic into a Kubernetes cluster that runs in a public cloud, NodePorts do not work; instead LoadBalancers are the preferred solution.
18+
Eventually, the products we host in Kubernetes will need to be accessed from outside of the cluster, as this is where the client is. Our current solution for this is NodePort services. They are a simple and common solution for on-premise clusters, where nodes are reachable hosts in the local network. To get traffic into a Kubernetes cluster that runs in a public cloud, NodePorts do not work; instead LoadBalancers are the preferred solution.
1919

2020
While a Pods name is stable across restarts and rescheduling, the IP of the NodePort can change if a Pod is rescheduled to a different node. This means that external addresses from simple NodePorts are not stable. LoadBalancers are not tied to nodes, but they are often not available in on-prem clusters.
2121
At the moment we deploy NodePort Services per RoleGroup; clients cannot connect to an individual Pod in a RoleGroup.
@@ -188,4 +188,4 @@ With ARP, the LoadBalancers appear as "real" IP addresses in the same subnet as
188188

189189
=== Calico
190190

191-
link:https://www.tigera.io/project-calico/[Calico] requires BGP, another component that we cannot make required for customer setups.
191+
link:https://www.tigera.io/project-calico/[Calico] requires BGP, another component that we cannot make required for customer setups.

modules/contributor/pages/adr/drafts/ADRx-choose_authorization_engine.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,4 @@ It allows integration with LDAP and AD, offers authorization, a clustered mode f
100100
== Links
101101

102102
* [Link type] [Link to ADR] <!-- example: Refined by [ADR-0005](0005-example.md) -->
103-
* … <!-- numbers of links can vary -->
103+
* … <!-- numbers of links can vary -->

0 commit comments

Comments
 (0)