From 8b059739bfd652fd8152a303d6a81b49d03c9556 Mon Sep 17 00:00:00 2001 From: Stacky McStackface Date: Thu, 3 Sep 2026 07:58:11 +0000 Subject: [PATCH 1/2] chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@bcf54b79d402c34fb2648140300f8bf0113ebddb Reference-to: stackabletech/operator-templating@bcf54b7 (Namespace the Helm defined templates with the chart name) --- .../workflows/integration-test-profile.yaml | 2 +- .../helm/hdfs-operator/templates/_helpers.tpl | 28 +++++++++---------- .../hdfs-operator/templates/_maintenance.tpl | 2 +- .../hdfs-operator/templates/_telemetry.tpl | 4 +-- .../hdfs-operator/templates/deployment.yaml | 22 +++++++-------- .../helm/hdfs-operator/templates/service.yaml | 6 ++-- .../templates/serviceaccount.yaml | 12 ++++---- 7 files changed, 38 insertions(+), 38 deletions(-) diff --git a/.github/workflows/integration-test-profile.yaml b/.github/workflows/integration-test-profile.yaml index 41891685..a4c55ca9 100644 --- a/.github/workflows/integration-test-profile.yaml +++ b/.github/workflows/integration-test-profile.yaml @@ -32,7 +32,7 @@ jobs: PROFILE_INPUT: ${{ inputs.test-profile }} shell: bash run: | - if [ "$EVENT_NAME" == "schedule" ]; then + if [ "$GITHUB_EVENT_NAME" == "schedule" ]; then echo "PROFILE=schedule" | tee -a "$GITHUB_OUTPUT" else echo "PROFILE=${PROFILE_INPUT}" | tee -a "$GITHUB_OUTPUT" diff --git a/deploy/helm/hdfs-operator/templates/_helpers.tpl b/deploy/helm/hdfs-operator/templates/_helpers.tpl index e5354470..4425287e 100644 --- a/deploy/helm/hdfs-operator/templates/_helpers.tpl +++ b/deploy/helm/hdfs-operator/templates/_helpers.tpl @@ -1,14 +1,14 @@ {{/* Expand the name of the chart. */}} -{{- define "operator.name" -}} +{{- define "hdfs-operator.name" -}} {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-operator" }} {{- end }} {{/* Expand the name of the chart. */}} -{{- define "operator.appname" -}} +{{- define "hdfs-operator.appname" -}} {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} {{- end }} @@ -17,7 +17,7 @@ Create a default fully qualified app name. We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). If release name contains chart name it will be used as a full name. */}} -{{- define "operator.fullname" -}} +{{- define "hdfs-operator.fullname" -}} {{- if .Values.fullnameOverride }} {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} {{- else }} @@ -33,16 +33,16 @@ If release name contains chart name it will be used as a full name. {{/* Create chart name and version as used by the chart label. */}} -{{- define "operator.chart" -}} +{{- define "hdfs-operator.chart" -}} {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} {{- end }} {{/* Common labels */}} -{{- define "operator.labels" -}} -helm.sh/chart: {{ include "operator.chart" . }} -{{ include "operator.selectorLabels" . }} +{{- define "hdfs-operator.labels" -}} +helm.sh/chart: {{ include "hdfs-operator.chart" . }} +{{ include "hdfs-operator.selectorLabels" . }} {{- if .Chart.AppVersion }} app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} {{- end }} @@ -52,8 +52,8 @@ app.kubernetes.io/managed-by: {{ .Release.Service }} {{/* Selector labels */}} -{{- define "operator.selectorLabels" -}} -app.kubernetes.io/name: {{ include "operator.appname" . }} +{{- define "hdfs-operator.selectorLabels" -}} +app.kubernetes.io/name: {{ include "hdfs-operator.appname" . }} app.kubernetes.io/instance: {{ .Release.Name }} {{- with .Values.labels }} {{ toYaml . }} @@ -63,9 +63,9 @@ app.kubernetes.io/instance: {{ .Release.Name }} {{/* Create the name of the service account to use */}} -{{- define "operator.serviceAccountName" -}} +{{- define "hdfs-operator.serviceAccountName" -}} {{- if .Values.serviceAccount.create }} -{{- default (printf "%s-serviceaccount" (include "operator.fullname" .)) .Values.serviceAccount.name }} +{{- default (printf "%s-serviceaccount" (include "hdfs-operator.fullname" .)) .Values.serviceAccount.name }} {{- else }} {{- required "serviceAccount.name is required when serviceAccount.create is false, because the chart then does not create a ServiceAccount for the operator to run as." .Values.serviceAccount.name }} {{- end }} @@ -74,13 +74,13 @@ Create the name of the service account to use {{/* Labels for Kubernetes objects created by helm test */}} -{{- define "operator.testLabels" -}} -helm.sh/test: {{ include "operator.chart" . }} +{{- define "hdfs-operator.testLabels" -}} +helm.sh/test: {{ include "hdfs-operator.chart" . }} {{- end }} {{/* Build the full operator container image reference. */}} -{{- define "operator.image" -}} +{{- define "hdfs-operator.image" -}} {{- printf "%s/%s:%s" .Values.image.repository .Chart.Name (.Values.image.tag | default .Chart.AppVersion) -}} {{- end }} diff --git a/deploy/helm/hdfs-operator/templates/_maintenance.tpl b/deploy/helm/hdfs-operator/templates/_maintenance.tpl index 85afd7f2..a06493c9 100644 --- a/deploy/helm/hdfs-operator/templates/_maintenance.tpl +++ b/deploy/helm/hdfs-operator/templates/_maintenance.tpl @@ -1,7 +1,7 @@ {{/* Create a list of maintenance related env vars. */}} -{{- define "maintenance.envVars" -}} +{{- define "hdfs-operator.maintenance.envVars" -}} {{- with .Values.maintenance }} {{- if not .endOfSupportCheck.enabled }} - name: EOS_DISABLED diff --git a/deploy/helm/hdfs-operator/templates/_telemetry.tpl b/deploy/helm/hdfs-operator/templates/_telemetry.tpl index 8ef99bbf..d99ea716 100644 --- a/deploy/helm/hdfs-operator/templates/_telemetry.tpl +++ b/deploy/helm/hdfs-operator/templates/_telemetry.tpl @@ -1,7 +1,7 @@ {{/* Create a list of telemetry related env vars. */}} -{{- define "telemetry.envVars" -}} +{{- define "hdfs-operator.telemetry.envVars" -}} {{- with .Values.telemetry }} {{- if not .consoleLog.enabled }} - name: CONSOLE_LOG_DISABLED @@ -17,7 +17,7 @@ Create a list of telemetry related env vars. {{ end }} {{- if .fileLog.enabled }} - name: FILE_LOG_DIRECTORY - value: /stackable/logs/{{ include "operator.appname" $ }} + value: /stackable/logs/{{ include "hdfs-operator.appname" $ }} {{- end }} {{- if and .fileLog.enabled .fileLog.level }} - name: FILE_LOG_LEVEL diff --git a/deploy/helm/hdfs-operator/templates/deployment.yaml b/deploy/helm/hdfs-operator/templates/deployment.yaml index 86be9ad2..9de7c3e8 100644 --- a/deploy/helm/hdfs-operator/templates/deployment.yaml +++ b/deploy/helm/hdfs-operator/templates/deployment.yaml @@ -2,20 +2,20 @@ apiVersion: apps/v1 kind: Deployment metadata: - name: {{ include "operator.fullname" . }}-deployment + name: {{ include "hdfs-operator.fullname" . }}-deployment labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} spec: replicas: 1 strategy: type: Recreate selector: matchLabels: - {{- include "operator.selectorLabels" . | nindent 6 }} + {{- include "hdfs-operator.selectorLabels" . | nindent 6 }} template: metadata: annotations: - internal.stackable.tech/image: {{ include "operator.image" . }} + internal.stackable.tech/image: {{ include "hdfs-operator.image" . }} {{- with .Values.podAnnotations }} {{- toYaml . | nindent 8 }} {{- end }} @@ -23,20 +23,20 @@ spec: {{- if .Values.maintenance.customResourceDefinitions.maintain }} webhook.stackable.tech/conversion: enabled {{- end }} - {{- include "operator.selectorLabels" . | nindent 8 }} + {{- include "hdfs-operator.selectorLabels" . | nindent 8 }} spec: {{- with .Values.image.pullSecrets }} imagePullSecrets: {{- toYaml . | nindent 8 }} {{- end }} - serviceAccountName: {{ include "operator.serviceAccountName" . }} + serviceAccountName: {{ include "hdfs-operator.serviceAccountName" . }} securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }} containers: - - name: {{ include "operator.appname" . }} + - name: {{ include "hdfs-operator.appname" . }} securityContext: {{- toYaml .Values.securityContext | nindent 12 }} - image: {{ include "operator.image" . }} + image: {{ include "hdfs-operator.image" . }} imagePullPolicy: {{ .Values.image.pullPolicy }} resources: {{- toYaml .Values.resources | nindent 12 }} @@ -64,7 +64,7 @@ spec: # The name of the Kubernetes Service that point to the operator Pod, e.g. used to # construct the conversion webhook endpoint. - name: OPERATOR_SERVICE_NAME - value: {{ include "operator.fullname" . }} + value: {{ include "hdfs-operator.fullname" . }} # The product image repository, like "oci.stackable.tech/sdp". - name: IMAGE_REPOSITORY @@ -82,8 +82,8 @@ spec: value: {{ .Values.kubernetesClusterDomain | quote }} {{- end }} - {{- include "telemetry.envVars" . | nindent 12 }} - {{- include "maintenance.envVars" . | nindent 12 }} + {{- include "hdfs-operator.telemetry.envVars" . | nindent 12 }} + {{- include "hdfs-operator.maintenance.envVars" . | nindent 12 }} {{- with .Values.nodeSelector }} nodeSelector: {{- toYaml . | nindent 8 }} diff --git a/deploy/helm/hdfs-operator/templates/service.yaml b/deploy/helm/hdfs-operator/templates/service.yaml index 978f914d..c8b8adeb 100644 --- a/deploy/helm/hdfs-operator/templates/service.yaml +++ b/deploy/helm/hdfs-operator/templates/service.yaml @@ -6,15 +6,15 @@ metadata: # Note(@sbernauer): We could also call the Service something like # "product-operator-conversion-webhook". However, in the future we will have more webhooks, and # it seems like an overkill to have a dedicated Service per webhook. - name: {{ include "operator.fullname" . }} + name: {{ include "hdfs-operator.fullname" . }} labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} spec: selector: {{- if .Values.maintenance.customResourceDefinitions.maintain }} webhook.stackable.tech/conversion: enabled {{- end }} - {{- include "operator.selectorLabels" . | nindent 4 }} + {{- include "hdfs-operator.selectorLabels" . | nindent 4 }} ports: - name: conversion-webhook protocol: TCP diff --git a/deploy/helm/hdfs-operator/templates/serviceaccount.yaml b/deploy/helm/hdfs-operator/templates/serviceaccount.yaml index e0d959e2..4225a4d0 100644 --- a/deploy/helm/hdfs-operator/templates/serviceaccount.yaml +++ b/deploy/helm/hdfs-operator/templates/serviceaccount.yaml @@ -3,9 +3,9 @@ apiVersion: v1 kind: ServiceAccount metadata: - name: {{ include "operator.serviceAccountName" . }} + name: {{ include "hdfs-operator.serviceAccountName" . }} labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} {{- with .Values.serviceAccount.annotations }} annotations: {{- toYaml . | nindent 4 }} @@ -17,14 +17,14 @@ apiVersion: rbac.authorization.k8s.io/v1 # operator watch and manage its custom resources across the cluster. kind: ClusterRoleBinding metadata: - name: {{ include "operator.fullname" . }}-clusterrolebinding + name: {{ include "hdfs-operator.fullname" . }}-clusterrolebinding labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} subjects: - kind: ServiceAccount - name: {{ include "operator.serviceAccountName" . }} + name: {{ include "hdfs-operator.serviceAccountName" . }} namespace: {{ .Release.Namespace }} roleRef: kind: ClusterRole - name: {{ include "operator.fullname" . }}-clusterrole + name: {{ include "hdfs-operator.fullname" . }}-clusterrole apiGroup: rbac.authorization.k8s.io From a7c029fe92f6c2178d888d74cada68c816663b6f Mon Sep 17 00:00:00 2001 From: Lars Francke Date: Thu, 3 Sep 2026 10:19:37 +0200 Subject: [PATCH 2/2] chore: Namespace the calls to the Helm defined templates The definitions moved to the chart-name prefix with the templated helper files, but these files are not templated, so their call sites did not move with them and the chart no longer renders. https://github.com/stackabletech/issues/issues/882 --- .../templates/clusterrole-operator.yaml | 18 +++++++++--------- .../templates/clusterrole-product.yaml | 8 ++++---- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/deploy/helm/hdfs-operator/templates/clusterrole-operator.yaml b/deploy/helm/hdfs-operator/templates/clusterrole-operator.yaml index 320b5993..2a3c4613 100644 --- a/deploy/helm/hdfs-operator/templates/clusterrole-operator.yaml +++ b/deploy/helm/hdfs-operator/templates/clusterrole-operator.yaml @@ -2,9 +2,9 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: - name: {{ include "operator.fullname" . }}-clusterrole + name: {{ include "hdfs-operator.fullname" . }}-clusterrole labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} rules: # For automatic cluster domain detection (reads kubelet config via the nodes/proxy API). - apiGroups: @@ -104,18 +104,18 @@ rules: - watch # Watch HdfsClusters for reconciliation - apiGroups: - - {{ include "operator.name" . }}.stackable.tech + - {{ include "hdfs-operator.name" . }}.stackable.tech resources: - - {{ include "operator.name" . }}clusters + - {{ include "hdfs-operator.name" . }}clusters verbs: - get - list - watch # Status subresource: updated at the end of every reconciliation. - apiGroups: - - {{ include "operator.name" . }}.stackable.tech + - {{ include "hdfs-operator.name" . }}.stackable.tech resources: - - {{ include "operator.name" . }}clusters/status + - {{ include "hdfs-operator.name" . }}clusters/status verbs: - patch # Manage the hdfs-clusterrolebinding-nodes ClusterRoleBinding via Server-Side Apply. @@ -126,7 +126,7 @@ rules: resources: - clusterrolebindings resourceNames: - - {{ include "operator.name" . }}-clusterrolebinding-nodes + - {{ include "hdfs-operator.name" . }}-clusterrolebinding-nodes verbs: - create - patch @@ -144,5 +144,5 @@ rules: verbs: - bind resourceNames: - - {{ include "operator.name" . }}-clusterrole - - {{ include "operator.name" . }}-clusterrole-nodes + - {{ include "hdfs-operator.name" . }}-clusterrole + - {{ include "hdfs-operator.name" . }}-clusterrole-nodes diff --git a/deploy/helm/hdfs-operator/templates/clusterrole-product.yaml b/deploy/helm/hdfs-operator/templates/clusterrole-product.yaml index dad2330f..e548541d 100644 --- a/deploy/helm/hdfs-operator/templates/clusterrole-product.yaml +++ b/deploy/helm/hdfs-operator/templates/clusterrole-product.yaml @@ -4,9 +4,9 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: - name: {{ include "operator.name" . }}-clusterrole + name: {{ include "hdfs-operator.name" . }}-clusterrole labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} rules: # List and get pods for peer discovery (e.g. format-namenodes discovering namenode peers). # These must live here in the product ClusterRole (not just in the nodes ClusterRole) because @@ -38,9 +38,9 @@ rules: apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: - name: {{ include "operator.name" . }}-clusterrole-nodes + name: {{ include "hdfs-operator.name" . }}-clusterrole-nodes labels: - {{- include "operator.labels" . | nindent 4 }} + {{- include "hdfs-operator.labels" . | nindent 4 }} rules: # The topology provider (rack awareness) running inside HDFS pods queries pod, node, and # endpoint information to compute rack labels for DataNodes.