From b5ca22ff6fc72a89276ffe89527ec8ceecfc1f98 Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sat, 16 May 2026 23:19:57 -0700 Subject: [PATCH 1/3] fix: use correct variable for package README markdown lint flags --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- tools/make/lib/lint/markdown/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/make/lib/lint/markdown/Makefile b/tools/make/lib/lint/markdown/Makefile index b49726325207..d3e0ffb8d410 100644 --- a/tools/make/lib/lint/markdown/Makefile +++ b/tools/make/lib/lint/markdown/Makefile @@ -101,13 +101,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) $(FIND_MARKDOWN_PKG_READMES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || exit 1; \ done else $(QUIET) $(FIND_MARKDOWN_PKG_READMES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || echo 'Linting failed.'; \ done endif @@ -131,13 +131,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || exit 1; \ done else $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || echo 'Linting failed.'; \ done endif From 41845426ffae4f100570e92fbb6c59f32123711c Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sat, 16 May 2026 23:54:56 -0700 Subject: [PATCH 2/3] fix: correct markdown lint flag variable name --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- tools/make/lib/lint/markdown/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/make/lib/lint/markdown/Makefile b/tools/make/lib/lint/markdown/Makefile index d3e0ffb8d410..d0c884e4e34c 100644 --- a/tools/make/lib/lint/markdown/Makefile +++ b/tools/make/lib/lint/markdown/Makefile @@ -160,13 +160,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) $(FIND_MARKDOWN_DOCS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || exit 1; \ done else $(QUIET) $(FIND_MARKDOWN_DOCS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || echo 'Linting failed.'; \ done endif @@ -190,13 +190,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || exit 1; \ done else $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || echo 'Linting failed.'; \ done endif From 50c5c6b9ac8735ed2c5e6d9dd6b730f5d22ed4cc Mon Sep 17 00:00:00 2001 From: Karan Anand Date: Sat, 16 May 2026 23:57:18 -0700 Subject: [PATCH 3/3] chore: apply suggestions from review --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- tools/make/lib/lint/markdown/Makefile | 16 ++++++++-------- tools/make/lib/lint/markdown/remark.mk | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/make/lib/lint/markdown/Makefile b/tools/make/lib/lint/markdown/Makefile index d0c884e4e34c..b49726325207 100644 --- a/tools/make/lib/lint/markdown/Makefile +++ b/tools/make/lib/lint/markdown/Makefile @@ -101,13 +101,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) $(FIND_MARKDOWN_PKG_READMES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || exit 1; \ done else $(QUIET) $(FIND_MARKDOWN_PKG_READMES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || echo 'Linting failed.'; \ done endif @@ -131,13 +131,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || exit 1; \ done else $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_PKG_READMES) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_PKG_READMES_FLAGS) $$file || echo 'Linting failed.'; \ done endif @@ -160,13 +160,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) $(FIND_MARKDOWN_DOCS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || exit 1; \ done else $(QUIET) $(FIND_MARKDOWN_DOCS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || echo 'Linting failed.'; \ done endif @@ -190,13 +190,13 @@ ifeq ($(FAIL_FAST), true) $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || exit 1; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || exit 1; \ done else $(QUIET) for file in $(FILES); do \ echo ''; \ echo "Linting file: $$file"; \ - NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_FLAGS_DOCS) $$file || echo 'Linting failed.'; \ + NODE_PATH="$(NODE_PATH)" $(MARKDOWN_LINT) $(MARKDOWN_LINT_DOCS_FLAGS) $$file || echo 'Linting failed.'; \ done endif diff --git a/tools/make/lib/lint/markdown/remark.mk b/tools/make/lib/lint/markdown/remark.mk index 1435acc77bbc..d9f7b5ce434c 100644 --- a/tools/make/lib/lint/markdown/remark.mk +++ b/tools/make/lib/lint/markdown/remark.mk @@ -45,7 +45,7 @@ MARKDOWN_LINT_FLAGS ?= \ --quiet # Define the command-line options when invoking the remark executable for linting package READMEs: -MARKDOWN_LINT_FLAGS_PKG_READMES ?= \ +MARKDOWN_LINT_PKG_READMES_FLAGS ?= \ --ext $(MARKDOWN_FILENAME_EXT) \ --rc-path $(REMARK_CONF_PKG_READMES) \ --ignore-path $(REMARK_IGNORE) \ @@ -55,7 +55,7 @@ MARKDOWN_LINT_FLAGS_PKG_READMES ?= \ --quiet # Define the command-line options when invoking the remark executable for linting documentation files: -MARKDOWN_LINT_FLAGS_DOCS ?= \ +MARKDOWN_LINT_DOCS_FLAGS ?= \ --ext $(MARKDOWN_FILENAME_EXT) \ --rc-path $(REMARK_CONF_DOCS) \ --ignore-path $(REMARK_IGNORE) \