From 1bf4c7ba0f1f64704d8fb705fbdeb5de1112742f Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Mon, 31 Aug 2026 02:22:14 +0000 Subject: [PATCH] test: migrate `stats/base/dists/beta/variance` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/beta/variance/test/test.js | 13 ++----------- .../base/dists/beta/variance/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.js index bff9b40cbb40..5f8267d63f5d 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var variance = require( './../lib' ); @@ -96,10 +95,8 @@ tape( 'if provided `beta <= 0`, the function returns `NaN`', function test( t ) tape( 'the function returns the variance of a beta distribution', function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -108,13 +105,7 @@ tape( 'the function returns the variance of a beta distribution', function test( beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = variance( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.native.js index 9dc3a89e3529..12da2d736bfe 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/beta/variance/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -105,10 +104,8 @@ tape( 'if provided `beta <= 0`, the function returns `NaN`', opts, function test tape( 'the function returns the variance of a beta distribution', opts, function test( t ) { var expected; - var delta; var alpha; var beta; - var tol; var i; var y; @@ -117,13 +114,7 @@ tape( 'the function returns the variance of a beta distribution', opts, function beta = data.beta; for ( i = 0; i < expected.length; i++ ) { y = variance( alpha[i], beta[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } t.end(); });