From 64cc1fb1c7a4e687a6d5c98635ee7a708774a31f Mon Sep 17 00:00:00 2001 From: kaustubh Date: Mon, 31 Aug 2026 11:18:49 +0530 Subject: [PATCH] refactor: add support for enums in blas/ext/base/*triu --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/blas/ext/base/ctriu/lib/ctriu.js | 11 +++++++---- .../@stdlib/blas/ext/base/ctriu/lib/ctriu.native.js | 11 +++++++---- .../@stdlib/blas/ext/base/dtriu/lib/dtriu.js | 11 +++++++---- .../@stdlib/blas/ext/base/dtriu/lib/dtriu.native.js | 11 +++++++---- .../@stdlib/blas/ext/base/gtriu/lib/main.js | 11 +++++++---- .../@stdlib/blas/ext/base/striu/lib/striu.js | 11 +++++++---- .../@stdlib/blas/ext/base/striu/lib/striu.native.js | 11 +++++++---- .../@stdlib/blas/ext/base/ztriu/lib/ztriu.js | 11 +++++++---- .../@stdlib/blas/ext/base/ztriu/lib/ztriu.native.js | 11 +++++++---- 9 files changed, 63 insertions(+), 36 deletions(-) diff --git a/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.js b/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.js index 0cfa8bdcaf96..d2ae61d4080c 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var max = require( '@stdlib/math/base/special/fast/max' ); var format = require( '@stdlib/string/format' ); @@ -32,7 +32,7 @@ var base = require( './base.js' ); /** * Copies the upper triangular part of a single-precision complex floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -70,10 +70,13 @@ function ctriu( order, M, N, k, A, LDA, B, LDB ) { var sb1; var sb2; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - isrm = isRowMajor( order ); + isrm = isRowMajor( l ); if ( isrm ) { s = N; } else { diff --git a/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.native.js b/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.native.js index d4974aed6e34..d1e6c314e5ad 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ctriu/lib/ctriu.native.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var resolveOrder = require( '@stdlib/blas/base/layout-resolve-enum' ); var max = require( '@stdlib/math/base/special/fast/max' ); @@ -34,7 +34,7 @@ var addon = require( './../src/addon.node' ); /** * Copies the upper triangular part of a single-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -60,10 +60,13 @@ function ctriu( order, M, N, k, A, LDA, B, LDB ) { var viewA; var viewB; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - if ( isRowMajor( order ) ) { + if ( isRowMajor( l ) ) { s = N; } else { s = M; diff --git a/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.js b/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.js index eca0ae632ab5..ececcac12bdd 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var max = require( '@stdlib/math/base/special/fast/max' ); var format = require( '@stdlib/string/format' ); @@ -32,7 +32,7 @@ var base = require( './base.js' ); /** * Copies the upper triangular part of a double-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -70,10 +70,13 @@ function dtriu( order, M, N, k, A, LDA, B, LDB ) { var sb1; var sb2; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - isrm = isRowMajor( order ); + isrm = isRowMajor( l ); if ( isrm ) { s = N; } else { diff --git a/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.native.js b/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.native.js index 3e0262430d5e..9ac946fd1d8b 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/dtriu/lib/dtriu.native.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var resolveOrder = require( '@stdlib/blas/base/layout-resolve-enum' ); var max = require( '@stdlib/math/base/special/fast/max' ); @@ -33,7 +33,7 @@ var addon = require( './../src/addon.node' ); /** * Copies the upper triangular part of a double-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -57,10 +57,13 @@ var addon = require( './../src/addon.node' ); */ function dtriu( order, M, N, k, A, LDA, B, LDB ) { var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - if ( isRowMajor( order ) ) { + if ( isRowMajor( l ) ) { s = N; } else { s = M; diff --git a/lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js b/lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js index 7f2bfa21156d..5415f41a4cc0 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js +++ b/lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var max = require( '@stdlib/math/base/special/fast/max' ); var format = require( '@stdlib/string/format' ); @@ -32,7 +32,7 @@ var base = require( './base.js' ); /** * Copies the upper triangular part of a matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -66,10 +66,13 @@ function gtriu( order, M, N, k, A, LDA, B, LDB ) { var sb1; var sb2; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - isrm = isRowMajor( order ); + isrm = isRowMajor( l ); if ( isrm ) { s = N; } else { diff --git a/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.js b/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.js index 017d520117e9..5f4fe7e01f16 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.js +++ b/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var max = require( '@stdlib/math/base/special/fast/max' ); var format = require( '@stdlib/string/format' ); @@ -32,7 +32,7 @@ var base = require( './base.js' ); /** * Copies the upper triangular part of a single-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -70,10 +70,13 @@ function striu( order, M, N, k, A, LDA, B, LDB ) { var sb1; var sb2; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - isrm = isRowMajor( order ); + isrm = isRowMajor( l ); if ( isrm ) { s = N; } else { diff --git a/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.native.js b/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.native.js index 68cfb57b6383..e549ad47d9a2 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/striu/lib/striu.native.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var resolveOrder = require( '@stdlib/blas/base/layout-resolve-enum' ); var max = require( '@stdlib/math/base/special/fast/max' ); @@ -33,7 +33,7 @@ var addon = require( './../src/addon.node' ); /** * Copies the upper triangular part of a single-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -57,10 +57,13 @@ var addon = require( './../src/addon.node' ); */ function striu( order, M, N, k, A, LDA, B, LDB ) { var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - if ( isRowMajor( order ) ) { + if ( isRowMajor( l ) ) { s = N; } else { s = M; diff --git a/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.js b/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.js index c000e8a47a14..991951bbab42 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var max = require( '@stdlib/math/base/special/fast/max' ); var format = require( '@stdlib/string/format' ); @@ -32,7 +32,7 @@ var base = require( './base.js' ); /** * Copies the upper triangular part of a double-precision complex floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -70,10 +70,13 @@ function ztriu( order, M, N, k, A, LDA, B, LDB ) { var sb1; var sb2; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - isrm = isRowMajor( order ); + isrm = isRowMajor( l ); if ( isrm ) { s = N; } else { diff --git a/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.native.js b/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.native.js index e584945fd8ad..338ae2c41fbb 100644 --- a/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.native.js +++ b/lib/node_modules/@stdlib/blas/ext/base/ztriu/lib/ztriu.native.js @@ -20,7 +20,7 @@ // MODULES // -var isLayout = require( '@stdlib/blas/base/assert/is-layout' ); +var resolveLayout = require( '@stdlib/blas/base/layout-resolve-str' ); var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major-string' ); var resolveOrder = require( '@stdlib/blas/base/layout-resolve-enum' ); var max = require( '@stdlib/math/base/special/fast/max' ); @@ -34,7 +34,7 @@ var addon = require( './../src/addon.node' ); /** * Copies the upper triangular part of a double-precision floating-point matrix `A` to another matrix `B`. * -* @param {string} order - storage layout of `A` and `B` +* @param {(integer|string)} order - storage layout of `A` and `B` * @param {NonNegativeInteger} M - number of rows in matrix `A` * @param {NonNegativeInteger} N - number of columns in matrix `A` * @param {integer} k - diagonal below which to ignore @@ -60,10 +60,13 @@ function ztriu( order, M, N, k, A, LDA, B, LDB ) { var viewA; var viewB; var s; - if ( !isLayout( order ) ) { + var l; + + l = resolveLayout( order ); + if ( l === null ) { throw new TypeError( format( 'invalid argument. First argument must be a valid order. Value: `%s`.', order ) ); } - if ( isRowMajor( order ) ) { + if ( isRowMajor( l ) ) { s = N; } else { s = M;