From e4dde28d429501c271652c008dc167090d4185f4 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 31 Aug 2026 06:39:16 +0000 Subject: [PATCH] test: migrate `stats/base/dists/chi/logpdf` to ULP-based assertions Replace relative tolerance comparisons with `isAlmostSameValue` ULP difference assertions in the `stats/base/dists/chi/logpdf` tests. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Claude-Session: https://claude.ai/code/session_01UYyqUPEukY4soPWzpgy8RV --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../base/dists/chi/logpdf/test/test.factory.js | 12 ++---------- .../stats/base/dists/chi/logpdf/test/test.logpdf.js | 12 ++---------- .../stats/base/dists/chi/logpdf/test/test.native.js | 13 ++----------- 3 files changed, 6 insertions(+), 31 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.factory.js index c6e3b1af97d1..9f299fb0741c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.factory.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var randu = require( '@stdlib/random/base/randu' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); @@ -146,8 +146,6 @@ tape( 'the returned function returns `-Infinity` for all `x < 0`', function test tape( 'the created function evaluates the logpdf for `x` given degrees of freedom `k`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var k; var x; var y; @@ -159,13 +157,7 @@ tape( 'the created function evaluates the logpdf for `x` given degrees of freedo for ( i = 0; i < x.length; i++ ) { logpdf = factory( k[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.logpdf.js b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.logpdf.js index 66cee1a80b35..b4b156a2cfb5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.logpdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.logpdf.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var randu = require( '@stdlib/random/base/randu' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); @@ -117,8 +117,6 @@ tape( 'the function returns `-Infinity` for all `x < 0`', function test( t ) { tape( 'the function evaluates the logpdf for `x` given degrees of freedom `k`', function test( t ) { var expected; - var delta; - var tol; var x; var k; var y; @@ -129,13 +127,7 @@ tape( 'the function evaluates the logpdf for `x` given degrees of freedom `k`', k = decimalDecimal.k; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], k[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+'. k:'+k[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. k: '+k[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.native.js index 1509d195ce0c..b71677970303 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/chi/logpdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -97,8 +96,6 @@ tape( 'if provided `-infinity` for `x` and a valid `k`, the function returns `-i tape( 'the function evaluates the logpdf for given `x` and `k`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var k; var y; @@ -109,13 +106,7 @@ tape( 'the function evaluates the logpdf for given `x` and `k`', opts, function k = data.k; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[ i ], k[ i ] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: ' + x[ i ] + ', k: ' + k[ i ] + ', y: ' + y + ', expected: ' + expected[ i ] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); // Higher tolerance needed due to accumulated floating-point precision differences between JS and C implementations - t.ok( delta <= tol, 'within tolerance. x: ' + x[ i ] + '. k: ' + k[ i ] + '. y: ' + y + '. E: ' + expected[ i ] + '. Δ: ' + delta + '. tol: ' + tol + '.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); });