Skip to content

feat(api): Add .wit interface#203

Draft
ospencer wants to merge 2 commits into
mainfrom
oscar/wit
Draft

feat(api): Add .wit interface#203
ospencer wants to merge 2 commits into
mainfrom
oscar/wit

Conversation

@ospencer

@ospencer ospencer commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

Draft because Reactr does not conform to canonical ABI, so this wit file cannot be used to generate bindings that will "just work."

@ospencer ospencer requested a review from a team February 1, 2022 18:18
@ospencer ospencer self-assigned this Feb 1, 2022
@ospencer ospencer marked this pull request as draft February 1, 2022 18:22
Comment thread api/env.wit Outdated

@flaki flaki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flaki

flaki commented Aug 1, 2022

Copy link
Copy Markdown

Do we also plan to have the generation upstreamed here or in the new repo @ospencer ? Can't do much more, without that but the wit looks alright to me.

@ospencer

ospencer commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

What do you mean?

@flaki

flaki commented Aug 1, 2022

Copy link
Copy Markdown

Correct me if I'm wrong but my understanding was that these wit interfaces are the source that auto-generate the glue code of e.g. #272 through wit-bindgen?

If that's correct, I don't think the process of this generation is shared anywhere?

@ospencer

ospencer commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

Yes, that's true. I see what you mean. I'm sort of against having an automated process/script to do it since it's unstable and only works for JS because of a hack (and this wit file isn't checked in).

For reference though, the command to generate the JS files is wit-bindgen js --import env.wit.

@ospencer

ospencer commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

Once we do the breaking changes to make bindgen work, we'll definitely have it automated for as many languages as possible.

@flaki

flaki commented Aug 1, 2022

Copy link
Copy Markdown

Sounds good, thanks for elaborating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants