`C-y` does not paste

[YueRen]

When using M-x visual-replace, pressing C-y does not paste what was previously copied (or cut). Instead, it seems to paste whatever the current point rests on. I was told that this is how M-x isearch used to behave. However, considering that

1. this behavior was changed over a decade ago (see line 2755 in Emacs News)

2. M-x replace-string and M-x query-replace-string never used to behave like that

would it be possible to make C-y behave "as expected"?

edit: if anybody else encounters this issue, you can "fix" it by for example putting the following underneath :config in your `(use-package visual-replace ...)

(define-key visual-replace-mode-map [remap yank] nil)
(define-key visual-replace-mode-map [remap yank-pop] nil)

[szermatt]

I have to admit that this and other "clever" keyboard tricks visual-replace are more trouble than they're worth. For my defence, visual-replace was initially meant to just be part of my config.

The change to C-y should definitely be made opt-in. The only thing holding me back is that such changes tend to confuse and annoy existing users, so should be done carefully, at the right time (a new major version) and with some easy way of turning it back on. This needs some more toughts.

[YueRen]

There is absolutely nothing wrong about having your package work the way you want.

How about the following compromise:

1. make is easy to opt-out (e.g., through some customizable variable)
2. include the opt-out in the default installation instructions

That way the behaviour won't change for existing users, the behaviour won't confuse new users, and users who deviate from the installation instructions should somewhat know what they are doing.