Rename package: DBN → DatabentoBinaryEncoding#19
Conversation
Julia Triage rejected the General Registry submission of "DBN" against
three naming guidelines (all-caps, <5 chars, Damerau-Levenshtein distance
≤2 from DSP/BDF/JDBC/etc.). Rename to clear all three:
- GitHub repo: DBN.jl → DatabentoBinaryEncoding.jl (already done)
- src/DBN.jl → src/DatabentoBinaryEncoding.jl (file rename)
- `module DBN` → `module DatabentoBinaryEncoding`
- Project.toml: name = "DBN" → "DatabentoBinaryEncoding"
(UUID unchanged, so downstream `[deps]` entries don't need re-mapping)
- docs/make.jl: sitename, canonical URL, modules, repo all updated
- README + docs/src/*.md prose: package-name references updated
- benchmark/*: prose + the env-check error message updated
Test/benchmark .jl files all use the alias pattern:
using DatabentoBinaryEncoding
import DatabentoBinaryEncoding as DBN
This keeps all ~300 existing `DBN.foo` references unchanged — idiomatic
Julia for verbose package names (cf. `LinearAlgebra as LA`).
Local Julia 1.13 beta has a borked LibCURL that prevents Pkg.test(), but
direct `julia --project=. test/runtests.jl` shows 3502 pass / 1 error
(unchanged from pre-rename; the one error is the pre-existing
BenchmarkTools-not-in-[deps] issue that only surfaces when bypassing
Pkg.test()). CI uses Pkg.test() and should be all green.
After this merges, retrigger registration via @JuliaRegistrator register
and comment on JuliaRegistries/General#155767 with the link to the new
registry PR.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
CI's docs/deploy build failed with "Refusing to add package DatabentoBinaryEncoding [...]. Package DBN=... with the same UUID already exists as a direct dependency." — caught by the rename PR because docs/Project.toml still declared the dep under the old name while the renamed package now reports as DatabentoBinaryeEncoding. UUID unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff6cea3e2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,14 +1,14 @@ | |||
| using Documenter | |||
| using DBN | |||
| using DatabentoBinaryEncoding | |||
There was a problem hiding this comment.
This import was renamed, but docs/Project.toml still declares the package as DBN = "90689371-c8cb-40d1-831f-18033db90f74". When the docs are built with the committed docs environment (the workflow uses julia --project=docs docs/make.jl), the active project does not have a DatabentoBinaryEncoding root dependency unless a prior command mutates docs/Project.toml, so local/CI docs builds can fail with the package not found. Please rename the docs dependency entry to DatabentoBinaryEncoding as part of this package rename.
Useful? React with 👍 / 👎.
2 participants
Summary
Julia Triage rejected the General Registry submission of
DBNagainst three naming guidelines (all-caps, <5 chars, Damerau-Levenshtein distance ≤ 2 from DSP / BDF / JDBC / RBNF / DINA / MDBM). Rename to clear all three.Repo + folder were already renamed. This PR completes the inside-the-package work:
src/DBN.jl→src/DatabentoBinaryEncoding.jlmodule DBN→module DatabentoBinaryEncodingProject.toml:name = "DBN"→"DatabentoBinaryEncoding"(UUID unchanged)docs/make.jl: sitename, canonical URL, modules, repo all updateddocs/src/*.mdprose updatedbenchmark/*: prose + env-check error message updatedTest/benchmark .jl files use the alias pattern (
import DatabentoBinaryEncoding as DBN) so ~300 existingDBN.fooreferences stay unchanged.Test plan
DBNalias resolvesjulia --project=. test/runtests.jl: 3502 pass / 1 error (unchanged from pre-rename; that 1 error is the pre-existing BenchmarkTools-not-in-[deps]issue that only surfaces when bypassingPkg.test())julia-actions/julia-runtest(usesPkg.test())Follow-ups (out of this PR)
@JuliaRegistrator registeronmain🤖 Generated with Claude Code