From e218bf06022cf593c653a75a9e5662095fe668ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Gajdu=C5=A1ek?= Date: Tue, 11 Aug 2026 15:12:42 +0200 Subject: [PATCH] Fix release tag pattern and drop redundant manual gem push The Release workflow only triggered on 'v*' tags, but the release notebook has always tagged plain versions (e.g. 3.19.0), so automated publishing to rubygems.org has never actually fired since it was added. Also remove the notebook's manual `gem push` step now that the tag push triggers automated, trusted-publishing gem release via CI. --- .github/workflows/release.yml | 2 +- rel-eng/gem_release.ipynb | 13 +------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0ce89cfd8..954fc9571 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,7 +4,7 @@ name: Release on: push: tags: - - 'v*' + - '*' jobs: release: diff --git a/rel-eng/gem_release.ipynb b/rel-eng/gem_release.ipynb index 3a2fa121c..c9397291f 100644 --- a/rel-eng/gem_release.ipynb +++ b/rel-eng/gem_release.ipynb @@ -1349,9 +1349,7 @@ { "cell_type": "markdown", "metadata": {}, - "source": [ - "### Build the gem" - ] + "source": "### Build the gem (local sanity check only)\n\nPublishing to rubygems.org is now handled automatically by the `Release` GitHub Actions\nworkflow, which triggers on tag push (see the final `git push --tags` step below) and\npublishes via rubygems.org trusted publishing. Do **not** `gem push` manually here — it\nwould either race with CI or fail because the version is already published." }, { "cell_type": "code", @@ -1362,15 +1360,6 @@ "! rake build" ] }, - { - "cell_type": "code", - "execution_count": null, - "metadata": {}, - "outputs": [], - "source": [ - "! gem push pkg/hammer_cli-{NEW_VERSION}.gem" - ] - }, { "cell_type": "markdown", "metadata": {},