Skip to content
This repository was archived by the owner on Apr 29, 2018. It is now read-only.
This repository was archived by the owner on Apr 29, 2018. It is now read-only.

Unable to unset a host once configured #20

Description

@orderoftheflame

Hi.

I've run into a problem where once a host has been set (in the config object passed to the eiscp.connect function), it is impossible to unset this, meaning that you cannot revert to selecting the first found receiver on the network.

It looks like line 290 in eiscp.js is preventing this from ever being cleared:

config.host = options.host || config.host;

Meaning that line 303 which determines whether or not to pick the first found device always resolves as false:

if (typeof config.host === 'undefined' || config.host === '') {

While I can see it as useful for the other options to not be unset, to clear the host and revert back to discovering the first host would be useful.

As an example.

var eiscp = require('eiscp');

 var connectionOptions = { port: 60128, reconnect: false, reconnect_sleep: 5, modelsets: [], send_delay: 500, verify_commands: false };

// connectionOptions.host is undefined
 eiscp.connect(connectionOptions);
 //Connects fine
 eiscp.disconnect();

connectionOptions.host = '192.168.1.81';
 eiscp.connect(connectionOptions);
 //Connects fine
 eiscp.disconnect();

connectionOptions.host = '';
 eiscp.connect(connectionOptions);
 //Attempts to connect to 192.168.1.81 regardless of other receivers.
 eiscp.disconnect();

connectionOptions.host = undefined;
 eiscp.connect(connectionOptions);
 //Attempts to connect to 192.168.1.81 regardless of other receivers.
 eiscp.disconnect();

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions