From bc3e90e4352b5ad79834a9e9f9220f7ed3de035e Mon Sep 17 00:00:00 2001 From: Josh Zhang <39790535+jiashuoz@users.noreply.github.com> Date: Sun, 27 Sep 2026 20:19:18 +0800 Subject: [PATCH] fix(web): declare the Privacy/Terms build args in web/Dockerfile #1051 read NEXT_PUBLIC_PRIVACY_URL and NEXT_PUBLIC_TERMS_URL in site.ts but never declared them in web/Dockerfile, so `docker build` dropped the hosted deployment's values and 1.12.0 shipped without the footer links or the consent line. Adds the ARG/ENV pair and a comment explaining why the Dockerfile is the allowlist. Co-Authored-By: Claude Fable 5.1 --- web/Dockerfile | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/web/Dockerfile b/web/Dockerfile index 74b863cb0..c4b261230 100644 --- a/web/Dockerfile +++ b/web/Dockerfile @@ -70,6 +70,13 @@ ARG NEXT_PUBLIC_E2A_SIGN_IN_URL= # this to the e2a.dev Umami website record id so the first-party tracker # loads on public marketing routes only (the dashboard excludes it). ARG NEXT_PUBLIC_UMAMI_WEBSITE_ID= +# Empty hides the Privacy / Terms footer links and the sign-in consent line +# (both render only when set; the consent line only when BOTH are set). The +# hosted deployment sets /privacy (served by its Caddy) and its terms URL. +# A NEXT_PUBLIC_* value that is not declared here is silently dropped by +# `docker build`, so every key web/src/lib/site.ts reads must be listed. +ARG NEXT_PUBLIC_PRIVACY_URL= +ARG NEXT_PUBLIC_TERMS_URL= ENV NEXT_PUBLIC_SITE_URL=$NEXT_PUBLIC_SITE_URL \ NEXT_PUBLIC_SITE_NAME=$NEXT_PUBLIC_SITE_NAME \ @@ -79,7 +86,9 @@ ENV NEXT_PUBLIC_SITE_URL=$NEXT_PUBLIC_SITE_URL \ NEXT_PUBLIC_PRICING_PATH=$NEXT_PUBLIC_PRICING_PATH \ NEXT_PUBLIC_BILLING_API=$NEXT_PUBLIC_BILLING_API \ NEXT_PUBLIC_E2A_SIGN_IN_URL=$NEXT_PUBLIC_E2A_SIGN_IN_URL \ - NEXT_PUBLIC_UMAMI_WEBSITE_ID=$NEXT_PUBLIC_UMAMI_WEBSITE_ID + NEXT_PUBLIC_UMAMI_WEBSITE_ID=$NEXT_PUBLIC_UMAMI_WEBSITE_ID \ + NEXT_PUBLIC_PRIVACY_URL=$NEXT_PUBLIC_PRIVACY_URL \ + NEXT_PUBLIC_TERMS_URL=$NEXT_PUBLIC_TERMS_URL COPY web ./ RUN npm run build