Merge branch 'feat/dashboard-agent-ui' into feat/dashboard-agent-flows-watch

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/DashboardAgentChat.tsx

@@ -24,8 +24,8 @@ import type { AgentPageContext } from "./page-context-types";
 import { retryAction } from "./retry-action";
 import {
   fetchChatTranscript,
-  hasOpenInvestigation,
   pollSettledTranscript,
+  transcriptLooksUnfinished,
 } from "./settled-transcript";
 import { takeNavigateIntent } from "./turn-navigation";
 import { sendRequestOutcome } from "./send-request";
@@ -373,8 +373,9 @@ export function DashboardAgentChat({
 
     onTurnSettled();
     // The terminal card is written to the chat row after the stream closes, so this
-    // mounted panel would otherwise keep showing the last `in_progress` revision.
-    if (!hasOpenInvestigation(messagesRef.current)) return;
+    // mounted panel would otherwise keep showing the last `in_progress` revision — or,
+    // if the stream died mid-tool, the tool call it never got an output for.
+    if (!transcriptLooksUnfinished(messagesRef.current)) return;
     void pollSettledTranscript<UIMessage>({
       fetchTranscript: () => fetchChatTranscript(actionPath, chatId),
       apply: (merge) => setMessages((current) => merge(current)),

apps/webapp/app/components/dashboard-agent/report-sparkline.tsx

@@ -464,10 +464,10 @@ export function ReportProvenance({ uri }: { uri: string }) {
 // --- sparkline --------------------------------------------------------------
 
 /** The fixed sparkline column. Keeps every sparkline aligned. */
-const SPARK_WIDTH_CLASS = "w-[6.5rem]";
+const SPARK_WIDTH_CLASS = "w-[5.5rem]";
 
 /** The chart's own width; the trailing peak label uses the column's remainder. */
-const SPARK_WIDTH = 72;
+const SPARK_WIDTH = 56;
 
 type ReportSparkDatum = { count: number; date: Date | null; hot: boolean };
 
@@ -570,18 +570,18 @@ export function ReportSparkline({
  * chart start on the same vertical whatever the value's width.
  */
 /**
- * Below a 22rem container the fixed tracks no longer fit beside the value, so the
+ * Below a 19rem container the fixed tracks no longer fit beside the value, so the
  * sparkline drops to its own line. The columns never change, so the value, delta
  * and note stay on the same verticals at every panel width.
  */
 const METRIC_ROW_CLASS =
-  "grid grid-cols-[7rem_minmax(0,1fr)_2.75rem_6.5rem] items-center gap-x-2 @max-[22rem]:grid-cols-[7rem_minmax(0,1fr)_2.75rem] @max-[22rem]:gap-y-1.5";
+  "grid grid-cols-[6rem_minmax(0,1fr)_2.75rem_5.5rem] items-center gap-x-2 @max-[19rem]:grid-cols-[6rem_minmax(0,1fr)_2.75rem] @max-[19rem]:gap-y-1.5";
 
 /** The sparkline cell: its own full-width line once the row goes narrow. */
-const SPARK_CELL_CLASS = "@max-[22rem]:col-span-3 @max-[22rem]:justify-self-end";
+const SPARK_CELL_CLASS = "@max-[19rem]:col-span-3 @max-[19rem]:justify-self-end";
 
-// Labels are never truncated: the column is sized for the longest one and
-// anything longer wraps.
+// Labels are never truncated: the column fits the common ones and anything
+// longer wraps.
 const LABEL_CLASS = "text-xs uppercase leading-tight tracking-wide text-text-dimmed";
 
 /** A metric's movement against its baseline. Direction is always an arrow. */
@@ -674,7 +674,7 @@ export function ReportMetricRow({
         ) : (
           // Keeps the column occupied so a series-less metric doesn't pull the
           // rows out of alignment.
-          <span aria-hidden className="@max-[22rem]:hidden" />
+          <span aria-hidden className="@max-[19rem]:hidden" />
         )}
       </li>
 
@@ -683,7 +683,7 @@ export function ReportMetricRow({
         // vertical as every other row's value.
         <li key={sub.label} className={METRIC_ROW_CLASS}>
           {/* Indented under the parent label, shallow enough to stay inside the
-              7rem label column. */}
+              6rem label column. */}
           <span className={cn(LABEL_CLASS, "pl-6")}>{sub.label}</span>
           <span className="whitespace-nowrap text-sm tabular-nums text-text-dimmed">
             {sub.value}

apps/webapp/app/components/dashboard-agent/settled-transcript.test.ts

@@ -6,6 +6,7 @@ import {
   hasOpenInvestigation,
   mergeSettledMessages,
   pollSettledTranscript,
+  transcriptLooksUnfinished,
 } from "./settled-transcript";
 
 /**
@@ -119,6 +120,27 @@ describe("reading the transcript endpoint", () => {
   });
 });
 
+describe("deciding whether a settled turn is worth re-reading", () => {
+  // The stream EOF'd while `get_report` was running: the part never gets an output.
+  const DANGLING_TOOL = {
+    id: "msg_dangling",
+    role: "assistant",
+    parts: [{ type: "tool-get_report", toolCallId: "call_1", state: "input-available" }],
+  };
+
+  it("re-reads when the stream died mid-tool, not only when a card is open", () => {
+    expect(transcriptLooksUnfinished([DANGLING_TOOL])).toBe(true);
+  });
+
+  it("re-reads while a card is still open", () => {
+    expect(transcriptLooksUnfinished([OPEN])).toBe(true);
+  });
+
+  it("leaves a fully settled transcript alone", () => {
+    expect(transcriptLooksUnfinished([OPEN, SETTLED])).toBe(false);
+  });
+});
+
 describe("an already-open panel when a turn is exhausted", () => {
   it("stops showing Working… without a reload or a reopen", async () => {
     // What the mounted panel holds when the stream closes: the card the model opened

apps/webapp/app/components/dashboard-agent/settled-transcript.ts

@@ -1,4 +1,4 @@
-import { liveInvestigation } from "./progress-line";
+import { inFlightToolName, liveInvestigation } from "./progress-line";
 
 /**
  * Re-reading the stored transcript once a turn settles.
@@ -29,6 +29,15 @@ export function hasOpenInvestigation(messages: ReadonlyArray<unknown>): boolean
   return liveInvestigation(messages as never) !== null;
 }
 
+/**
+ * Whether the transcript still reads as mid-turn. A stream that dies without
+ * `turn-complete` leaves the tool part it was on dangling forever, so an open card is
+ * not the only shape a re-read has to recover from.
+ */
+export function transcriptLooksUnfinished(messages: ReadonlyArray<unknown>): boolean {
+  return hasOpenInvestigation(messages) || inFlightToolName(messages as never) !== null;
+}
+
 /**
  * The settlement is written in `onTurnComplete`, which runs AFTER the client's stream
  * closes, so the first re-read can legitimately land before it. Retry a few times,