Merge remote-tracking branch 'origin/feat/dashboard-agent-ui' into feat/dashboard-agent-flows-watch

Author: kathiekiwi

apps/webapp/app/components/dashboard-agent/report-block-adapter.test.ts

@@ -91,11 +91,14 @@ describe("reportBlockFromToolPart", () => {
     expect(reportBlockFromToolPart(part({ output: { ...vm, generatedAt: undefined } }))).toBeNull();
   });
 
-  it("accepts the curated tool output, which drops links and series", () => {
-    const { links, ...curated } = vm;
-    const block = reportBlockFromToolPart(part({ output: { ...curated, seriesOmitted: true } }))!;
-    expect(block.vm.links).toEqual([]);
-    expect(block.vm.metrics[0]!.series).toBeUndefined();
+  it("passes the tool output's series and links through", () => {
+    const series = { points: [80, 40, 120], kind: "measured" };
+    const links = [{ key: "queues", label: "Queues", url: "/queues" }];
+    const block = reportBlockFromToolPart(
+      part({ output: { ...vm, metrics: [{ ...vm.metrics[0], series }], links } })
+    )!;
+    expect(block.vm.metrics[0]!.series).toEqual(series);
+    expect(block.vm.links).toEqual(links);
     expect(block.vm.summary.severity).toBe("crit");
   });
 

apps/webapp/app/components/dashboard-agent/report-sparkline.tsx

@@ -570,15 +570,15 @@ export function ReportSparkline({
  * chart start on the same vertical whatever the value's width.
  */
 /**
- * Below a 19rem container the fixed tracks no longer fit beside the value, so the
+ * Below a 22rem container the fixed tracks no longer fit beside the value, so the
  * sparkline drops to its own line. The columns never change, so the value, delta
  * and note stay on the same verticals at every panel width.
  */
 const METRIC_ROW_CLASS =
-  "grid grid-cols-[7rem_minmax(0,1fr)_2.75rem_6.5rem] items-center gap-x-2 @max-[19rem]:grid-cols-[7rem_minmax(0,1fr)_2.75rem] @max-[19rem]:gap-y-1.5";
+  "grid grid-cols-[7rem_minmax(0,1fr)_2.75rem_6.5rem] items-center gap-x-2 @max-[22rem]:grid-cols-[7rem_minmax(0,1fr)_2.75rem] @max-[22rem]:gap-y-1.5";
 
 /** The sparkline cell: its own full-width line once the row goes narrow. */
-const SPARK_CELL_CLASS = "@max-[19rem]:col-span-3 @max-[19rem]:justify-self-end";
+const SPARK_CELL_CLASS = "@max-[22rem]:col-span-3 @max-[22rem]:justify-self-end";
 
 // Labels are never truncated: the column is sized for the longest one and
 // anything longer wraps.
@@ -674,7 +674,7 @@ export function ReportMetricRow({
         ) : (
           // Keeps the column occupied so a series-less metric doesn't pull the
           // rows out of alignment.
-          <span aria-hidden className="@max-[19rem]:hidden" />
+          <span aria-hidden className="@max-[22rem]:hidden" />
         )}
       </li>
 

internal-packages/dashboard-agent/src/dashboard-agent.eval.ts

@@ -200,7 +200,6 @@ const FIXTURES: Record<string, unknown> = {
       },
     },
     footer: [{ code: "raise_env_limit" }],
-    seriesOmitted: true,
   },
   get_queue: {
     queue: "task/send-email",

internal-packages/dashboard-agent/src/dashboard-agent.test.ts

@@ -2478,15 +2478,16 @@ describe("the view-model tools don't echo the view back to the model", () => {
           aggregation: "max",
           normal: 40,
           severity: "crit",
+          series: { points: Array.from({ length: 60 }, (_, i) => i * 3), kind: "measured" },
           breakdown: Object.fromEntries(
             Array.from({ length: 60 }, (_, i) => [`task/queue-${i}`, i * 7])
           ),
           annotation: { code: "pending.estimated", value: 4200 },
         },
       ],
       facts: { trustworthy: true, throughput: 12 },
+      links: [{ key: "queues", label: "Queues", url: "/queues" }],
       footer: { code: "report.footer" },
-      seriesOmitted: true,
       uri: "trigger://proj_abc/env_abc/report/health",
     };
 
@@ -2505,6 +2506,8 @@ describe("the view-model tools don't echo the view back to the model", () => {
     expect(serialized).not.toContain("breakdown");
     expect(serialized).not.toContain("observations");
     expect(serialized).not.toContain("footer");
+    expect(serialized).not.toContain("series");
+    expect(serialized).not.toContain("links");
     expect(serialized.length).toBeLessThan(JSON.stringify(output).length / 2);
   });
 

internal-packages/dashboard-agent/src/tool-curation.ts

@@ -146,8 +146,9 @@ export function curateError(group: any) {
   };
 }
 
-// Drops the per-metric `series` arrays and `links`; `seriesOmitted` records that the
-// shape is lossy. Grades and `facts.trustworthy` survive verbatim.
+// The card's copy: everything it draws, including the per-metric `series` and the
+// `links` recommendations key into. The model's copy is trimmed separately by
+// `getReportModelOutput`, so this costs no context.
 export function curateReport(data: unknown) {
   const vm = (data ?? {}) as any;
   const facts = (vm.facts ?? {}) as any;
@@ -180,6 +181,7 @@ export function curateReport(data: unknown) {
       aggregation: m.aggregation,
       normal: m.normal,
       delta: m.delta,
+      series: m.series,
       breakdown: m.breakdown,
       annotation: m.annotation,
       // "unknown" means `value` is a placeholder, not a measurement. "measured" is the
@@ -200,8 +202,8 @@ export function curateReport(data: unknown) {
         dlqDelta: flowEvidence.dlqDelta,
       },
     },
+    links: vm.links,
     footer: vm.footer,
-    seriesOmitted: true,
   };
 }