fix(cli): stop percent-encoding Windows output paths in the build manifest

Fix Windows deploys failing at indexing with `Cannot find module` on a
percent-encoded path when the project directory contains spaces or
non-ASCII characters.

Mono-RevId: 570c78ee09bc121ae8066a7e70848ae4509d74e3

Author: myftija

.changeset/windows-deploy-paths-with-spaces.md

@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fix Windows deploys failing at indexing with `Cannot find module` on a percent-encoded path when the project directory contains spaces or non-ASCII characters.

packages/cli-v3/src/build/buildWorker.test.ts

@@ -0,0 +1,31 @@
+import { join, posix, sep, win32 } from "node:path";
+import { describe, expect, it } from "vitest";
+import { rewriteOutputPath } from "./buildWorker.js";
+
+describe("rewriteOutputPath", () => {
+  it("defaults to the host platform's path semantics", () => {
+    const out = join(sep, "tmp", "out");
+    expect(rewriteOutputPath(out, join(out, "src", "a b.mjs"))).toBe("/app/src/a b.mjs");
+  });
+
+  it("maps a bundled file to its /app path on posix", () => {
+    expect(rewriteOutputPath("/tmp/out", "/tmp/out/src/trigger/a.mjs", posix)).toBe(
+      "/app/src/trigger/a.mjs"
+    );
+  });
+
+  it("uses forward slashes and keeps spaces and non-ASCII characters on windows", () => {
+    const out = "C:\\Users\\me\\AppData\\Local\\Temp\\trigger-build";
+    const file = `${out}\\Documents\\DATEN VORBEREITUNG FÜR AUKTIONEN\\trigger.config.mjs`;
+
+    expect(rewriteOutputPath(out, file, win32)).toBe(
+      "/app/Documents/DATEN VORBEREITUNG FÜR AUKTIONEN/trigger.config.mjs"
+    );
+  });
+
+  it("tolerates mixed separators and drive letter case on windows", () => {
+    expect(
+      rewriteOutputPath("c:\\Users\\me\\out", "C:/Users/me/out/Trigger Demo/index.mjs", win32)
+    ).toBe("/app/Trigger Demo/index.mjs");
+  });
+});

packages/cli-v3/src/build/buildWorker.ts

@@ -22,15 +22,13 @@ import {
 import { createExternalsBuildExtension } from "./externals.js";
 import { tmpdir } from "node:os";
 import { mkdtemp, rm } from "node:fs/promises";
-import { join, relative, sep } from "node:path";
+import path, { join } from "node:path";
 import { generateContainerfile } from "../deploy/buildImage.js";
 import { writeFile } from "node:fs/promises";
 import { buildManifestToJSON } from "../utilities/buildManifest.js";
 import { logger } from "../utilities/logger.js";
 import { readPackageJSON } from "pkg-types";
 import { writeJSONFile } from "../utilities/fileSystem.js";
-import { isWindows } from "std-env";
-import { pathToFileURL } from "node:url";
 import { logBuildWorkerStart } from "./buildWorkerLogging.js";
 import { SdkVersionExtractor } from "./plugins.js";
 import { spinner } from "../utilities/windows.js";
@@ -215,17 +213,12 @@ function cleanEntryPath(entry: string): string {
   return entry.split("?")[0]!;
 }
 
-function rewriteOutputPath(destinationDir: string, filePath: string) {
-  if (isWindows) {
-    return `/app/${relative(
-      pathToFileURL(destinationDir).pathname,
-      pathToFileURL(filePath).pathname
-    )
-      .split(sep)
-      .join("/")}`;
-  } else {
-    return `/app/${relative(destinationDir, filePath)}`;
-  }
+export function rewriteOutputPath(
+  destinationDir: string,
+  filePath: string,
+  pathApi: Pick<typeof path, "relative" | "sep"> = path
+) {
+  return `/app/${pathApi.relative(destinationDir, filePath).split(pathApi.sep).join("/")}`;
 }
 
 async function writeDeployFiles({

packages/cli-v3/src/deploy/buildImage.test.ts

@@ -62,6 +62,23 @@ describe("generateContainerfile", () => {
     expect(containerfile).toContain(`FROM ${build} AS build`);
   });
 
+  it.each(["node", "bun"] as BuildRuntime[])(
+    "runs the indexer in exec form so entry paths with spaces survive on %s",
+    async (runtime) => {
+      const indexScript = "/app/Documents/Trigger Demo/index.mjs";
+      const containerfile = await generateContainerfile({
+        runtime,
+        build: {},
+        image: undefined,
+        indexScript,
+        entrypoint: "entrypoint.js",
+      });
+
+      expect(containerfile).toContain(`"${indexScript}" ]`);
+      expect(containerfile).not.toMatch(/^RUN (node|bun run) \//m);
+    }
+  );
+
   it.each(["node", "bun"] as BuildRuntime[])(
     "runs no package installation for uncustomized projects on %s",
     async (runtime) => {

packages/cli-v3/src/deploy/buildImage.ts

@@ -892,7 +892,7 @@ ARG BUILDPLATFORM
 ENV BUILDPLATFORM=$BUILDPLATFORM TARGETPLATFORM=$TARGETPLATFORM
 
 # Run the indexer
-RUN bun run ${options.indexScript}
+RUN [ "bun", "run", "${options.indexScript}" ]
 
 # Development or production stage builds upon the base stage
 FROM base AS final
@@ -1001,7 +1001,7 @@ ARG BUILDPLATFORM
 ENV BUILDPLATFORM=$BUILDPLATFORM TARGETPLATFORM=$TARGETPLATFORM
 
 # Run the indexer
-RUN node ${options.indexScript}
+RUN [ "node", "${options.indexScript}" ]
 
 # Development or production stage builds upon the base stage
 FROM base AS final