perf(webapp): sample only the selected source in the Add smart column dialog

The preview endpoint hydrated payload, metadata and output for 10 runs on every open (~3 blobs x 10, up to the 512KB inline limit each). It now fetches only the currently-selected source; the dialog passes its source and refetches when the user switches, cutting the worst-case transfer roughly threefold.

Author: ericallam

apps/webapp/app/components/runs/v3/AddSmartColumnDialog.tsx

@@ -92,10 +92,11 @@ export function AddSmartColumnDialog({
     if (sampleFilters) {
       for (const [key, val] of Object.entries(sampleFilters)) params.set(key, val);
     }
+    params.set("source", source);
     const qs = params.toString();
     return qs ? `${base}?${qs}` : base;
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [organization.slug, project.slug, environment.slug, currentSearch, sampleFiltersKey]);
+  }, [organization.slug, project.slug, environment.slug, currentSearch, sampleFiltersKey, source]);
 
   useEffect(() => {
     if (open && sample.state === "idle") {

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.smart-column-sample.ts

@@ -1,5 +1,5 @@
 import { type LoaderFunctionArgs } from "@remix-run/server-runtime";
-import { deriveRunSelect } from "~/components/runs/v3/runColumns";
+import { deriveRunSelect, type SmartColumnSource } from "~/components/runs/v3/runColumns";
 import { getRunFiltersFromRequest } from "~/presenters/RunFilters.server";
 import { clickhouseFactory } from "~/services/clickhouse/clickhouseFactoryInstance.server";
 import { loadProjectEnvironmentFromRequest } from "~/services/loadProjectEnvironmentFromRequest.server";
@@ -10,6 +10,14 @@ import { isFinalRunStatus } from "~/v3/taskStatus";
 /** How many recent runs the smart-column preview can page through. */
 const SAMPLE_RUN_COUNT = 10;
 
+const SAMPLE_SOURCES: SmartColumnSource[] = ["payload", "metadata", "output"];
+
+function parseSampleSource(value: string | null): SmartColumnSource {
+  return SAMPLE_SOURCES.includes(value as SmartColumnSource)
+    ? (value as SmartColumnSource)
+    : "payload";
+}
+
 /**
  * The most recent runs for the current filters, with their raw
  * payload/metadata/output packets, feeding the "Add smart column" preview. The
@@ -19,6 +27,7 @@ const SAMPLE_RUN_COUNT = 10;
 export async function loader({ request, params }: LoaderFunctionArgs) {
   const { project, environment } = await loadProjectEnvironmentFromRequest(request, params);
   const filters = await getRunFiltersFromRequest(request);
+  const source = parseSampleSource(new URL(request.url).searchParams.get("source"));
 
   const clickhouse = await clickhouseFactory.getClickhouseForOrganization(
     project.organizationId,
@@ -45,7 +54,7 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
     queues: filters.queues,
     machines: filters.machines,
     errorId: filters.errorId,
-    runSelect: deriveRunSelect([], ["payload", "metadata", "output"]),
+    runSelect: deriveRunSelect([], [source]),
     page: { size: SAMPLE_RUN_COUNT },
   });