Skip to content

Commit d098714

Browse files
NERLOEclaude
andcommitted
test(core): drop the timing assertion from the zodIpc ack test
The `resolves` assertion already fails when the ack is rejected, and a wall-clock bound could flake on a slow runner. Also hyphenate the changeset's compound adjectives. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent 5892ebf commit d098714

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

‎.changeset/void-ipc-acks.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"@trigger.dev/core": patch
33
---
44

5-
Fix a ~6 second delay between a task finishing and its run completing (and a ~31 second delay when cancelling a run) in projects that use zod 4.4 or newer.
5+
Fix a ~6-second delay between a task finishing and its run completing (and a ~31-second delay when cancelling a run) in projects that use zod 4.4 or newer.

‎packages/core/test/zodIpc.test.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,9 @@ describe("ZodIpcConnection", () => {
6666
it("resolves sendWithAck for a void callback after the ack crosses a JSON boundary", async () => {
6767
const connection = createConnections();
6868

69-
const start = Date.now();
7069
await expect(connection.sendWithAck("FLUSH", { timeoutInMs: 1000 }, 1000)).resolves.toBe(
7170
undefined
7271
);
73-
expect(Date.now() - start).toBeLessThan(500);
7472
});
7573

7674
it("resolves sendWithAck with the callback payload", async () => {

0 commit comments

Comments
 (0)