perf(webapp): stop hydrating run metadata on the list unless a column needs it

metadata/metadataType were selected for every runs-list row on every request but nothing on the list rendered them (the replay dialog fetches metadata via its own loader). Gate them behind a metadata smart column, like payload/output, so they are only hydrated when referenced. The public runs-list API still returns metadata, so it now requests it explicitly via the columns option.

Author: ericallam

apps/webapp/app/components/runs/v3/runColumns.test.ts

@@ -32,8 +32,6 @@ describe("deriveRunSelect", () => {
       "queueTimestamp",
       "delayUntil",
       "scheduleId",
-      "metadata",
-      "metadataType",
       "taskIdentifier",
       "machinePreset",
       "queue",
@@ -43,12 +41,14 @@ describe("deriveRunSelect", () => {
     }
   });
 
-  it("does not hydrate the large blobs unless a smart column references them", () => {
+  it("does not hydrate the source blobs unless a smart column references them", () => {
     const select = deriveRunSelect(["task", "status", "tags"], []);
     expect(select.payload).toBeUndefined();
     expect(select.payloadType).toBeUndefined();
     expect(select.output).toBeUndefined();
     expect(select.outputType).toBeUndefined();
+    expect(select.metadata).toBeUndefined();
+    expect(select.metadataType).toBeUndefined();
   });
 
   it("adds payload/output fields only for referenced smart sources", () => {
@@ -62,7 +62,8 @@ describe("deriveRunSelect", () => {
     expect(both.outputType).toBe(true);
   });
 
-  it("references metadata from the always-selected set without a smart source", () => {
+  it("adds metadata fields only when a metadata smart column references them", () => {
+    expect(deriveRunSelect([], []).metadata).toBeUndefined();
     const select = deriveRunSelect([], ["metadata"]);
     expect(select.metadata).toBe(true);
     expect(select.metadataType).toBe(true);

apps/webapp/app/components/runs/v3/runColumns.ts

@@ -47,12 +47,11 @@ export type StandardColumnDef = {
 
 /**
  * The scalar fields the shared presenter always maps into its stable output,
- * regardless of which columns show. Because the presenter contract is fixed and
- * these are all small single-row columns (no DB win from narrowing them), the
- * select currently gates only the large blobs: payload/output are added solely
- * when a smart column references them. Shrinking this set to a behaviour-only
- * floor later is a change here plus defensive presenter mapping, not an API
- * change to `deriveRunSelect`.
+ * regardless of which columns show. These are all small single-row columns with
+ * no DB win from narrowing, so the select keeps them for a stable contract and
+ * gates only the large blobs: payload, output, and metadata are added solely
+ * when a smart column references them (metadata is display-only on the list, so
+ * there is no reason to hydrate it for every row otherwise).
  */
 const ALWAYS_SELECTED_FIELDS = [
   "id",
@@ -81,8 +80,6 @@ const ALWAYS_SELECTED_FIELDS = [
   "depth",
   "rootTaskRunId",
   "batchId",
-  "metadata",
-  "metadataType",
   "machinePreset",
   "queue",
   "workerQueue",

apps/webapp/app/presenters/v3/ApiRunListPresenter.server.ts

@@ -183,6 +183,7 @@ export class ApiRunListPresenter extends BasePresenter {
     return this.trace("call", async (span) => {
       const options: RunListOptions = {
         projectId: project.id,
+        columns: { visibleStandardIds: [], smartSources: ["metadata"] },
       };
 
       // pagination
@@ -310,7 +311,7 @@ export class ApiRunListPresenter extends BasePresenter {
           const metadata = await parsePacket(
             {
               data: run.metadata ?? undefined,
-              dataType: run.metadataType,
+              dataType: run.metadataType ?? "application/json",
             },
             {
               filteredKeys: ["$$streams", "$$streamsVersion", "$$streamsBaseUrl"],

apps/webapp/app/services/runsRepository/clickhouseRunsRepository.server.ts

@@ -51,8 +51,6 @@ const LIST_RUN_DEFAULT_SELECT = {
   depth: true,
   rootTaskRunId: true,
   batchId: true,
-  metadata: true,
-  metadataType: true,
   machinePreset: true,
   queue: true,
   workerQueue: true,

apps/webapp/app/services/runsRepository/runsRepository.server.ts

@@ -119,8 +119,6 @@ export type ListedRun = Prisma.TaskRunGetPayload<{
     depth: true;
     rootTaskRunId: true;
     batchId: true;
-    metadata: true;
-    metadataType: true;
     machinePreset: true;
     queue: true;
     workerQueue: true;
@@ -129,13 +127,16 @@ export type ListedRun = Prisma.TaskRunGetPayload<{
   };
 }> & {
   /**
-   * Large source blobs hydrated only when a smart column references them (see
-   * `runSelect`). Absent from the default list select.
+   * Source blobs hydrated only when a smart column references them (see
+   * `runSelect`). Absent from the default list select; metadata is display-only
+   * on the list, payload/output can be large.
    */
   payload?: string;
   payloadType?: string;
   output?: string | null;
   outputType?: string;
+  metadata?: string | null;
+  metadataType?: string;
 };
 
 export type ListRunsOptions = RunListInputOptions &