chore: treat knip configuration and tag hints as errors

Make Knip configuration and tag hints fail with a non-zero exit code
instead of passing with warnings. Remove the redundant `agentcrumbs`
dependency ignore.

Use a TypeScript config to ignore `lefthook` only outside CI, matching
Knip's environment-dependent Lefthook detection.

Verified formatting, lint, and Knip locally, including an uncached
CI-mode check.

Mono-RevId: 3e0d4d6bb8512594d5606b6f0bf07df73e771a5f

Author: carderne

AGENTS.md

@@ -91,7 +91,7 @@ Scan your code before pushing with:
 pnpm run knip
 ```
 
-If there are false positives, edit ./knip.json so that it passes.
+If there are false positives, edit ./knip.ts so that it passes.
 
 ### Imports
 

knip.json

@@ -0,0 +1,102 @@
+import type { KnipConfig } from "knip";
+
+export default {
+  tags: ["-knipignore"],
+  treatConfigHintsAsErrors: true,
+  treatTagHintsAsErrors: true,
+  workspaces: {
+    ".": {
+      entry: [
+        "scripts/**/*.{js,mjs,cjs,ts,mts,cts}",
+        "vitest.internal.config.ts",
+        "vitest.internal-reports.config.mjs",
+      ],
+      // Analyze the shared hook config, not generated hooks that vary between checkouts.
+      lefthook: { config: ["lefthook.yml"] },
+      ignoreDependencies: process.env.CI ? ["eslint"] : ["eslint", "lefthook"],
+      ignoreBinaries: ["infisical", "prisma"],
+    },
+    "apps/webapp": {
+      entry: [
+        "evalite.config.ts",
+        "vitest.*.config.ts",
+        "evals/**/*.eval.ts",
+        "memory-leak-detector.js",
+        "prisma/populate.ts",
+        "seed*.{ts,mts}",
+        "scripts/**/*.{js,mjs,cjs,ts,mts,cts}",
+        "test/**/*.producer.ts",
+        "test/bench/analyzeProfile.ts",
+        "test/types/**/*.types.ts",
+        "test/setup/global-e2e-full-setup.ts",
+        "vite/node-globals-shim.js",
+        "app/v3/otlpTransformWorker.ts",
+      ],
+      ignoreDependencies: ["@sentry/cli", "assert", "util"],
+    },
+    "internal-packages/dashboard-agent": {
+      entry: ["trigger.config.ts", "src/investigation-sweep.ts", "src/maintenance.ts"],
+      ignoreBinaries: ["rg"],
+    },
+    "internal-packages/observability-map": {
+      entry: ["src/index.ts", "fixtures/**/*.{js,mjs,cjs,ts,mts,cts,tsx}"],
+    },
+    "internal-packages/otlp-importer": {
+      ignoreDependencies: ["ts-proto"],
+    },
+    "internal-packages/run-engine": {
+      entry: ["harness/**/*.ts"],
+    },
+    "internal-packages/run-ops-database": {
+      ignoreDependencies: ["@prisma/client", "prisma"],
+    },
+    "internal-packages/sdk-compat-tests": {
+      entry: ["src/fixtures/**/*.{js,mjs,cjs,ts,mts,cts,tsx}"],
+    },
+    "internal-packages/testcontainers": {
+      entry: ["scripts/**/*.{js,mjs,cjs,ts,mts,cts}"],
+    },
+    "internal-packages/tsql": {
+      ignoreBinaries: ["tail"],
+    },
+    "internal-packages/webhook-sources": {
+      entry: ["catalog/**/*.{js,mjs,cjs,ts,mts,cts}"],
+    },
+    "packages/build": {
+      ignoreFiles: ["src/**/*-cjs.cts"],
+      ignoreDependencies: ["@typescript/typescript6"],
+    },
+    "packages/cli-v3": {
+      entry: [
+        "src/index.ts",
+        "src/entryPoints/**/*.ts",
+        "src/**/*-cjs.cts",
+        "src/dev/devWatchdog.ts",
+        "src/shims/esm.ts",
+      ],
+      ignoreDependencies: ["@epic-web/test-server", "execa", "find-up"],
+      ignoreBinaries: ["xdg-open"],
+    },
+    "packages/core": {
+      ignoreFiles: ["src/**/*-cjs.cts"],
+      ignoreDependencies: ["ai-v7"],
+    },
+    "packages/react-hooks": {
+      ignoreDependencies: ["@types/react-dom"],
+    },
+    "packages/rsc": {
+      ignoreFiles: ["src/**/*-cjs.cts"],
+      ignoreDependencies: ["react", "react-dom"],
+    },
+    "packages/schema-to-json": {
+      ignoreDependencies: ["runtypes", "superstruct", "valibot"],
+    },
+    "packages/trigger-sdk": {
+      ignoreFiles: ["src/**/*-cjs.cts", "src/v3/index-browser.mts"],
+      ignoreDependencies: ["ai-v7", "react"],
+    },
+    docs: {
+      ignoreFiles: ["style.css"],
+    },
+  },
+} satisfies KnipConfig;

knip.ts

@@ -44,7 +44,7 @@ pre-push:
           echo ""
           echo "    pnpm run knip"
           echo ""
-          echo "  then remove the unused items or update knip.json and re-push."
+          echo "  then remove the unused items or update knip.ts and re-push."
           echo ""
           exit 1
         }