perf(webapp): bound checkSchedule environment load to the requested ids

[ericallam]

What

CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScopedEnvironments. It only ever uses the requested envs (to reject foreign env ids and reject archived branches). On a preview-heavy project that meant loading hundreds of archived branch rows to validate one, on a path called in a per-scheduled-task loop on the deploy path (createBackgroundWorker -> syncDeclarativeSchedules) and from upsertTaskSchedule.

The query is index-backed and individually fast (rows_read/returned = 1 per predicate), so this is about result-set width / egress and wasted work at scale (~580k calls/24h observed via Insights), not a slow plan.

Change

Bound the environments relation load to boundedIn(environmentIds):

environments: {
  where: { id: { in: boundedIn(environmentIds) } },
  select: { id: true, type: true, archivedAt: true },
}

Returns <= the number of requested envs (usually 1) instead of the whole project. Both existing behaviors are preserved:

• Foreign-id rejection: the relation is still scoped to the project, so a requested id belonging to another project never comes back and resolveProjectScopedEnvironments reports it as foreign (a missing requested id is already treated as foreign).
• Archived-branch rejection: a requested id that is an archived branch still comes back with archivedAt set, so the downstream Can't add or edit a schedule for an archived branch check still fires.

archivedAt is kept in the select deliberately, so this bounds by id rather than filtering archived rows out.

Evidence (isolated stack, seeded 1 prod env + 40 archived branch envs)

Local EXPLAIN (ANALYZE) of the exact environments sub-select:

	rows returned	buffers
before (unbounded)	41	shared hit=12
after (id IN (requested))	1 (Rows Removed by Filter: 40)	shared hit=4

Same RuntimeEnvironment_projectId_idx, no plan change. Rows to the client drop to len(environmentIds), which is the point.

Unit (vitest, testcontainers, real Postgres): apps/webapp/test/checkSchedule.test.ts extended to prove, on real rows, that the bounded load returns only the requested env (1 of 10), still reports a foreign id as foreign, and still surfaces an archived branch when it is the requested one. 5/5 pass.

Full e2e (both execution modes, real stack): a purpose-built project with two declarative schedules.tasks.

• trigger dev: dev worker created, both schedules synced through the edited checkSchedule loop, no errors.
• trigger deploy (managed deployment): PRODUCTION worker registered, both schedules synced against the prod environment through the same loop, prod + dev schedule instances active, no errors.

typecheck --filter webapp clean.

Rollout / rollback

Straight deploy, no flag, no migration. Rollback is revert-only (read-path narrowing, no data change). Old and in-flight rows read correctly under both the old and new code.

Out of scope

The two lower-priority sibling reads in the ticket (the Query/metrics env id->slug map and the env-var repository fan-out) are left for follow-ups; they need caching / per-method scoping rather than this single bound.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0873f09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f76dfecd-78c2-4e28-9c49-2cd6ce6fe985

📥 Commits

Reviewing files that changed from the base of the PR and between bc3a33b and 0873f09.

📒 Files selected for processing (3)

• .server-changes/bound-checkschedule-environment-load.md
• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout. (18)

• GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
• GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
• GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
• GitHub Check: obsmap / 🧪 Unit Tests: Observability Map
• GitHub Check: typecheck / typecheck
• GitHub Check: runops-guard / runops-guard
• GitHub Check: code-quality / code-quality
• GitHub Check: Analyze (javascript-typescript)

🧰 Additional context used

📓 Path-based instructions (12)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

**/*.{ts,tsx}: Prefer static imports over dynamic import(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from @trigger.dev/sdk; never use @trigger.dev/sdk/v3 or deprecated client.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with // @Crumbs or blocks with `// `#region` `@crumbs, and strip them before merging.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

{packages/core,apps/webapp}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use zod for validation in packages/core and apps/webapp

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)

**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

apps/webapp/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

apps/webapp/**/*.{ts,tsx}: Access environment variables through the env export of env.server.ts instead of directly accessing process.env
Use subpath exports from @trigger.dev/core package instead of importing from the root @trigger.dev/core path

Do not reintroduce the removed v1 execution path; RunEngineVersion.V1 branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

apps/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

For apps, use typecheck for verification and never use build as the correctness check.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

apps/webapp/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
Use useCallback and useMemo only for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

apps/webapp/app/**/*.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

apps/webapp/app/**/*.ts: Never use request.signal to detect client disconnects. Use getRequestAbortSignal() from app/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through the env export from app/env.server.ts; never use process.env directly.
Always use Prisma findFirst instead of findUnique.
Always use the $transaction helper from ~/db.server, never call prisma.$transaction or $replica.$transaction directly. Pass isolation levels as strings, use Serializable for correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

apps/webapp/app/v3/**/*.ts

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

New code must target Run Engine V2 through the singleton in app/v3/runEngine.server.ts; do not reintroduce V1 execution paths. V1 branches may only reject or finalize gracefully with a clean 4xx.

Files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

**/*.{test,spec}.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use vitest for all tests in the Trigger.dev repository

**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.

Files:

• apps/webapp/test/checkSchedule.test.ts

apps/webapp/**/*.test.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Do not import env.server.ts directly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable

Files:

• apps/webapp/test/checkSchedule.test.ts

apps/webapp/**/*.{test,spec}.{ts,tsx}

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

Test files must not import app/env.server.ts; pass configuration as options instead.

Files:

• apps/webapp/test/checkSchedule.test.ts

🧠 Learnings (52)

📓 Common learnings

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4124
File: internal-packages/database/prisma/migrations/20260629120000_drop_run_ops_control_plane_foreign_keys/migration.sql:1-26
Timestamp: 2026-07-02T19:14:58.851Z
Learning: Repo triggerdotdev/trigger.dev: In the run-ops DB split (schema.prisma / internal-packages/database/prisma/migrations), the intentional pattern is to keep Prisma `relation` declarations on models like TaskRun, Waitpoint, TaskRunWaitpoint, TaskRunCheckpoint, TaskRunAttempt, TaskRunTag, and WaitpointTag even after dropping the corresponding DB-level foreign key constraints via migration (e.g., migrations under 20260629120000_drop_run_ops_control_plane_foreign_keys and related). This is not schema drift: on the dedicated run-ops DB, `internal-packages/run-store/src/PostgresRunStore.ts` uses `stripDedicatedRelations` to strip these relation keys from Prisma select/include before querying, then `#hydrateDedicatedRelations` re-populates them from scalar columns or join lookups (e.g., hydrateAssociatedWaitpoint, hydrateBlockingTaskRuns). Do not flag missing schema updates to remove `relation` fields when FK constraints are dropped in this codebase's run-ops split migrations.

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3851
File: apps/webapp/app/v3/taskEventStore.server.ts:311-366
Timestamp: 2026-06-06T09:22:01.985Z
Learning: In `apps/webapp/app/v3/taskEventStore.server.ts` (triggerdotdev/trigger.dev), `TaskEventStore.streamDetailedTraceEvents` (and all sibling Postgres query methods: `findTraceEvents`, `findDetailedTraceEvents`) intentionally filter only by `traceId`, NOT by `environmentId`. This is consistent across the entire Postgres event-query surface. Rationale: (1) OTel trace IDs are globally-unique 16-byte values so cross-environment row mixing is not possible in practice, and (2) the download route always authorizes the run by org membership before calling these methods. Do NOT flag the absence of `environmentId` in these Postgres trace queries. The ClickHouse path scopes by `environment_id` solely because it is the partition/index key, not because the Postgres path has a correctness gap.

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 4594
File: apps/webapp/test/billingLimitQueuedRuns.test.ts:0-0
Timestamp: 2026-08-12T19:02:29.690Z
Learning: In `apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts`, `getBillableEnvironmentsForBillingLimit` must include archived billable environments. Archiving does not cancel their executing runs, so spend-limit enforcement must still find those environments. The filtering must exclude non-billable environment types such as `DEVELOPMENT`, not environments with `archivedAt` set.

📚 Learning: 2026-07-26T13:14:02.968Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4378
File: .server-changes/realtime-run-reads-from-primary.md:0-0
Timestamp: 2026-07-26T13:14:02.968Z
Learning: For files in the .server-changes directory, the body text is published verbatim as dashboard-facing user release notes. Write entries in terms of user-visible behavior (what users can do/see), and avoid implementation-oriented details such as environment-variable names, internal mechanisms, or configuration knobs. If you need to include operational/configuration specifics, put those details in the PR description instead of the .server-changes entry.

Applied to files:

• .server-changes/bound-checkschedule-environment-load.md

📚 Learning: 2026-08-12T06:32:24.127Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4577
File: apps/webapp/app/v3/services/createBackgroundWorker.server.ts:779-781
Timestamp: 2026-08-12T06:32:24.127Z
Learning: In `apps/webapp/app/v3/services/createBackgroundWorker.server.ts`, `syncDeclarativeSchedules` has a pre-existing non-serialized read/modify/delete reconciliation flow. Changes that reuse its initial schedule snapshot instead of a redundant re-fetch do not introduce this concurrency risk. Track reconciliation serialization separately from read-side performance changes unless a change modifies the synchronization boundary.

Applied to files:

• .server-changes/bound-checkschedule-environment-load.md
• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-14T14:54:39.095Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.

Applied to files:

• .server-changes/bound-checkschedule-environment-load.md

📚 Learning: 2026-07-15T18:37:08.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: apps/webapp/CLAUDE.md:0-0
Timestamp: 2026-07-15T18:37:08.044Z
Learning: Applies to apps/webapp/app/v3/services/{triggerTask,batchTriggerV3}.server.ts : Do not add database queries to `triggerTask.server.ts` or `batchTriggerV3.server.ts`; reuse the existing queue query and preserve the two-stage trigger-time/dequeue-time resolution pattern. Add task defaults to the existing `select` clause or resolve them at dequeue time.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-07-30T18:44:03.619Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4426
File: apps/webapp/test/memberDevEnvironments.server.test.ts:124-125
Timestamp: 2026-07-30T18:44:03.619Z
Learning: In `apps/webapp` service tests, `apps/webapp/test/setup.ts` loads `.env` and supplies defaults for required environment variables, so transitive imports of `~/env.server` are supported when production services require them. Do not require dependency injection solely to avoid this established test import path; introduce configuration injection only when it provides production-level value, such as a broader `createEnvironment` abstraction.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-08-12T19:02:29.690Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 4594
File: apps/webapp/test/billingLimitQueuedRuns.test.ts:0-0
Timestamp: 2026-08-12T19:02:29.690Z
Learning: In `apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts`, `getBillableEnvironmentsForBillingLimit` must include archived billable environments. Archiving does not cancel their executing runs, so spend-limit enforcement must still find those environments. The filtering must exclude non-billable environment types such as `DEVELOPMENT`, not environments with `archivedAt` set.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-26T00:55:37.444Z

Learnt from: 1stvamp
Repo: triggerdotdev/trigger.dev PR: 4367
File: internal-packages/run-engine/design/plans/2026-07-23-ck-virtual-time-scheduling-plan.md:304-312
Timestamp: 2026-07-26T00:55:37.444Z
Learning: For concurrency-key virtual-time scheduling, `apps/webapp/app/env.server.ts` validates `RUN_ENGINE_CK_VTIME_QUANTUM`, `RUN_ENGINE_CK_VTIME_WINDOW_MULTIPLIER`, and `RUN_ENGINE_CK_VTIME_STATE_TTL_SECONDS` with `z.coerce.number().int().positive()`. `internal-packages/run-engine/src/run-queue/index.ts` additionally normalizes directly supplied `RunQueueOptions.ckVirtualTimeScheduling` values: quantum falls back to 1 unless positive, and scan-window multiplier and state TTL are floored and clamped to at least 1.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-03-25T15:29:25.889Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `schedules.task()` for scheduled (cron) tasks with either declarative cron patterns or imperative schedule creation

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-03-25T15:29:25.889Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2026-03-25T15:29:25.889Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `schemaTask()` from `trigger.dev/sdk` with a Zod schema for payload validation

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-07-15T18:37:08.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: apps/webapp/CLAUDE.md:0-0
Timestamp: 2026-07-15T18:37:08.044Z
Learning: Applies to apps/webapp/app/**/*.ts : Always use the `$transaction` helper from `~/db.server`, never call `prisma.$transaction` or `$replica.$transaction` directly. Pass isolation levels as strings, use `Serializable` for correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-06-06T09:22:01.985Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3851
File: apps/webapp/app/v3/taskEventStore.server.ts:311-366
Timestamp: 2026-06-06T09:22:01.985Z
Learning: In `apps/webapp/app/v3/taskEventStore.server.ts` (triggerdotdev/trigger.dev), `TaskEventStore.streamDetailedTraceEvents` (and all sibling Postgres query methods: `findTraceEvents`, `findDetailedTraceEvents`) intentionally filter only by `traceId`, NOT by `environmentId`. This is consistent across the entire Postgres event-query surface. Rationale: (1) OTel trace IDs are globally-unique 16-byte values so cross-environment row mixing is not possible in practice, and (2) the download route always authorizes the run by org membership before calling these methods. Do NOT flag the absence of `environmentId` in these Postgres trace queries. The ClickHouse path scopes by `environment_id` solely because it is the partition/index key, not because the Postgres path has a correctness gap.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-03-10T17:56:20.938Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-03-22T13:26:12.060Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-03-22T19:24:14.403Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-18T08:21:27.694Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-13T19:53:13.759Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-17T17:13:49.929Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-23T13:04:21.413Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-03-29T19:16:28.864Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-06-09T16:27:26.195Z

Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-05-05T09:38:02.512Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-05-12T21:04:05.815Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.

Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.

Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-25T18:21:51.905Z

Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-03T17:10:21.498Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-14T08:21:07.614Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts

📚 Learning: 2026-06-04T18:16:35.386Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-09T17:58:04.699Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.

Applied to files:

• apps/webapp/app/v3/services/checkSchedule.server.ts
• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-30T18:43:56.874Z

Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4426
File: apps/webapp/test/memberDevEnvironments.server.test.ts:124-125
Timestamp: 2026-07-30T18:43:56.874Z
Learning: In the `apps/webapp` test suite (`apps/webapp/test/**`), respect the established test harness in `apps/webapp/test/setup.ts`: it loads `.env` and provides default values for required environment variables so that transitive imports (e.g., `~/env.server`) work without production-style wiring.

During code review, do not require dependency injection/refactoring solely to avoid this existing import path. Only introduce configuration injection if it delivers production-level value (for example, a more general `createEnvironment` abstraction that improves runtime behavior beyond test setup).

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-27T15:07:14.579Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4397
File: apps/webapp/test/batchStreamGrants.test.ts:0-0
Timestamp: 2026-07-27T15:07:14.579Z
Learning: In `triggerdotdev/trigger.dev`, `apps/webapp/test/authorizationRateLimitMiddleware.test.ts` remains skipped because correcting its plaintext Redis fixture setup (`tlsDisabled`) exposed a timing-sensitive sliding-window test based on real 10-second windows. The new authorization-rate-limit bypass coverage instead lives in the unskipped, deterministic `apps/webapp/test/authorizationRateLimitMiddlewareBypass.test.ts`. Do not flag the legacy suite's continued skip as missing coverage for the bypass behavior.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-04-15T15:39:31.575Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/webapp.mdc:0-0
Timestamp: 2026-04-15T15:39:31.575Z
Learning: Applies to apps/webapp/**/*.test.{ts,tsx} : Do not import `env.server.ts` directly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-15T18:37:08.044Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: apps/webapp/CLAUDE.md:0-0
Timestamp: 2026-07-15T18:37:08.044Z
Learning: Applies to apps/webapp/**/*.{test,spec}.{ts,tsx} : Test files must not import `app/env.server.ts`; pass configuration as options instead.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-08T17:53:11.238Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/test/dashboardAgentWatchErrorFingerprint.test.ts:0-0
Timestamp: 2026-08-08T17:53:11.238Z
Learning: In `apps/webapp/test/setup.ts`, environment defaults such as `SESSION_SECRET` use `??=`. This preserves values supplied by the shell or CI. During review, do not treat this setup behavior as an unconditional test-environment override.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-04-16T13:45:22.317Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/test/engine/taskIdentifierRegistry.test.ts:3-19
Timestamp: 2026-04-16T13:45:22.317Z
Learning: In `apps/webapp/test/engine/taskIdentifierRegistry.test.ts`, the `vi.mock` calls for `~/services/taskIdentifierCache.server` (stubbing `getTaskIdentifiersFromCache` and `populateTaskIdentifierCache`), `~/models/task.server` (stubbing `getAllTaskIdentifiers`), and `~/db.server` (stubbing `prisma` and `$replica`) are intentional. The suite uses real Postgres via testcontainers for all `TaskIdentifier` DB operations, but isolates the Redis cache layer and legacy query fallback as separate concerns not exercised in this test file. Do not flag these mocks as violations of the no-mocks policy in future reviews.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-04-07T14:12:18.946Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3331
File: apps/webapp/test/engine/batchPayloads.test.ts:5-24
Timestamp: 2026-04-07T14:12:18.946Z
Learning: In `apps/webapp/test/engine/batchPayloads.test.ts`, using `vi.mock` for `~/v3/objectStore.server` (stubbing `hasObjectStoreClient` and `uploadPacketToObjectStore`), `~/env.server` (overriding offload thresholds), and `~/v3/tracer.server` (stubbing `startActiveSpan`) is intentional and acceptable. Simulating controlled transient upload failures (e.g., fail N times then succeed) to verify `p-retry` behavior cannot be reproduced with real services or testcontainers. This file is an explicit exception to the repo's general no-mocks policy.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-11T22:35:59.403Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4556
File: apps/webapp/test/dashboardAgentWatchLimitStatus.test.ts:22-55
Timestamp: 2026-08-11T22:35:59.403Z
Learning: In `apps/webapp/test/dashboardAgentWatchLimitStatus.test.ts`, route-level tests may use narrow Vitest module seams to provide authentication, access control, and deterministic plan-limit configuration when the test uses `postgresTest` with real Prisma seeding and a real dashboard-agent database client. Do not flag these seams as Testcontainers violations when the test verifies a route response and container-backed persistence behavior remains real.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-18T18:31:37.633Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4285
File: internal-packages/run-store/src/runOpsStore.presentersWaitpointReadView.replicaLag.test.ts:24-65
Timestamp: 2026-07-18T18:31:37.633Z
Learning: In `triggerdotdev/trigger.dev`’s `internal-packages/run-store/src/runOpsStore.presentersWaitpointReadView.replicaLag.test.ts`, retain the local real-Testcontainers Prisma proxy rather than requiring the shared `laggingReplica` helper: the test must simulate lag for `waitpointTag` reads and for `findWaitpointConnectedRunIds`, which uses `$queryRaw`. The shared primitive intercepts configured Prisma models but not raw queries, so replacing the proxy would allow the live raw join to observe primary data and invalidate the replica-lag guard. The related taskRun-only tests (`runOpsStore.realtimeServicesReadView.replicaLag.test.ts`, `runOpsStore.replayReadAfterWrite.replicaLag.test.ts`, and `runOpsStore.resolveRunForMutationReplicaLag.test.ts`) can use the shared primitive with `{ model: "taskRun", mode: "missing" }`.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-03-02T12:43:25.254Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: internal-packages/run-engine/CLAUDE.md:0-0
Timestamp: 2026-03-02T12:43:25.254Z
Learning: Applies to internal-packages/run-engine/src/engine/tests/**/*.test.ts : Implement tests for RunEngine in `src/engine/tests/` using testcontainers for Redis and PostgreSQL containerization

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-18T18:17:16.266Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4285
File: internal-packages/run-store/src/runOpsStore.routesSpanTraceReadView.replicaLag.test.ts:50-81
Timestamp: 2026-07-18T18:17:16.266Z
Learning: In triggerdotdev/trigger.dev replica-lag integration tests, some sibling test files intentionally use shape-scoped local Prisma proxy wrappers over real Postgres testcontainers to simulate only the read operations exercised by that site. These are not dependency mocks or Testcontainers-policy violations. Consolidation onto the shared `laggingReplica` primitive may be deliberately deferred to a follow-up to avoid infrastructure churn before merge; treat this as a consistency/maintenance concern rather than a merge-blocking functional defect.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-12T08:49:25.047Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4516
File: apps/webapp/test/queryRouteReadOnly.test.ts:38-84
Timestamp: 2026-08-12T08:49:25.047Z
Learning: In `apps/webapp/test/queryRouteReadOnly.test.ts`, Vitest module mocks are intentional for route tests that must prove rejected write queries do not call ClickHouse, persistence, or concurrency infrastructure. Use container-backed tests when persistence behavior is under test, not to replace this verify-not-called seam.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-18T18:17:07.979Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 4285
File: internal-packages/run-store/src/runOpsStore.presentersWaitpointReadView.replicaLag.test.ts:24-65
Timestamp: 2026-07-18T18:17:07.979Z
Learning: In triggerdotdev/trigger.dev replica-lag integration tests, Proxy wrappers around real Postgres Testcontainers Prisma clients that selectively simulate lagged read shapes are valid test infrastructure, not prohibited mocked integration dependencies. Prefer the shared `laggingReplica` primitive for consistency when practical, but a migration from existing site-specific wrappers can be deferred as non-blocking test-infrastructure cleanup.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-18T14:40:02.173Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-07-26T20:37:56.220Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4379
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.vercel.tsx:0-0
Timestamp: 2026-07-26T20:37:56.220Z
Learning: In `apps/webapp/app/components/integrations/VercelBuildSettings.tsx` and the Vercel onboarding flow, `atomicBuilds` is intentionally UI-constrained to `["prod"]` or `[]`; although its schema accepts `EnvSlug` values, supported UI paths never write `"stg"`. When clearing a Vercel Staging environment mapping in `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.vercel.tsx`, only `pullEnvVarsBeforeBuild` and `discoverEnvVars` need to have `"stg"` removed.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-12T15:52:09.289Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4592
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.branches/route.tsx:263-271
Timestamp: 2026-08-12T15:52:09.289Z
Learning: In `apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.branches/route.tsx`, the `branchableEnvironment === false` header intentionally does not include the `Branches docs` action. The documentation action restoration must match the pre-removal UI behavior.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-08T08:33:22.847Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts:127-134
Timestamp: 2026-08-08T08:33:22.847Z
Learning: In triggerdotdev/trigger.dev dashboard routes, `apps/webapp/app/models/project.server.ts` function `findProjectBySlug` resolves the project slug and organization membership scope through `$replica`. Equivalent dashboard-agent scope lookups, including the `unread=1` path in `apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.dashboard-agent.ts`, should retain `$replica` consistency unless the repository establishes a specific primary-read requirement.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-01T15:45:09.326Z

Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3499
File: apps/webapp/test/auth-cross-cutting.e2e.full.test.ts:206-213
Timestamp: 2026-05-01T15:45:09.326Z
Learning: In `apps/webapp/test/auth-cross-cutting.e2e.full.test.ts`, the cross-environment JWT isolation test intentionally asserts `expect([401, 404]).toContain(res.status)` rather than a strict `expect(res.status).toBe(404)`. The dual-status assertion is deliberate: both 401 (auth rejected) and 404 (resource not found in the resolved env) prove the negative — that the JWT cannot access a resource scoped to a different environment. The loose assertion is kept so a planned change to the auth response code (e.g. returning 404 instead of 401 for cross-env mismatch) does not immediately break this test. The control case that proves the JWT itself is valid is covered by other tests in the same describe block.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-11T21:56:48.387Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4529
File: apps/webapp/test/contextlessPatRoutes.test.ts:32-38
Timestamp: 2026-08-11T21:56:48.387Z
Learning: In `apps/webapp/test/contextlessPatRoutes.test.ts`, route-builder authorization unit tests may use Vitest mocks when they must assert that denied requests do not call persistence or infrastructure dependencies. Container-backed tests should cover flows where persistence behavior is under test, such as `userActorPatOnlyBoundary` and `userActorProjectWideScope`. Do not apply the Testcontainers requirement to replace these authorization decision seams.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-07T12:25:18.271Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-05-28T20:02:10.647Z

Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-08-08T12:49:17.489Z

Learnt from: kathiekiwi
Repo: triggerdotdev/trigger.dev PR: 4525
File: apps/webapp/test/dashboardAgentWatchAlertOwnerScope.test.ts:101-109
Timestamp: 2026-08-08T12:49:17.489Z
Learning: In apps/webapp/test, every test suite that creates a client with createDashboardAgentDb(connectionUri, ...) must close the DashboardAgentDbClient in afterEach. Although postgresTest drops cloned databases with WITH (FORCE), it does not clean up client-side postgres-js pool sockets or idle timers, so explicitly closing the client prevents resource leaks and test interference.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

📚 Learning: 2026-06-16T09:19:47.637Z

Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.

Applied to files:

• apps/webapp/test/checkSchedule.test.ts

🔇 Additional comments (3)

apps/webapp/app/v3/services/checkSchedule.server.ts (1)

9-9: LGTM!

Also applies to: 84-86

.server-changes/bound-checkschedule-environment-load.md (1)

1-6: LGTM!

apps/webapp/test/checkSchedule.test.ts (1)

2-2: LGTM!

Also applies to: 28-68, 95-150

---

Walkthrough

CheckScheduleService now limits project environment queries to requested environment IDs with boundedIn. Tests cover active and archived preview environments, exclusion of unrequested environments, rejection of foreign IDs, and retention of requested archived environments. A webapp improvement entry documents the change.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main performance change: bounding CheckSchedule environment loading to requested IDs.
Description check	✅ Passed	The description explains the change, preserved behaviors, test coverage, performance evidence, rollout, rollback, and scope.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/tri-13187-perfcontrol-plane-checkschedule-loads-all-project

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.