test: cover every client-local error on both clients (#143)

Author: tharropoulos

tests/api_call_test.py

@@ -19,6 +19,7 @@
 from tests.utils.object_assertions import assert_match_object, assert_object_lists_match
 from typesense import exceptions
 from typesense.sync.api_call import ApiCall, RequestHandler
+from typesense.async_.api_call import AsyncApiCall
 from typesense.configuration import Configuration, Node
 from typesense.logger import logger
 
@@ -634,3 +635,61 @@ def test_max_retries_no_last_exception(fake_api_call: ApiCall) -> None:
             num_retries=10,
             last_exception=None,
         )
+
+
+@pytest.mark.parametrize(
+    "client_side_error",
+    [
+        httpx.PoolTimeout("Pool timeout"),
+        httpx.LocalProtocolError("Local protocol error"),
+        httpx.DecodingError("Decoding error"),
+        httpx.TooManyRedirects("Too many redirects"),
+    ],
+)
+def test_client_side_error_does_not_mark_node_unhealthy(
+    fake_api_call: ApiCall,
+    client_side_error: httpx.HTTPError,
+) -> None:
+    """Test that client-side httpx errors propagate without failing over."""
+    with respx.mock:
+        respx.get("http://nearest:8108/").mock(side_effect=client_side_error)
+        node0_route = respx.get("http://node0:8108/").mock(
+            return_value=httpx.Response(200, json={"key": "value"}),
+        )
+
+        with pytest.raises(type(client_side_error)):
+            fake_api_call.get("/", entity_type=typing.Dict[str, str])
+
+        assert len(respx.calls) == 1
+        assert not node0_route.called
+
+    assert fake_api_call.config.nearest_node.healthy is True
+
+
+@pytest.mark.parametrize(
+    "client_side_error",
+    [
+        httpx.PoolTimeout("Pool timeout"),
+        httpx.LocalProtocolError("Local protocol error"),
+        httpx.DecodingError("Decoding error"),
+        httpx.TooManyRedirects("Too many redirects"),
+    ],
+)
+async def test_async_client_side_error_does_not_mark_node_unhealthy(
+    fake_async_api_call: AsyncApiCall,
+    client_side_error: httpx.HTTPError,
+) -> None:
+    """Test that client-side httpx errors propagate without failing over (async)."""
+    with respx.mock:
+        respx.get("http://nearest:8108/").mock(side_effect=client_side_error)
+        node0_route = respx.get("http://node0:8108/").mock(
+            return_value=httpx.Response(200, json={"key": "value"}),
+        )
+
+        with pytest.raises(type(client_side_error)):
+            await fake_async_api_call.get("/", entity_type=typing.Dict[str, str])
+
+        assert len(respx.calls) == 1
+        assert not node0_route.called
+
+    assert fake_async_api_call.config.nearest_node.healthy is True