Skip to content

Use setup-uv defaults for Python and the venv - #59

Merged
glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults
Oct 6, 2026
Merged

glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Replaces actions/setup-python with ultralytics/actions/setup-uv. By default, that action now activates a venv on the newest Python preinstalled on the runner, with no Python download. Packages install into that venv, so --system is dropped. Jobs that pin a Python version keep the pin on setup-uv, which uses the preinstalled copy when the runner has one.

CI first ran against the setup-uv-defaults branch of ultralytics/actions#915. #915 is now merged (da5463a, released as 0.4.0), so setup-uv is back on @main, which carries the new defaults.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

CI now uses ultralytics/actions/setup-uv to set up Python and its virtual environment, so generated SDK dependencies install into that environment instead of system Python.

📊 Key Changes

  • Replaced actions/setup-python and the separate setup-uv step with one setup-uv step, retaining the Python version from the CI matrix.
  • Removed --system from the generated Python SDK installation command.

🎯 Purpose & Impact

  • CI uses the setup-uv environment for SDK checks; there is no user-facing change to the generated SDK.

@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/openapi 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/openapi main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the CI workflow’s Python setup and generated-package installation changes. The venv setup and removal of --system are consistent; no concrete regressions found. LGTM.

@UltralyticsAssistant
UltralyticsAssistant dismissed their stale review October 6, 2026 17:19

Superseded by new review

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 2

Made with ❤️ by Ultralytics Actions

Since Review 1, the diff is unchanged. I’m reversing the prior LGTM based on the current status of upstream #915: it remains open, but this workflow references @main rather than the branch intended for validation. The rest of the Python setup and install changes look consistent.

💬 Posted 1 inline comment
  • 💡 MEDIUM .github/workflows/ci.yml:35 While ultralytics/actions#915 is still open, this uses main instead of the setup-uv-defaults branch specified for validating the new defaults. CI therefore won't exercise the action revision this migration depends on. Point to @setup-uv-defaults for validation, then switch to @main after #915 merges as planned.

Comment thread .github/workflows/ci.yml
bun-version: latest

- uses: actions/setup-python@v7
- uses: ultralytics/actions/setup-uv@main

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

Comment thread .github/workflows/ci.yml
bun-version: latest

- uses: actions/setup-python@v7
- uses: ultralytics/actions/setup-uv@main

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 3

Made with ❤️ by Ultralytics Actions

Since Review 2, the upstream action change has merged, resolving the prior concern about using @main. The CI workflow’s Python setup and SDK installation changes are consistent with the described defaults; no concrete regressions found. LGTM.

@glenn-jocher
glenn-jocher merged commit 2e90ddd into main Oct 6, 2026
9 checks passed
@glenn-jocher
glenn-jocher deleted the setup-uv-defaults branch October 6, 2026 17:45
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 This PR was merged—thank you, @glenn-jocher! CI now installs generated SDK dependencies into the setup-uv environment, keeping them out of system Python.

“Great things are done by a series of small things brought together.” — Vincent van Gogh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants