Skip to content

Accept normalized CLA signature comments - #34

Merged
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828
Aug 28, 2026
Merged

Accept normalized CLA signature comments#34
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 28, 2026

Copy link
Copy Markdown
Member

Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.

This makes only the signature gate permissive. The recheck command remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.

Related matcher fix: ultralytics/actions#894

Validation:

  • actionlint .github/workflows/cla.yml
  • npx prettier@3.8.5 --check .github/workflows/cla.yml

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated the CLA workflow gate to pass comments containing the valid signature phrase to the existing action matcher, allowing normalized signatures to be evaluated.

📊 Key Changes

  • Replaced exact equality for CLA signature comments with a contains() check in .github/workflows/cla.yml.
  • Kept the recheck command’s exact-match requirement unchanged.
  • Preserved the action’s responsibility for determining whether the normalized comment is a valid CLA signature.

🎯 Purpose & Impact

  • CLA comments with trailing whitespace or surrounding Markdown can now reach the signature validation step instead of being rejected by the workflow gate.
  • Comments that merely contain quoted or instructional text remain subject to the action’s existing signature validation and do not automatically sign the CLA.

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved labels Aug 28, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/pre-commit 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/pre-commit main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed .github/workflows/cla.yml and the surrounding workflow contract. The signature gate now admits comments containing a candidate signature so normalized line matching can run, while recheck remains exact as intended. No concrete correctness, security, compatibility, or performance issues found. LGTM.

@glenn-jocher
glenn-jocher merged commit 7e86171 into main Aug 28, 2026
5 checks passed
@glenn-jocher
glenn-jocher deleted the cla-signature-gate-20260828 branch August 28, 2026 10:25
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #34 has been merged—thank you, @glenn-jocher, for improving the CLA workflow gate!

“Great things are done by a series of small things brought together.” — Vincent van Gogh

This focused change lets comments containing valid signature phrases reach the existing matcher, so normalized signatures with surrounding whitespace or Markdown can be evaluated while preserving exact matching for recheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants