[unic-archon-dlc] Build workflow — self-contained /unic-dlc-review command

[orioltf]

Parent

docs/issues/unic-archon-dlc/PRD.md

What to build

A self-contained /unic-dlc-review command that performs a multi-aspect PR review as an AFK Archon node. It is independent of any external review plugin so users can run the full DLC without installing pr-review-toolkit.

In scope:

• /unic-dlc-review command + workflow node invoked after the human PR gate from slice 10 (the human gate approves the PR; the review runs automatically on the diff).
• Four review aspects, each emitting a structured finding list:
  1. Code quality — readability, naming, function length, project-convention adherence (reads CLAUDE.md/AGENTS.md).
  2. Test coverage adequacy — exercises through public interfaces, asserts on outputs not internals, no mocks of internal collaborators.
  3. Silent failure patterns — swallowed exceptions, empty catch blocks, fallbacks that hide bugs.
  4. Type design quality — encapsulation, invariants expressed in types, illegal-state-unrepresentable patterns.
• Inspiration references documented in the command file:
  • This monorepo's apps/claude-code/pr-review/ (patterns, not runtime dependency).
  • Matt Pocock's review skill (https://github.com/mattpocock/skills/blob/main/skills/in-progress/review/SKILL.md).
  • Note in the command file that this is a base review intended to evolve; later slices may deepen each aspect.
• Output: a structured review comment posted via the tracker adapter against the PR opened by slice 10. Findings are grouped by aspect with file:line references.
• No runtime dependency on pr-review-toolkit or any other plugin — verified by running the review in a project where pr-review-toolkit is not installed.

Out of scope: integrating the review with the qa workflow's gates (slice 12 reads but does not depend on the review output).

Acceptance criteria

• /unic-dlc-review runs to completion on a project that does not have pr-review-toolkit installed.
• The review posts a single structured comment grouped by the four aspects, each with at least one finding or an explicit "no findings" line.
• Findings include file:line references where applicable.
• Command file uses the unic-dlc- prefix and includes the inspiration references in its prologue.
• Re-running the review on the same PR updates the prior comment rather than appending a duplicate.

Blocked by

• [unic-archon-dlc] Triage workflow and tracker adapter #103
• [unic-archon-dlc] Build workflow — verification, goals-check, report, and PR gate #110

---

PRD: docs/issues/unic-archon-dlc/PRD.md
Migrated from: docs/issues/unic-archon-dlc/11-build-self-contained-review-command.md (source removed after migration)
Touched by PRs: #33

[orioltf]

Superseded by the two-axis redesign of unic-archon-dlc (PRs #262–#273, shipped 2026-07-03, v0.12.0).

This issue specifies the pre-redesign architecture — six Archon workflows, a tracker-adapter lib, yaml-gen/dag-builder, and docs/workflow/ artifacts. All of those were deliberately dissolved:

• Container now follows structural need — Archon workflows only for the AFK-isolated legs, commands/skills for interactive work (ADR-0017).
• tracker-adapter, dag-builder, yaml-gen, findings-writer and spike-verdicts were dissolved in favour of a generic core plus config (ADR-0018).
• Session artifacts moved to <artifacts_dir>/<slug>/; ROADMAP.md and HANDOFF.md were dropped (ADR-0013, ADR-0015).

Closing as rejected — the intent shipped, the specified design did not. Removing ready-for-agent so it cannot be dispatched. Current architecture: CONTEXT.md, ADRs 0011–0029.