Conversation
Deploying create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee with
|
| Latest commit: |
1df4159
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee430b78.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
| Branch Preview URL: | https://20260411.create-cpu-c8345196-9409-4cce-afc4-389f413ad8ee.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bundles several related improvements to the editor and simulation:
Display node now renders simulation output
CCComponentEditorRendererNodeDisplayRendererreads the value of thePixelsinput pin in play mode and paints each cell black/white accordingly, instead of always rendering an empty grid.Time-stepped input values
InputValueKeyis now[CCComponentPinId, TimeStep]instead of justCCComponentPinId, so manually-set input values are tracked per time step.getInputValuefalls back to the previous time step's value when none is set for the current step, keeping inputs sticky as time advances.ComponentPinrenderer, simulation harness) are updated to pass the currenttimeStep.Pin bit-width policy refactor
IntrinsicComponentPinBitWidthPolicywith three variants:inferred,fixed(withcalculateBitWidth), andconfigurable(withisSplittable).getComponentPinBitWidthStatuswith a policy lookup via the newIntrinsicComponentDefinition.getPinAttributesByPinId/getByComponentIdstatic accessors.intrinsics/definitions.tsnow declares an explicitbitWidthPolicy(e.g.display.Pixelsderives its width fromresolution.x * resolution.y).defaultBitWidthis threaded throughComponentEvaluationContextandsimulateComponent, so unfixed pins can fall back to the parent's resolved width instead of hard-coded1.Reconnect connections on bit-width change
NodePinPropertyEditor, after a manual bit-width change, connections are re-evaluated: still-compatible ones are recreated instead of being silently dropped.Reset button and default sample extraction
store/react/index.tsxinto a newstore/samples/default.ts(setupDefaultSample).resetStoreaccepts an optional JSON payload; when omitted, the default sample is restored.Auto-cleanup of orphaned nodes
CCNodeStore.mountnow listens forcomponents.willUnregisterand unregisters nodes whosecomponentIdorparentComponentIdmatches the removed component, preventing dangling references.