Skip to content

Question Regarding User Stream Listener #26

@abhishekShukla

Description

@abhishekShukla

Hi,

I was going through the code.

I have questions regarding the code in this file:

src/main/scala/tshrdlu/util/bridge.scala

  1. I understand that "def onStatus(status: Status) = actor ! status" is handled by the "Bot" actor.

Events like below are handled by which actor?

def onDeletionNotice(notice: StatusDeletionNotice) = actor ! notice
def onStallWarning(warning: StallWarning) = actor ! warning

  1. You have case classes defined for few other events. Instead of that could you not have just worked if you had left the implementations empty?

For example:

Instead of

def onTrackLimitationNotice(int: Int) = actor ! TrackLimitationNotice(int)

This would have worked fine too.
def onTrackLimitationNotice(int: Int) { /* Purposefully left Empty */ }

Is there something that I am missing?
Good Practice, maybe?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions