Skip to content

[BUG] Do not publish push-triggered benchmark runs to gh-pages #158

Description

@lukekarrys

Problem

A push to main that touches a benchmark-relevant file starts a full benchmark run, and the deploy job can publish it to gh-pages. During the performance incident, a push caused a run that had to be cancelled mid-production deployment to avoid overwriting the day’s data with a contaminated point.

PR #143 prevents partial manual dispatches from deploying, but push-triggered full runs still pass the current deploy condition.

Proposed policy

Only scheduled runs and explicit, non-partial manual dispatches should publish benchmark history. Push runs should retain logs/artifacts for validation but should not overwrite the canonical daily data.

Also review whether every scripts/ change needs to trigger the benchmark matrix; processing-only changes may not.

Acceptance criteria

  • Push-triggered benchmark runs cannot deploy to gh-pages.
  • Scheduled runs continue to deploy canonical daily results.
  • Default/full manual dispatch behavior is explicit and tested.
  • Push runs still retain enough artifacts/logs for validation.
  • Change detection distinguishes processing-only changes where practical.

Source

Performance investigation: item 5 — push-to-main deploys gh-pages

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions