fix(proposals): catch id collision in check_approvable batch precheck

[jaytbarimbao-collab]

summary

approve() refuses to overwrite an artifact whose id already exists (guards against a crash-retry between put_<kind>() and move_proposal_to_decided() silently rewriting it), but check_approvable() — the read-only precheck vouch approve a b uses to validate a whole batch before mutating anything — never re-implemented that same guard.

what changed

so a claim/entity/relation proposal whose id collides with an existing artifact passes the precheck as approvable, then approve() raises on it anyway — breaking the documented all-or-nothing batch guarantee (a typo or already-decided id is supposed to abort the whole batch before anything mutates; instead the batch can partially apply).

factored the existing-artifact check into a shared, non-raising _existing_artifact_block_reason helper in src/vouch/proposals.py. approve()'s _ensure_no_existing_artifact now delegates to it, and check_approvable calls the same helper for the same set of kinds (all but page and delete — the same exception approve() already carves out).

test plan

new regression test test_check_approvable_catches_id_collision_with_existing_claim in tests/test_storage.py: approves a claim with id foo-bar, files a second pending claim proposal with the same id, asserts check_approvable now returns a non-None "already exists" reason (fails on the old code — returns None), and that approve() still raises on it.

.venv/bin/python -m ruff check src tests
.venv/bin/python -m mypy src
.venv/bin/python -m pytest tests/ -q --ignore=tests/embeddings

all three clean.

[coderabbitai]

Warning

Review limit reached

@plind-junior, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 49246d99-3f60-4fdf-a4d7-7debd64570cd

📥 Commits

Reviewing files that changed from the base of the PR and between 4de2b66 and dd2990a.

📒 Files selected for processing (3)

• CHANGELOG.md
• src/vouch/proposals.py
• tests/test_storage.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[plind-junior]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.