fix(transcript): record the codex session model from turn_context#499
Open
Yurii214 wants to merge 1 commit into
Open
fix(transcript): record the codex session model from turn_context#499Yurii214 wants to merge 1 commit into
Yurii214 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
tests
Yurii214
force-pushed
the
fix/codex-transcript-model
branch
from
3a7f7ae to
1d88d8b
Compare
parse_codex_transcript only read session_meta, which carries cwd, branch and timestamps but not the model — codex puts the turn model on the turn_context record. so the normalized transcript's session model was always none for codex, while the claude parser fills it from the assistant message. read the model off turn_context (first non-empty wins) so both agents expose it.
Yurii214
force-pushed
the
fix/codex-transcript-model
branch
from
1d88d8b to
92cb630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_codex_transcriptpopulatedsession.modelfrom nowhere — it only handledsession_meta, which carries cwd, branch and timestamps but not the model. codex records the turn's model on a separateturn_contextrecord, so the normalized transcript'ssession.modelwas alwaysNonefor codex, whileparse_claude_transcriptfills it from the assistant message.this reads the model off
turn_context(first non-empty wins, since the model can change across turns), so both agents expose the session model symmetrically. no other field is touched.verified:
pytest tests/,mypy src,ruff check src testsall green. the codex transcript test now asserts the model is extracted.