From 65ef7b9dbfeb04b4c9ea314ce68256eebde51349 Mon Sep 17 00:00:00 2001 From: "warp-agent-staging[bot]" <240773466+warp-agent-staging[bot]@users.noreply.github.com> Date: Wed, 23 Sep 2026 21:38:45 +0000 Subject: [PATCH] Avoid panicking in drop target QueryInterface --- src/platform_impl/windows/drop_handler.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/platform_impl/windows/drop_handler.rs b/src/platform_impl/windows/drop_handler.rs index 38cb5c54da..e45fcdb96f 100644 --- a/src/platform_impl/windows/drop_handler.rs +++ b/src/platform_impl/windows/drop_handler.rs @@ -5,7 +5,7 @@ use std::ptr; use std::sync::atomic::{AtomicUsize, Ordering}; use windows_sys::core::{IUnknown, GUID, HRESULT}; -use windows_sys::Win32::Foundation::{DV_E_FORMATETC, HWND, POINTL, S_OK}; +use windows_sys::Win32::Foundation::{DV_E_FORMATETC, E_FAIL, HWND, POINTL, S_OK}; use windows_sys::Win32::System::Com::{IDataObject, DVASPECT_CONTENT, FORMATETC, TYMED_HGLOBAL}; use windows_sys::Win32::System::Ole::{CF_HDROP, DROPEFFECT_COPY, DROPEFFECT_NONE}; use windows_sys::Win32::UI::Shell::{DragFinish, DragQueryFileW, HDROP}; @@ -55,9 +55,8 @@ impl FileDropHandler { _riid: *const GUID, _ppvObject: *mut *mut c_void, ) -> HRESULT { - // This function doesn't appear to be required for an `IDropTarget`. - // An implementation would be nice however. - unimplemented!(); + tracing::warn!("`QueryInterface` called, but it was unimplemented"); + E_FAIL } pub unsafe extern "system" fn AddRef(this: *mut IUnknown) -> u32 {