Source: Source pull request number: 895 in rohitg00/agentmemory (URL omitted to avoid GitHub cross-reference)
Title: fix(doctor): make engine checks private-install-aware and honor manualOnly
Author: rohitg00
State: open
Draft: no
Merged: no
Head: rohitg00/agentmemory:fix/doctor-private-install-checks @ 18ce604
Base: main @ 25e7701
Labels: (none)
Changed files: 0
Commits: 0
Created: 2026-06-10T22:49:57Z
Updated: 2026-06-10T22:54:11Z
Closed: (not closed)
Merged at: (not merged)
Original PR body:
Closes #874, closes #875.
The engine-version-mismatch and iii-on-path-not-local-bin checks probed only the PATH-resolved iii binary, while their fixes install the pinned engine to ~/.agentmemory/bin, which is only prepended to PATH in-process. Both checks therefore failed forever and re-prompted on every doctor run, and the offered fixes were no-ops.
Both checks now consult the private install first and pass when it exists at the pinned version, noting a mismatched PATH iii as informational detail since the private install wins at runtime. The version-mismatch fix converges: install then recheck passes. runDoctor consults a new canAutoFix helper in both interactive and --all paths, so manualOnly diagnostics print their manual fix hint and count as skipped instead of prompting or auto-applying.
Tested by new cases in test/cli-doctor-fixes.test.ts including a stateful installer stub proving fix convergence.
Summary by CodeRabbit
-
Bug Fixes
- Improved version mismatch detection between private install and PATH binary locations
- Refined diagnostic messaging for mismatched or unavailable runtime environments
-
New Features
- Doctor command now identifies which diagnostics can be auto-fixed versus requiring manual intervention
- Enhanced diagnostic loop to skip prompts for manual-only issues and provide clearer guidance
Local branch: review/issues-874-875-pr-895-doctor-engine-checks
Fork PR: not created
Fork decision: adapted for this fork according to local review documentation. Local decision evidence: adapted import.
Verification: see local task record docs/todos/2026-06-15-pr-895-doctor-engine-checks/todo.md for recorded checks and evidence.
Notes: tracker updated from local review documentation on 2026-06-16; issue remains open until separately closed.
Source: Source pull request number: 895 in rohitg00/agentmemory (URL omitted to avoid GitHub cross-reference)
Title: fix(doctor): make engine checks private-install-aware and honor manualOnly
Author: rohitg00
State: open
Draft: no
Merged: no
Head: rohitg00/agentmemory:fix/doctor-private-install-checks @ 18ce604
Base: main @ 25e7701
Labels: (none)
Changed files: 0
Commits: 0
Created: 2026-06-10T22:49:57Z
Updated: 2026-06-10T22:54:11Z
Closed: (not closed)
Merged at: (not merged)
Original PR body:
Closes #874, closes #875.
The engine-version-mismatch and iii-on-path-not-local-bin checks probed only the PATH-resolved iii binary, while their fixes install the pinned engine to ~/.agentmemory/bin, which is only prepended to PATH in-process. Both checks therefore failed forever and re-prompted on every doctor run, and the offered fixes were no-ops.
Both checks now consult the private install first and pass when it exists at the pinned version, noting a mismatched PATH iii as informational detail since the private install wins at runtime. The version-mismatch fix converges: install then recheck passes. runDoctor consults a new canAutoFix helper in both interactive and --all paths, so manualOnly diagnostics print their manual fix hint and count as skipped instead of prompting or auto-applying.
Tested by new cases in test/cli-doctor-fixes.test.ts including a stateful installer stub proving fix convergence.
Summary by CodeRabbit
Bug Fixes
New Features
Local branch: review/issues-874-875-pr-895-doctor-engine-checks
Fork PR: not created
Fork decision: adapted for this fork according to local review documentation. Local decision evidence: adapted import.
Verification: see local task record docs/todos/2026-06-15-pr-895-doctor-engine-checks/todo.md for recorded checks and evidence.
Notes: tracker updated from local review documentation on 2026-06-16; issue remains open until separately closed.