Skip to content

Commit 7eb40e3

Browse files
committed
Add gate in Pwa/ServiceWorker to run in Playwright test but not on dev server generally
1 parent b235366 commit 7eb40e3

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

  • src/components/Pwa/ServiceWorker/client

‎src/components/Pwa/ServiceWorker/client/index.ts‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { registerSW } from 'virtual:pwa-register'
2-
import { isDev } from '@components/scripts/utils/environmentClient'
2+
import { isDev, isE2eTest } from '@components/scripts/utils/environmentClient'
33

44
export const registerServiceWorker = () => {
55
const hasServiceWorker = 'serviceWorker' in navigator
@@ -9,7 +9,10 @@ export const registerServiceWorker = () => {
99
return
1010
}
1111

12-
if (isDev()) {
12+
const devMode = isDev()
13+
const allowDevServiceWorker = devMode && isE2eTest()
14+
15+
if (devMode && !allowDevServiceWorker) {
1316
void navigator.serviceWorker.getRegistrations().then((registrations) => {
1417
registrations.forEach((registration) => {
1518
console.info('[pwa] unregistering dev service worker', { scope: registration.scope })
@@ -19,6 +22,10 @@ export const registerServiceWorker = () => {
1922
return
2023
}
2124

25+
if (allowDevServiceWorker) {
26+
console.info('[pwa] enabling dev service worker for E2E testing')
27+
}
28+
2229
const updateSW = registerSW({
2330
immediate: false,
2431
onNeedRefresh() {

0 commit comments

Comments
 (0)