Fix CodeQL errors

Author: webstackdev

src/pages/api/social-card/__tests__/index.spec.ts

@@ -1,18 +1,6 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { GET } from '@pages/api/social-card'
-import { tmpdir } from 'node:os'
-import { join } from 'node:path'
-
-const accessMock = vi.hoisted(() => vi.fn())
-const mkdirMock = vi.hoisted(() => vi.fn())
-const writeFileMock = vi.hoisted(() => vi.fn())
-const fetchMock = vi.hoisted(() => vi.fn())
-
-vi.mock('node:fs/promises', () => ({
-  access: accessMock,
-  mkdir: mkdirMock,
-  writeFile: writeFileMock,
-}))
+import { fileURLToPath } from 'node:url'
 
 type CollectionFixture = Array<{
   id: string
@@ -79,23 +67,13 @@ const seedCollections = () => {
 }
 
 describe('Social Card API - GET /api/social-card', () => {
-  const expectedAvatarPath = join(tmpdir(), 'webstackbuilders-social-cards', 'kevin-brown.webp')
+  const expectedAvatarPath = fileURLToPath(
+    new URL('../../../../assets/images/avatars/kevin-brown.webp', import.meta.url)
+  )
 
   beforeEach(() => {
     generateOpenGraphImageMock.mockReset()
     generateOpenGraphImageMock.mockResolvedValue(Buffer.from('mock-image'))
-    accessMock.mockReset()
-    mkdirMock.mockReset()
-    writeFileMock.mockReset()
-    fetchMock.mockReset()
-    accessMock.mockRejectedValue(Object.assign(new Error('missing'), { code: 'ENOENT' }))
-    mkdirMock.mockResolvedValue(undefined)
-    writeFileMock.mockResolvedValue(undefined)
-    fetchMock.mockResolvedValue({
-      ok: true,
-      arrayBuffer: vi.fn(async () => Uint8Array.from([1, 2, 3]).buffer),
-    })
-    vi.stubGlobal('fetch', fetchMock)
     seedCollections()
   })
 
@@ -157,18 +135,6 @@ describe('Social Card API - GET /api/social-card', () => {
         }),
       })
     )
-
-    expect(fetchMock).toHaveBeenCalledWith(new URL('/assets/images/kevin-brown.webp', 'http://localhost/api/social-card?slug=home'))
-    expect(writeFileMock).toHaveBeenCalledWith(expectedAvatarPath, expect.any(Buffer))
-  })
-
-  it('reuses the cached avatar file when it already exists locally', async () => {
-    accessMock.mockResolvedValueOnce(undefined)
-
-    await buildRequest('http://localhost/api/social-card?slug=home')
-
-    expect(fetchMock).not.toHaveBeenCalled()
-    expect(writeFileMock).not.toHaveBeenCalled()
   })
 
   it('returns an error response when generation fails', async () => {

src/pages/api/social-card/index.ts

@@ -1,18 +1,16 @@
 import type { APIRoute } from 'astro'
 import { getCollection } from 'astro:content'
 import { generateOpenGraphImage } from 'astro-og-canvas'
-import { access, mkdir, writeFile } from 'node:fs/promises'
-import { tmpdir } from 'node:os'
-import { join } from 'node:path'
+import { fileURLToPath } from 'node:url'
 import { buildApiErrorResponse, handleApiFunctionError } from '@pages/api/_utils/errors'
 import { createApiFunctionContext } from '@pages/api/_utils/requestContext'
 
 export const prerender = false
 
 const ROUTE = '/api/social-card'
-const PUBLIC_AVATAR_PATH = '/assets/images/kevin-brown.webp'
-const CACHED_AVATAR_DIRECTORY = join(tmpdir(), 'webstackbuilders-social-cards')
-const CACHED_AVATAR_PATH = join(CACHED_AVATAR_DIRECTORY, 'kevin-brown.webp')
+const AVATAR_FILE_PATH = fileURLToPath(
+  new URL('../../../assets/images/avatars/kevin-brown.webp', import.meta.url)
+)
 const DEFAULT_TITLE = 'Platform Engineering by Kevin Brown'
 const DEFAULT_DESCRIPTION =
   'Platform engineer helping teams harden delivery, modernize cloud platforms, and improve developer experience.'
@@ -61,29 +59,6 @@ const gradientPalette: Record<PaletteKey, [number, number, number][]> = {
   ],
 }
 
-const getAvatarFilePath = async (requestUrl: string): Promise<string> => {
-  try {
-    await access(CACHED_AVATAR_PATH)
-    return CACHED_AVATAR_PATH
-  } catch {
-    // Cache miss; fetch from the public asset URL and persist locally for astro-og-canvas.
-  }
-
-  const avatarUrl = new URL(PUBLIC_AVATAR_PATH, requestUrl)
-  const response = await fetch(avatarUrl)
-
-  if (!response.ok) {
-    throw new Error(`Unable to fetch Kevin Brown avatar from ${avatarUrl.toString()}`)
-  }
-
-  const avatarBuffer = Buffer.from(await response.arrayBuffer())
-
-  await mkdir(CACHED_AVATAR_DIRECTORY, { recursive: true })
-  await writeFile(CACHED_AVATAR_PATH, avatarBuffer)
-
-  return CACHED_AVATAR_PATH
-}
-
 /** Normalize slug parameters to a consistent format */
 const normalizeSlug = (value: string | null): string => {
   if (!value) return 'home'
@@ -147,7 +122,6 @@ export const GET: APIRoute = async ({ request, clientAddress, cookies }) => {
     const slug = normalizeSlug(url.searchParams.get('slug'))
     const titleOverride = url.searchParams.get('title')
     const descriptionOverride = url.searchParams.get('description')
-    const avatarPath = await getAvatarFilePath(request.url)
 
     const contentIndex = await buildContentIndex()
     const matchedEntry = contentIndex[slug]
@@ -167,7 +141,7 @@ export const GET: APIRoute = async ({ request, clientAddress, cookies }) => {
       bgGradient: gradientPalette[palette],
       padding: 80,
       logo: {
-        path: avatarPath,
+        path: AVATAR_FILE_PATH,
         size: [140, 140],
       },
       font: {