Change Playwright E2E flag from 'DEBUG' to 'CI' so it works on GitHub Actions

Author: webstackdev

.github/instructions/general.instructions.md

@@ -77,8 +77,8 @@ When a Playwright-native action (e.g., `page.click()`, `page.fill()`, `page.hove
 ## E2E Testing Standards
 
 - **NEVER hard-code content slugs in e2e tests** (e.g., `/articles/typescript-best-practices`, `/services/web-development`). Content can be deleted or renamed. Always dynamically fetch the first available item from listing pages (articles, services, case-studies, etc.) and navigate to it. This prevents test breakage when content changes.
-- **Playwright E2E Tests**: ALWAYS run with `DEBUG=1` environment variable (e.g., `DEBUG=1 npx playwright test`). This prevents the Playwright test runner from launching its own dev server. The user maintains a running dev server for development.
-- **NEVER run the full e2e test suite** unless explicitly requested by the user. The full suite is very resource intensive and takes over 10 minutes to run. Only run specific e2e test files when verification is needed (e.g., `DEBUG=1 npx playwright test test/e2e/specific-file.spec.ts`).
+- **Playwright E2E Tests**: ALWAYS run with `CI=1` environment variable (e.g., `CI=1 npx playwright test`). This prevents the Playwright test runner from launching its own dev server. The user maintains a running dev server for development.
+- **NEVER run the full e2e test suite** unless explicitly requested by the user. The full suite is very resource intensive and takes over 10 minutes to run. Only run specific e2e test files when verification is needed (e.g., `CI=1 npx playwright test test/e2e/specific-file.spec.ts`).
 - **NEVER start a dev server yourself**. The user runs their own dev server for development. When you need a dev server running, notify the user instead of starting one.
 
 ### Astro View Transitions Testing

.github/instructions/testing.instructions.md

@@ -14,7 +14,7 @@ applyTo: "**/*.spec.ts"
 ## E2E Testing
 
 - **NEVER hard-code content slugs** - fetch dynamically from listing pages
-- **Always run with `DEBUG=1`** - e.g., `DEBUG=1 npx playwright test test/e2e/file.spec.ts`
+- **Always run with `CI=1`** - e.g., `CI=1 npx playwright test test/e2e/file.spec.ts`
 - **NEVER run full e2e suite** unless requested - it takes 10+ minutes
 - **NEVER start dev server** - user maintains running server
 - **Use `BasePage.waitForPageLoad()`** to wait for `astro:page-load` event

_TODO.md

@@ -1,9 +1,5 @@
 # TODO
 
-## CI
-
-Change the DEBUG=1 flag to C1=1, add an isCI() method to environment, check both CI and whatever GitHub Actions uses, update Playwright config to it and docs
-
 ## Analytics
 
 Vercel Analytics

playwright.config.ts

@@ -10,8 +10,8 @@ import 'dotenv/config'
  * See https://playwright.dev/docs/test-configuration.
  */
 
-/** Debug mode - set DEBUG=1 or DEBUG=true to run only chromium with no HTML report */
-const isDebugMode = Boolean(process.env['DEBUG'] && process.env['DEBUG'] !== 'false' && process.env['DEBUG'] !== '0')
+/** Debug mode - set CI=1 or CI=true to run only chromium with no HTML report */
+const isCIMode = Boolean(process.env['CI'] && (process.env['CI'] === 'true') || process.env['CI'] === '1')
 
 export default defineConfig({
   /* Look for test files in the "tests" directory, relative to this configuration file. */
@@ -44,7 +44,7 @@ export default defineConfig({
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: process.env['CI']
     ? 'github'
-    : isDebugMode
+    : isCIMode
       ? [
           ['list'],
           ['json', { outputFile: '.cache/playwright/results.json' }],
@@ -107,7 +107,7 @@ export default defineConfig({
 
   /* Run your local dev server before starting the tests */
   /* In debug mode, assume server is already running */
-  ...(isDebugMode
+  ...(isCIMode
     ? {}
     : {
         webServer: {