Refactor e2etests

Author: webstackdev

package.json

@@ -43,6 +43,7 @@
     "dev": "npm run sync && cross-env NODE_ENV=development FORCE_COLOR=1 npx astro dev",
     "dev:local": "FORCE_COLOR=1 dotenv -e .env.development -- npm run dev",
     "dev:local:verbose": "FORCE_COLOR=1 dotenv -e .env.development -- npm run dev -- --verbose",
+    "dev:stop": "astro dev stop",
     "format": "npm run format:code && npm run format:style",
     "format:code": "FORCE_COLOR=1 npx prettier --write \"@types/**/*.{js,ts}\" \"src/**/*.{js,ts,tsx,astro}\" --plugin=prettier-plugin-astro",
     "format:markdown": "FORCE_COLOR=1 npx markdownlint-cli2 --fix \"**/*.{md,mdx}\"",

test/e2e/helpers/pageObjectModels/BreadCrumbPage.ts

@@ -83,9 +83,9 @@ export class BreadCrumbPage extends BasePage {
   async openFirstArticleDetail(options?: { navigationMode?: 'client' | 'fresh' }): Promise<void> {
     await this.navigateToListingDetail({
       listingPath: '/articles',
-      linkSelector: 'main a[href^="/deep-dive/"], main a[href^="/articles/"]',
+      linkSelector: 'main a[href^="/articles/"]',
       minSegments: 2,
-      notFoundMessage: 'Could not find deep-dive or article detail link on /articles',
+      notFoundMessage: 'Could not find article detail link on /articles',
       ...options,
     })
   }

test/e2e/specs/01-smoke/dynamic-pages.spec.ts

@@ -6,7 +6,7 @@
 import { BasePage, test, expect, setupConsoleErrorChecker, logConsoleErrors } from '@test/e2e/helpers'
 import { wait } from '@test/e2e/helpers/waitTimeouts'
 
-const articleLinkSelector = 'a[href*="/deep-dive/"]'
+const articleLinkSelector = 'a[href*="/articles/"]'
 const serviceLinkSelector = 'a[href^="/services/"]:not([href="/services/"])'
 const caseStudyLinkSelector = 'a[href*="/case-studies/"]'
 
@@ -54,8 +54,8 @@ test.describe('Dynamic Pages @smoke', () => {
     await expect(page.locator('main#main')).toBeVisible()
     await expect(page.locator('h1[id="article-title"]')).toBeVisible()
 
-    // Verify we're on a deep-dive detail page from the articles listing
-    expect(page.getCurrentUrl()).toMatch(/\/deep-dive\/.+/)
+    // Verify we're on an article detail page from the articles listing
+    expect(page.getCurrentUrl()).toMatch(/\/articles\/.+/)
   })
 
   test('@ready service detail page loads', async ({ page: playwrightPage }) => {

test/e2e/specs/02-pages/articles.spec.ts

@@ -75,10 +75,10 @@ test.describe('Articles Page', () => {
     const page = await BasePage.init(playwrightPage)
     await page.goto('/articles')
 
-    // Get the first deep-dive link from the articles index page
+    // Get the first article link from the articles index page
     await page.click('article a')
-    // Should navigate to a deep-dive detail page
-    await page.expectUrl(/\/deep-dive\/[^/]+/)
+    // Should navigate to an article detail page
+    await page.expectUrl(/\/articles\/[^/]+/)
   })
 
   test('@ready page subtitle displays', async ({ page: playwrightPage }) => {

test/e2e/specs/02-pages/tags.spec.ts

@@ -21,8 +21,8 @@ test.describe('Tags Index Page', () => {
   test('@ready tag counts display', async ({ page: playwrightPage }) => {
     const page = await BasePage.init(playwrightPage)
     await page.goto('/tags')
-    // Each tag carousel should render at least one deep-dive card link
-    await page.expectElementVisible('a[href^="/deep-dive/"]')
+    // Each tag carousel should render at least one article card link
+    await page.expectElementVisible('a[href^="/articles/"]')
   })
 
   test('@ready responsive: mobile view renders correctly', async ({ page: playwrightPage }) => {

test/e2e/specs/07-metadata/open-graph.spec.ts

@@ -8,7 +8,7 @@ import { BasePage, test, expect } from '@test/e2e/helpers'
 import { wait } from '@test/e2e/helpers/waitTimeouts'
 
 const REQUIRED_META_TAGS = ['og:title', 'og:description']
-const articleDetailLinkSelector = 'a[href^="/deep-dive/"], a[href^="/articles/"]:not([href="/articles/"])'
+const articleDetailLinkSelector = 'a[href^="/articles/"]:not([href="/articles/"])'
 
 test.describe('Open Graph Metadata', () => {
   test('@ready homepage has required OG tags', async ({ page: playwrightPage }) => {

test/e2e/specs/07-metadata/seo-tags.spec.ts

@@ -7,7 +7,7 @@
 import { BasePage, test, expect } from '@test/e2e/helpers'
 import { wait } from '@test/e2e/helpers/waitTimeouts'
 
-const articleDetailLinkSelector = 'a[href^="/deep-dive/"], a[href^="/articles/"]:not([href="/articles/"])'
+const articleDetailLinkSelector = 'a[href^="/articles/"]:not([href="/articles/"])'
 
 test.describe('SEO Meta Tags', () => {
   test('@ready all pages have meta description', async ({ page: playwrightPage }) => {

test/e2e/specs/07-metadata/structured-data.spec.ts

@@ -35,7 +35,7 @@ interface ContactPageSchema extends JsonLdSchema {
   url?: string
 }
 
-const articleDetailLinkSelector = 'a[href^="/deep-dive/"], a[href^="/articles/"]:not([href="/articles"])'
+const articleDetailLinkSelector = 'a[href^="/articles/"]:not([href="/articles"])'
 
 const expectAbsoluteUrl = (value: unknown): void => {
   expect(typeof value).toBe('string')