Change Cookies Consent modal to trigger on astro:page-load event

Author: webstackdev

src/components/Cookies/Consent/client.ts

@@ -24,7 +24,7 @@ import { handleScriptError, addScriptBreadcrumb } from '@components/Scripts/erro
  */
 export class CookieConsent extends LoadableScript {
   static override scriptName = 'CookieConsent'
-  static override eventType: TriggerEvent = 'delayed'
+  static override eventType: TriggerEvent = 'astro:page-load'
 
   /** Modal wrapper element */
   wrapper: HTMLDivElement

src/components/Scripts/state/index.ts

@@ -347,7 +347,7 @@ export function initStateSideEffects(): void {
 
   // Side Effect 6: Show/hide cookie modal
   $cookieModalVisible.subscribe(visible => {
-    const modal = document.getElementById('cookie-consent-modal-id')
+    const modal = document.getElementById('cookie-modal-id')
     if (modal) {
       modal.style.display = visible ? 'flex' : 'none'
     }

test/e2e/specs/01-smoke/critical-paths.spec.ts

@@ -98,17 +98,15 @@ test.describe('Critical Paths @smoke', () => {
     await expect(page.locator('button[aria-label="toggle theme switcher"]')).toBeVisible()
   })
 
-  test.skip('@ready cookie consent banner appears', async ({ page, context }) => {
-    // FIXME: Cookie modal exists in DOM but is CSS hidden - appears to be an application bug
-    // The modal doesn't show even after clearing cookies
+  test('@ready cookie consent banner appears', async ({ page, context }) => {
     // Clear consent cookies to force banner to appear
     await clearConsentCookies(context)
 
     await page.goto('/')
     await page.waitForLoadState('networkidle')
 
-    // Cookie modal should be visible (wait for animation/JS to show it)
-    await expect(page.locator('#cookie-modal-id')).toBeVisible({ timeout: 10000 })
+    // Cookie modal should be visible
+    await expect(page.locator('#cookie-modal-id')).toBeVisible()
   })
 
   test('@ready main pages have no 404 errors', async ({ page }) => {