Skip to content

Commit da61e20

Browse files
committed
Fix Tasklist styling for dark theme
1 parent c192ca8 commit da61e20

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

‎_TODO.md‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,6 @@ https://mermaid.js.org/config/directives.html
210210

211211
- Uppy, Tus server, whatever other server needed for file upload on Contact Form component
212212

213-
- Focus-visible / active handling on ToC nav items
214-
215-
- Style "Share to Mastodon" modal in src/components/Social/Mastodon/client/index.ts
216-
217213
- There's a pretty long delay when you push the Content Switcher to go from short to deep dive, what's causing it? It should be fast - maybe it's a prefetch issue, prefetch on page load
218214

219215
- Search box in header should have blue outline, not highlight
@@ -224,14 +220,9 @@ https://mermaid.js.org/config/directives.html
224220

225221
- Improve `<abbr>` styling: https://codepen.io/ire/pen/NoqWpm
226222

227-
## List Component
228-
229-
- Task list checked variant Markdown in dark theme is awkward, it has a dark shadow
230-
231-
## Header
223+
## Header - "Squish" Effect
232224

233225
- Need to improve the "squish" animation where the header reduces in size on scroll down, and returns to full size on scroll up. Maybe reduce and expand the text and search / themepicker / hamburger menu sizes in place, and then slide them horizontally.
234-
235226
- Moving the scroll bar up quickly with the mouse seems to make the header logic break - the Switcher component and Breadcrumbs are hidden under the header
236227
- Themepicker and search icon are too big in non-squished header. Logo too - the initial presentation should be smaller.
237228

‎src/styles/markdown.css‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,7 @@
296296
.markdown-list li.task-list-item > input[type='checkbox'] {
297297
appearance: none;
298298
background-color: var(--color-page-offset);
299+
background-image: none;
299300
border: 2px solid var(--color-content-offset);
300301
border-radius: var(--radius-sm, 0.25rem);
301302
box-sizing: border-box;
@@ -319,6 +320,7 @@
319320

320321
.markdown-list li.task-list-item > input[type='checkbox']:checked {
321322
background-color: var(--color-success);
323+
background-image: none;
322324
border-color: var(--color-success);
323325
}
324326

0 commit comments

Comments
 (0)