Cinder: Missing Scheduler stats Java SDK

[ansaba]

Hi,

In Kilo version of Cinder, it is exposing new api scheduler-stats/get_pools which will help user to get the Pool information which has capacity/usage and other capabilities information of backend storage.

I have written the java SDK for it. I would like to know the process to submit it for review.

[woorea]

Sure!

[woorea]

Hi Saba,

Thanks for the pull request,

Two things:

1. Use underscore in constants SCHEDULERSTATS > SCHEDULER_STATS
2. Do not concatenate Strings with (+), instead use StringBuilder append

The other parts of your code looks good

[ansaba]

Hello,

I have implemented the review comments. Thanks for your time.

Thanks,
Saba

[ansaba]

Hello,

I have implemented recent review comments by Daniel. Let me know for any changes.

Thanks,
Saba

[woorea]

Daniel is who implemented all the cinder stuff, your changes looks fine but
let's wait for his comments

Thanks

On Thu, Apr 30, 2015 at 10:54 PM, ansaba notifications@github.com wrote:

Hello,

I have implemented recent review comments by Daniel. Let me know for any
changes.

Thanks,
Saba

—
Reply to this email directly or view it on GitHub
#182 (comment)
.

---

Luis Alberto Gervaso Martin
Woorea Solutions, S.L
CEO & CTO
mobile: (+34) 627983344
luis@ luis.gervaso@gmail.comwoorea.es