Skip to content

Setup instructions in README.md outdated #11

Description

@danielhoop

Thanks a lot for this module!
I just wanted to inform you that one step of the process to integrate the module in an app (described in README.md) is outdated.
Erroneous part after: "Register module in MainActivity.java"

...
Block that describes changes to public class MainActivity extends ReactActivity
...

According to the React Native Documentation it should be done like this:
In MainApplication.java ...

import com.xeodou.rctplayer.*;  // <--- import
...
@Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
	  new ReactPlayerManager()  // <--- insert
      );
    }
...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions